Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp894597lqp; Thu, 23 May 2024 03:23:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWbjg6zRSkihYKvcM4SzWs37uSWtyLjGWXhZM1wJWur3VsD2/vgkCO09xMogBo2ZcMrMIPYvvtJYM5koairoYvPGFcn+wCZ7c3+z1kxGw== X-Google-Smtp-Source: AGHT+IGmHWYPGwyaUQqAcROJ6P0C09MH0SSt677cgtTImwtktimssP8kBSgreY2LkPyOkf/AbDHV X-Received: by 2002:a05:6a20:840c:b0:1b1:f7a1:dfa2 with SMTP id adf61e73a8af0-1b1f8b2b401mr4851853637.45.1716459792735; Thu, 23 May 2024 03:23:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716459792; cv=pass; d=google.com; s=arc-20160816; b=INlQYyj6R1YblunSXU6s+6oJP36UQsyo+NH2ZsF2DO3fjSMQ9Tap2FTmTsrUg8+nYl kEgTLZcQ00IQahb5YpF7ceBn4QJkUGYo1eBTLmEoFHNj8rxGYwKxHJtvFfwmrjTRut5v pqKwxZcf4aGYQEYLAfQwmP+3tHjR/cWvcHWzarKCtErsXLuVjd46f8yj7e2KolSSlZ3y AyMSEqw3ASjVALAdVazMr5VFmo2TGKqCZkGQGMZmYdKRAWJlb9+yFzlxjXGY57UgHooJ VYcDpuhnK4RCZS8w0JeolwSYBEuNqprEsEhLQVCH6Wmok6esPMnd4WOBKLVuE8Tgrdn6 Jv+Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yHQzcgh+wt+86lDxNvmMSEbfCa2z01pUSJ+bgewkqHY=; fh=34KNu7G47+1P0ZrPZlscKSMrllyNBJ5wMbyORe6q1ic=; b=VJhcRq4g0vCic8sbPuWqTSuVOy+qmgmxzK7c5eTEPtqVeTw52PnOHG6bISUTViQJ9T 8BPTcSEk/T7Xn07wsCUU0MoIXALtXtPJ8FhfO67+w8NsQh74GOpYQfOAdl9QMUSgd0rd IyWcZtsObi/MgbYo+aRIdEi/UQKO7fsQigOZDNYmiSZFwguYo2gKJ4yoZByyMQsAfMUe lFZo1K0XxKHCNj5w3u/VM1fgzljiaPHYHKpqq3qdLI748dEZbhS7Ir/0/Rn0Lu7jLm0r gc42uphz0Pv4wdEWkgUIl+Mo1PmbDb9qCdQyNXNs5bN9DROd5WuyIq22kP7AbxYQ81u/ EVZg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Yat3ExrS; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-187329-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-187329-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bdd9f01223si1379316a91.39.2024.05.23.03.23.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 03:23:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-187329-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Yat3ExrS; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-187329-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-187329-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5992F2814D3 for ; Thu, 23 May 2024 10:23:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3C0E413CF85; Thu, 23 May 2024 10:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Yat3ExrS" Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5762078C8B for ; Thu, 23 May 2024 10:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716459783; cv=none; b=FOrFMzL8W2wAFrB3BUZ1DYCc8XCC6oRT6v2lCvv3jzIacC2k50miuFeMVkde9izyeGq/L+qEjrRXpm34mIV9yFo7kcM4g3xiTnYSOnrfkjvlyj4DGZ79F1FAGXTj+AM+2iJRpNSFPbCIejr/vVuJPfeghaAVu5ahhFY9KCGF5XA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716459783; c=relaxed/simple; bh=4FADG5CtgDgZ0nIGhxXBr21dhRNWj/4o2A+QCOzfNN8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ek+ZPuMOliOjf9apndXvV3tzpH77vBp2+yNgz1f9M9WB8bG3NWcEPN1ORZoSIcU3mIFtw7Sca46/NkQlWLOZUIcinxGdkumkhaEv+frPZkGG1ZdoxlGG63KSKTNOrXaT29X9j5zsGm7qKBhRgJm36GqyljPlGy8NJ26jXTwPSwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Yat3ExrS; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-51f4d2676d1so7580472e87.3 for ; Thu, 23 May 2024 03:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716459778; x=1717064578; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yHQzcgh+wt+86lDxNvmMSEbfCa2z01pUSJ+bgewkqHY=; b=Yat3ExrSEVuOMZh0FORKuCGPXzLkvnVcrFPvqkYFywgyZBO9vhhptmjd41emHpzHlN nFWw4INv7hN/N8hF0FIvqY6U/xXaogMWBaMhZ/jYQNXtSbagWWMzWiK7xDBv+XEhEShc 3E5yUQVoQ/ZgUGDmp8D7IjvrDlGLDPqULOFnWcvaolFaoyYCeUj55HsR9360Tis9Fhd5 9ILn1hM7LodOsfOkyN3vgAlfXPmgLr0VR7lPmq2kgIcHMUd1WiSJtXKiOKQmM3xdP792 JUw+OLRh1K9lxMo3lCWbEn2ETmSr8vg6vNv3oe9kn1oblxgXIAOHeKNi8rij6I6yAugP FTig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716459778; x=1717064578; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yHQzcgh+wt+86lDxNvmMSEbfCa2z01pUSJ+bgewkqHY=; b=EhMUjuyY/WOwQyuDrI5MOFmJ1yu1/p6LwKujQklrUE8burT+Wr2k47fTGZ21HfwE/s Lmyc8m8d7L/slAXZdQNlg+d2NbBJlgJuHKnqVCB9WqsyT+UqvF+xaa7VJ7mMswxFe+5S SxvsEOcFYI53djqhZkFpl/pt9bh550OBFDhFvVEqht5SRjGaHZC31SBk6VGB2ln0PX+q PDUBo/czkXAsCl8V533BBIoOP889pHei4GOGkV/KGaL1XsYBA/erfHfhvZG0Y2JiEXA5 dXUiE4c3atWZJwV1Zmklyh4doQCT/BB2R1sqZh7U7NG671yaNHRQiNopsCkCVLrrEZCb m1QQ== X-Forwarded-Encrypted: i=1; AJvYcCU+9cBG4iX+Jzk++3IzWKB+EugdopFpFKqb+VxzDgUHQhTUPpf4v+A8PpbMDJLfSND8xVbXRNrm9dqUW9LTHImGRqgcIET5KGcpbhot X-Gm-Message-State: AOJu0YyMqrtbkZUBTjIBAWE8tE9ABKqAcpD9dM0yKmIbfPE91kjhLNNB oLcXY+qmby7lL6xIVT1C5whTZpqepxbcCOZqmqECrSL/v6jTkFZ3hKYCs7zfjwM= X-Received: by 2002:a05:6512:4cd:b0:51a:cc00:951b with SMTP id 2adb3069b0e04-526c0c544abmr2482181e87.49.1716459778462; Thu, 23 May 2024 03:22:58 -0700 (PDT) Received: from eriador.lumag.spb.ru (dzdbxzyyyyyyyyyyyykxt-3.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::227]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-521f38d90b2sm5326325e87.242.2024.05.23.03.22.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 03:22:57 -0700 (PDT) Date: Thu, 23 May 2024 13:22:56 +0300 From: Dmitry Baryshkov To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jonathan Corbet , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andy Yan , Hans Verkuil , Sebastian Wick , Ville =?utf-8?B?U3lyasOkbMOk?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Dave Stevenson , Pekka Paalanen Subject: Re: [PATCH v14 17/28] drm/connector: hdmi: Add Broadcast RGB property Message-ID: <4n55dbl2h275z5ubebigri4xjtjsvt44w62n656srdgndcav2j@rrq5haucqx5u> References: <20240521-kms-hdmi-connector-state-v14-0-51950db4fedb@kernel.org> <20240521-kms-hdmi-connector-state-v14-17-51950db4fedb@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240521-kms-hdmi-connector-state-v14-17-51950db4fedb@kernel.org> On Tue, May 21, 2024 at 12:13:50PM +0200, Maxime Ripard wrote: > The i915 driver has a property to force the RGB range of an HDMI output. > The vc4 driver then implemented the same property with the same > semantics. KWin has support for it, and a PR for mutter is also there to > support it. > > Both drivers implementing the same property with the same semantics, > plus the userspace having support for it, is proof enough that it's > pretty much a de-facto standard now and we can provide helpers for it. > > Let's plumb it into the newly created HDMI connector. > > Reviewed-by: Dave Stevenson > Acked-by: Pekka Paalanen > Reviewed-by: Sebastian Wick > Signed-off-by: Maxime Ripard > --- > Documentation/gpu/kms-properties.csv | 1 - > drivers/gpu/drm/display/drm_hdmi_state_helper.c | 4 +- > drivers/gpu/drm/drm_atomic.c | 2 + > drivers/gpu/drm/drm_atomic_uapi.c | 4 ++ > drivers/gpu/drm/drm_connector.c | 88 +++++++++++++++++++++++++ > include/drm/drm_connector.h | 36 ++++++++++ > 6 files changed, 133 insertions(+), 2 deletions(-) > > diff --git a/Documentation/gpu/kms-properties.csv b/Documentation/gpu/kms-properties.csv > index 0f9590834829..caef14c532d4 100644 > --- a/Documentation/gpu/kms-properties.csv > +++ b/Documentation/gpu/kms-properties.csv > @@ -15,11 +15,10 @@ Owner Module/Drivers,Group,Property Name,Type,Property Values,Object attached,De > ,,“saturation”,RANGE,"Min=0, Max=100",Connector,TBD > ,,“hue”,RANGE,"Min=0, Max=100",Connector,TBD > ,Virtual GPU,“suggested X”,RANGE,"Min=0, Max=0xffffffff",Connector,property to suggest an X offset for a connector > ,,“suggested Y”,RANGE,"Min=0, Max=0xffffffff",Connector,property to suggest an Y offset for a connector > ,Optional,"""aspect ratio""",ENUM,"{ ""None"", ""4:3"", ""16:9"" }",Connector,TDB > -i915,Generic,"""Broadcast RGB""",ENUM,"{ ""Automatic"", ""Full"", ""Limited 16:235"" }",Connector,"When this property is set to Limited 16:235 and CTM is set, the hardware will be programmed with the result of the multiplication of CTM by the limited range matrix to ensure the pixels normally in the range 0..1.0 are remapped to the range 16/255..235/255." Should it still be defined as a generic property? > ,,“audio”,ENUM,"{ ""force-dvi"", ""off"", ""auto"", ""on"" }",Connector,TBD > ,SDVO-TV,“mode”,ENUM,"{ ""NTSC_M"", ""NTSC_J"", ""NTSC_443"", ""PAL_B"" } etc.",Connector,TBD > ,,"""left_margin""",RANGE,"Min=0, Max= SDVO dependent",Connector,TBD > ,,"""right_margin""",RANGE,"Min=0, Max= SDVO dependent",Connector,TBD > ,,"""top_margin""",RANGE,"Min=0, Max= SDVO dependent",Connector,TBD > diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/drm/display/drm_hdmi_state_helper.c > index 93cb30dba86e..888fe1fe9594 100644 [the rest LGTM] -- With best wishes Dmitry