Received-SPF: pass (google.com: domain of linux-kernel+bounces-187336-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 23 May 2024 13:33:28 +0300
From: "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, 
	dave.hansen@linux.intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, 
	Ingo Molnar <mingo@kernel.org>, Steve Wahl <steve.wahl@hpe.com>
Subject: Re: [Patch v2] x86/head/64: remove redundant check on
 level2_kernel_pgt's _PAGE_PRESENT bit
Message-ID: <fej5k6ikc3biecm5xadxgwv2pflktpjmvrxjhzmhia4p5kipun@ny3swf6kcqwi>
References: <20240523083752.11426-1-richard.weiyang@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240523083752.11426-1-richard.weiyang@gmail.com>

On Thu, May 23, 2024 at 08:37:52AM +0000, Wei Yang wrote:
> This patch tries to remove a redundant check on kernel code's PMD
> _PAGE_PRESENT attribute before fix up.

Tries? s/This patch tries to r/R/

> Current process looks like this:
> 
>     pmd in [0, _text)
>         unset _PAGE_PRESENT
>     pmd in [_text, _end]
>         if (_PAGE_PRESENT)
>             fix up delta
>     pmd in (_end, 512)
>         unset _PAGE_PRESENT
> 
> Since we have compiled in _PAGE_PRESENT in this page table, it is not
> necessary to check _PAGE_PRESENT again before fixing up delta

level2_kernel_pgt compiled with _PAGE_PRESENT set. The check is
redundant.


-- 
  Kiryl Shutsemau / Kirill A. Shutemov