Received-SPF: pass (google.com: domain of linux-kernel+bounces-187344-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <bf2ea452-75ea-4091-90fe-c83062729b76@amd.com>
Date: Thu, 23 May 2024 16:10:28 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] iommu/amd: Use try_cmpxchg64() in v2_alloc_pte()
To: Uros Bizjak <ubizjak@gmail.com>, iommu@lists.linux.dev,
 linux-kernel@vger.kernel.org
Cc: Joerg Roedel <joro@8bytes.org>,
 Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
 Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>
References: <20240522082729.971123-1-ubizjak@gmail.com>
Content-Language: en-US
From: Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <20240522082729.971123-1-ubizjak@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a0NGRWhDbXc4Q2NJcERFZEZNdytuZlJlMHFTemdJd1hVMXFvb0w5TEJMNERo?=
 =?utf-8?B?MDNiMmlNclBlK0h2cm9kbEUraEZnVjNKdHFaUlJobEtaSndsOVo2cThoTmFW?=
 =?utf-8?B?TUpRSDYxT092M0ZxRWxEYzVLbGpFYkJydjIyaE5QMlY3WmhJdWVhZXc5Wmls?=
 =?utf-8?B?cUxYRllsdFRtVEQ2dDZBdDl3SW5BcEZNTUhtQ085QzMwRExDVDhodG05czEz?=
 =?utf-8?B?NEV0R0c3NGFhSVo0bmtiRTczbmRNdDRtaDE4d1RzRjlkbWcyUDNtdzRZM0xy?=
 =?utf-8?B?bVRFaytSWXU2VGFtdXhzbW1OYU9sUEFOWlVaSWFlb01tUEc5SmNPSUExTmoy?=
 =?utf-8?B?d3BBNjFSdnd4N2NSVmQxek8zLzVCRldFL21LdlVIa3Y3RTFOKzh4SGtOQ3c3?=
 =?utf-8?B?cU1UalQxMW4wdFNoZ0kvQ01wVzJEQUJtNzRoeG4zcnVzaXNNWjZEWXdmN1pB?=
 =?utf-8?B?U3hndldmNUU2ZlI4Um81bzNVZ3Q4bnBjcHpWQ3JuU2M0S0daZlMrVDhsbGVr?=
 =?utf-8?B?bnhMTU5DOFVMT1NEeWZaNzBiQlhCOW90dUxxRUd6aThUaU5JeDRCbGNZTUlI?=
 =?utf-8?B?TnF2MXlsM3BDcEU0eVRDRi9VWnVKdldHMFdDbHZrSUQ5VStlVDlPN3VxRXMv?=
 =?utf-8?B?bGRmVmlUQ0l0clJ6VmRuOEU0dFdNMzBsWVp1NVQ4RkFkWEdvcXdaYnQ0VFo4?=
 =?utf-8?B?c1NRZTNNWjBYSXVNNXFlK3NXS013dWordzRtUFZadzArOVArU1dIR2VHUE5Y?=
 =?utf-8?B?YXdhN0NSY0I5ZjFmV0w3VWF4V2NmU1NqeWdxTVBlaHFKSlMwbHpHVkl5U05l?=
 =?utf-8?B?Q09aQXEwZXE0RFpFbG9ocS8wQWtrVmpBaDdxeE1ySWFpUERtaTNUUHVCRER6?=
 =?utf-8?B?L0o4K1VzYVFZWmIramd0RFBCY08rYlh4V2xjakRyNzJNUVVDalpZSTF0YlAy?=
 =?utf-8?B?REdnblNzTis5ZjdJOU1iWi9YY0d2b1dGTUM1amdoYU9XaituTjdsRGtsVUJI?=
 =?utf-8?B?azRDK0JXbU9IZks3Z1Z5UEtSb2ZOdklkcytoVXVYY0U1STI1VEFWRktmS2hZ?=
 =?utf-8?B?QnFNUGdPNGVvTUFXeHlsb2daZVdlckFrOHhaN3N4emw2d1JDQ0lXamtRRmlS?=
 =?utf-8?B?cUZ1NzY1L21SMW5TWmxHN2ZyY0xlNEw3azVjOEMvOUhqSnQ3bE01Z0hUdm1p?=
 =?utf-8?B?eEIyTTN6elJQOG12RVR6TkNBdFN2Rnd1N2k5TXpzWXZ4Mk9pRGttOFhSRi84?=
 =?utf-8?B?VE5tcHRpaUd5b2dsdEt3MXVqTTZ2WFZlSDZPb2NyTDd0dnNmclRUZ3dNVGZ3?=
 =?utf-8?B?dXo0QVBTa3dDbVBDZG1wODh0aHU3ZlBIcU9YM2REd2Y3d0g4NnJFMmdPYmNr?=
 =?utf-8?B?NXdiMURadGZ0SXJTSTh1ZEVNbmdOUktQdFRXY1VsNGp3N0c5Z2lmcUJ2VTEx?=
 =?utf-8?B?Zy9udGVkMW1KVzl3RVlOUkZkNHdTbUREa1M0VnhvUGZaTWRyTHVCYXdBUXY3?=
 =?utf-8?B?bnF1RW04MWwxUlNmQnpOd09RL3FOMGVFTlZpcS9Ca0pyL3J3M25TaDg3VTcx?=
 =?utf-8?B?ZzJROHRnbG16Q1dqV2ZNV1lYdXFhTTJ1em1YZ2FjYWJORXg4NWl2aFVaSW5m?=
 =?utf-8?B?cWlpdzRwUlZBRlladGRXYzZSR2dOamhQRGh1UjN2Rk9PbUF2dUJQMDFNaG9z?=
 =?utf-8?B?NVlPT295WlZWem5hamp2SzFRS1g4Q1hHZE9jdEtLRFdvMzhJcCszb1BjQzU0?=
 =?utf-8?B?d040WGFIK3pXdGxTYjdUNjNJbU5tdWdqM0RHcG9pSUcwMFMzdEJsU0NnbS9O?=
 =?utf-8?B?ZHg3MWFwV1dBZE01S1JzdzdPS1M5aHpxK0lnTkNpd0oxZHY0VE5HYUpiQlpV?=
 =?utf-8?B?a2J4NzFzOGViVWQ1enoxUUlrOGVDMmJHbjRXTjFHWXNHZWlhbmcrS0VvNUxF?=
 =?utf-8?B?UldacFIrcU1FU3htdFZqeTB0UGFHMTMvN1VmS0hGZm5LL04zWXZVYjhTRzMr?=
 =?utf-8?B?NGkxeTBOU09WYkpGUXpPZDdZdGFmQTdIZnh1emxKNFFWQVNyWksxd21SWFRi?=
 =?utf-8?B?aUJOS0dwMGt1Nk1qTk0rL21FV2Z4aVlpUDNLdHNZb1Z3YTlsQ1VXSWNlL1Vq?=
 =?utf-8?Q?NcQGix4vz9mMzyhBeLJCU1ScU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bdcc1f5-e8e0-490a-6eb3-08dc7b14c911
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 10:40:38.6142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lZRD6ziPMcUWnaXYFg+CC6MgonJz7G8M5vddpAyU5AZQjNinvOuVC/YOOtuRvrACdWXKYXo++5CG1PiDTtQjpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6483


On 5/22/2024 1:56 PM, Uros Bizjak wrote:
> Use try_cmpxchg64() instead of cmpxchg64 (*ptr, old, new) != old in
> v2_alloc_pte().  cmpxchg returns success in ZF flag, so this change
> saves a compare after cmpxchg (and related move instruction
> in front of cmpxchg).
> 
> This is the same improvement as implemented for alloc_pte() in:
> 
>   commit 0d10fe759117 ("iommu/amd: Use try_cmpxchg64 in alloc_pte and free_clear_pte")
> 
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Robin Murphy <robin.murphy@arm.com>

Thanks for fixing it. Looks good to me.

Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>

-Vasant

> ---
>  drivers/iommu/amd/io_pgtable_v2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/amd/io_pgtable_v2.c b/drivers/iommu/amd/io_pgtable_v2.c
> index 78ac37c5ccc1..664e91c88748 100644
> --- a/drivers/iommu/amd/io_pgtable_v2.c
> +++ b/drivers/iommu/amd/io_pgtable_v2.c
> @@ -158,7 +158,7 @@ static u64 *v2_alloc_pte(int nid, u64 *pgd, unsigned long iova,
>  
>  			__npte = set_pgtable_attr(page);
>  			/* pte could have been changed somewhere. */
> -			if (cmpxchg64(pte, __pte, __npte) != __pte)
> +			if (!try_cmpxchg64(pte, &__pte, __npte))
>  				iommu_free_page(page);
>  			else if (IOMMU_PTE_PRESENT(__pte))
>  				*updated = true;