Received-SPF: pass (google.com: domain of linux-kernel+bounces-187396-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Feedback-ID: i787e41f1:Fastmail
Date: Thu, 23 May 2024 13:28:12 +0200
From: Greg KH <greg@kroah.com>
To: Edward Liaw <edliaw@google.com>
Cc: stable@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
	kernel-team@android.com, Mark Brown <broonie@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 6.6.y] kselftest: Add a ksft_perror() helper
Message-ID: <2024052305-unmapped-renewably-b3fc@gregkh>
References: <20240520175629.162697-1-edliaw@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240520175629.162697-1-edliaw@google.com>

On Mon, May 20, 2024 at 05:56:28PM +0000, Edward Liaw wrote:
> From: Mark Brown <broonie@kernel.org>
> 
> [ Upstream commit 907f33028871fa7c9a3db1efd467b78ef82cce20 ]
> 
> The standard library perror() function provides a convenient way to print
> an error message based on the current errno but this doesn't play nicely
> with KTAP output. Provide a helper which does an equivalent thing in a KTAP
> compatible format.
> 
> nolibc doesn't have a strerror() and adding the table of strings required
> doesn't seem like a good fit for what it's trying to do so when we're using
> that only print the errno.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> Stable-dep-of: 071af0c9e582 ("selftests: timers: Convert posix_timers test to generate KTAP output")
> Signed-off-by: Edward Liaw <edliaw@google.com>
> ---
>  tools/testing/selftests/kselftest.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 

Now queued up, thanks.

greg k-h