Received-SPF: pass (google.com: domain of linux-kernel+bounces-187397-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 23 May 2024 13:29:38 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Doug Berger <opendmb@gmail.com>
Cc: stable@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH stable 5.4 0/2] net: bcmgenet: revisit MAC reset
Message-ID: <2024052332-cinnamon-oppose-98a9@gregkh>
References: <20240516211153.140679-1-opendmb@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240516211153.140679-1-opendmb@gmail.com>

On Thu, May 16, 2024 at 02:11:51PM -0700, Doug Berger wrote:
> Commit 3a55402c9387 ("net: bcmgenet: use RGMII loopback for MAC
> reset") was intended to resolve issues with reseting the UniMAC
> core within the GENET block by providing better control over the
> clocks used by the UniMAC core. Unfortunately, it is not
> compatible with all of the supported system configurations so an
> alternative method must be applied.
> 
> This commit set provides such an alternative. The first commit
> reverts the previous change and the second commit provides the
> alternative reset sequence that addresses the concerns observed
> with the previous implementation.
> 
> This replacement implementation should be applied to the stable
> branches wherever commit 3a55402c9387 ("net: bcmgenet: use RGMII
> loopback for MAC reset") has been applied.
> 
> Unfortunately, reverting that commit may conflict with some
> restructuring changes introduced by commit 4f8d81b77e66 ("net:
> bcmgenet: Refactor register access in bcmgenet_mii_config").
> The first commit in this set has been manually edited to
> resolve the conflict on stable/linux-5.4.y.
> 
> Doug Berger (2):
>   Revert "net: bcmgenet: use RGMII loopback for MAC reset"
>   net: bcmgenet: keep MAC in reset until PHY is up
> 
>  .../net/ethernet/broadcom/genet/bcmgenet.c    | 10 ++---
>  .../ethernet/broadcom/genet/bcmgenet_wol.c    |  6 ++-
>  drivers/net/ethernet/broadcom/genet/bcmmii.c  | 39 +++----------------
>  3 files changed, 16 insertions(+), 39 deletions(-)
> 
> -- 
> 2.34.1
> 
> 

Both now queued up, thanks.

greg k-h