Received-SPF: pass (google.com: domain of linux-kernel+bounces-187398-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+57cc2f20a84cb4346354@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [serial?] possible deadlock in uart_write (2)
Date: Thu, 23 May 2024 19:30:57 +0800
Message-Id: <20240523113057.2386-1-hdanton@sina.com>
In-Reply-To: <000000000000be49b106191916f0@google.com>
References: 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Wed, 22 May 2024 23:23:26 -0700
> syzbot has found a reproducer for the following issue on:
> 
> HEAD commit:    de7e71ef8bed mm: simplify and improve print_vma_addr() out..
> git tree:       upstream
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=140480ec980000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git  de7e71ef8bed

--- x/drivers/tty/serial/serial_core.c
+++ y/drivers/tty/serial/serial_core.c
@@ -622,8 +622,9 @@ static ssize_t uart_write(struct tty_str
 		return -EL3HLT;
 
 	port = uart_port_lock(state, flags);
-	if (WARN_ON_ONCE(!state->port.xmit_buf)) {
+	if (!state->port.xmit_buf) {
 		uart_port_unlock(port, flags);
+		WARN_ON_ONCE(1);
 		return 0;
 	}
 
--