Received-SPF: pass (google.com: domain of linux-kernel+bounces-187407-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 23 May 2024 20:38:28 +0900
From: Dominique Martinet <asmadeus@codewreck.org>
To: Christian Schoenebeck <linux_oss@crudebyte.com>
Cc: Eric Van Hensbergen <ericvh@kernel.org>,
	Latchesar Ionkov <lucho@ionkov.net>, Greg Kurz <groug@kaod.org>,
	Jianyong Wu <jianyong.wu@arm.com>, stable@vger.kernel.org,
	Eric Van Hensbergen <ericvh@gmail.com>, v9fs@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 9p: add missing locking around taking dentry fid list
Message-ID: <Zk8qtPVlhiJOZxek@codewreck.org>
References: <20240521122947.1080227-1-asmadeus@codewreck.org>
 <3116644.1xDzT5uuKM@silver>
 <Zk8MAFAWIUPlhGFe@codewreck.org>
 <2675095.dNBKFZOyUv@silver>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2675095.dNBKFZOyUv@silver>

Christian Schoenebeck wrote on Thu, May 23, 2024 at 12:05:44PM +0200:
> > I really think it's safe, but I do agree that it's hard to read, happy
> > to move the `h = &dentry->d_fsdata` inside the lock if you prefer -- it
> > compiles to the same code for me (x86_64/gcc 13.2.0)
> 
> No need, you can add my RB. Thanks for the clarification!
> 
> Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>

Thanks!
I've fixed the typo in the commit message and queued it up in -next,
will send this patch and the trace uninit fix to Linus early next week.

-- 
Dominique Martinet | Asmadeus