Received-SPF: pass (google.com: domain of linux-kernel+bounces-187424-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 23 May 2024 13:57:34 +0200
From: Borislav Petkov <bp@alien8.de>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev, patches@lists.linux.dev,
	kernel test robot <lkp@intel.com>,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] x86/boot: Address clang -Wimplicit-fallthrough in
 vsprintf()
Message-ID: <20240523115734.GAZk8vLgzOzD8Tv9pq@fat_crate.local>
References: <20240516-x86-boot-fix-clang-implicit-fallthrough-v1-1-04dc320ca07c@kernel.org>
 <20240517095110.GAZkcojmJQoY_zU-OT@fat_crate.local>
 <20240517151833.GB3660288@thelio-3990X>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240517151833.GB3660288@thelio-3990X>

On Fri, May 17, 2024 at 08:18:33AM -0700, Nathan Chancellor wrote:
> There was a patch to make Clang match GCC's behavior a few years ago but
> I think Kees made a good argument that GCC's behavior leaves potential
> bugs on the table, so that was not pursued further.
> 
> https://reviews.llvm.org/D91895#2417170

Really? Maybe I'm being dense but I don't see real bugs there... I see
readability issues. :-)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette