Received-SPF: pass (google.com: domain of linux-kernel+bounces-187466-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240523113410.983875-1-shichaorai@gmail.com> <2024052351-demote-gangly-74b0@gregkh>
In-Reply-To: <2024052351-demote-gangly-74b0@gregkh>
From: shichao lai <shichaorai@gmail.com>
Date: Thu, 23 May 2024 20:23:57 +0800
Message-ID: <CACjpba7k2+GS3c+NGgOeP=9=DU8Mh1DFEGUB_WAkX_VFKBBtrA@mail.gmail.com>
Subject: Re: [PATCH v2] usb-storage: Check whether divisor is non-zero before division
To: Greg KH <gregkh@linuxfoundation.org>
Cc: oneukum@suse.com, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, 
	usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, 
	xingwei lee <xrivendell7@gmail.com>, yue sun <samsun1006219@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 23, 2024 at 7:47=E2=80=AFPM Greg KH <gregkh@linuxfoundation.org=
> wrote:
>
> On Thu, May 23, 2024 at 07:34:10PM +0800, Shichao Lai wrote:
> > Since uzonesize may be zero, so judgements for non-zero
> > are necessary in both place.
> >
> > Changes since v1:
> > - Add one more check in alauda_write_lba().
> > - Move check ahead of loop in alauda_read_data().
>
> Nit, this changes list should go below the --- line, as the
> documentation asks for.

Sorry for my inexperience. I have read the document and found some
examples but I am still a little confused about this.
I guess this is what you mean?

Since uzonesize may be zero ... (context)

Reported-by: xingwei lee <xrivendell7@gmail.com>
Reported-by: yue sun <samsun1006219@gmail.com>
Signed-off-by: Shichao Lai <shichaorai@gmail.com>
---
Changes since v1:
- Add one more check in alauda_write_lba().
- Move check ahead of loop in alauda_read_data().

 drivers/usb/storage/alauda.c | 4 ++++
 1 file changed, 4 insertions(+)
..


> Check after the list of variables please, not in the middle of them.  I
> think checkpatch will complain about this, right?

In fact this script doesn't warn about these problems, but I will
adjust my code style later.
But the check in alauda_write_lba() is due to some variable like
lba_offset and zone will perform modulo and divide operations,
which may throw divide errors when uzonesize is 0.
So I think I prefer to adjust the order of the variable list later.
Changes like this.
```c
unsigned int uzonesize =3D MEDIA_INFO(us).uzonesize;
unsigned int zonesize =3D MEDIA_INFO(us).zonesize;
unsigned int pagesize =3D MEDIA_INFO(us).pagesize;
unsigned int blocksize =3D MEDIA_INFO(us).blocksize;
unsigned int new_pba_offset;
if (!uzonesize)
    return USB_STOR_TRANSPORT_ERROR;
unsigned int lba_offset =3D lba % uzonesize;
unsigned int zone =3D lba / uzonesize;
```
If it's ok, I will post the patch v3 soon.