Received-SPF: pass (google.com: domain of linux-kernel+bounces-187472-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Pankaj Gupta <pankaj.gupta@nxp.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
CC: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>, Jonathan Corbet
	<corbet@lwn.net>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>, Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <festevam@gmail.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Conor Dooley
	<conor+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Pengutronix Kernel Team
	<kernel@pengutronix.de>
Subject: RE: [EXT] Re: [PATCH v2 2/5] dt-bindings: arm: fsl: add imx-se-fw
 binding doc
Thread-Topic: [EXT] Re: [PATCH v2 2/5] dt-bindings: arm: fsl: add imx-se-fw
 binding doc
Thread-Index: AQHarP9S3VQaTkhgFEm8Z/1nPFfSbrGkvpeAgAAA2TA=
Date: Thu, 23 May 2024 12:30:59 +0000
Message-ID:
 <AM9PR04MB86042A999B5A346B011FD97595F42@AM9PR04MB8604.eurprd04.prod.outlook.com>
References: <20240523-imx-se-if-v2-0-5a6fd189a539@nxp.com>
 <20240523-imx-se-if-v2-2-5a6fd189a539@nxp.com>
 <171646712724.2026308.5404698488082776575.robh@kernel.org>
In-Reply-To: <171646712724.2026308.5404698488082776575.robh@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?bM+STiQXbGEXbBH6uqor/nIvaeQqGvez/fxzOJFhZY5A37eZwo2PFnIZmq0b?=
 =?us-ascii?Q?aba7z9kMGIj5v97CanS/CHjCTY+6m8PPgVasG2DGuEdLJfs+1WWkgTgiiBF7?=
 =?us-ascii?Q?g5GF4RxLlHpbxfSJJcq8Gt5l6iZdxu1pqglWt25/OFB966ymsYMCQnM6FD04?=
 =?us-ascii?Q?ygXJ6n3U8ghQzKenYX11w9nviy1oNr4SCgbLm5UdRP1pjfWbZvJ18UdapgWy?=
 =?us-ascii?Q?ZXEhk5dZ3fqKNW/K7gUstrBxByN0xyZab5+jkCg4o/R8XBtlIraxUSjJAnSj?=
 =?us-ascii?Q?HYtLhuYs4fb9RlfrLiOl8S7Lk5S1yWylHxgDqxnfUo5QmyyCu57Z28CLWNxF?=
 =?us-ascii?Q?i0PdpUfGFJkYoVUGgtPk3fkSuEWRbSFOPjsy8IInfcalNgCdmSuMD4SZpNZ5?=
 =?us-ascii?Q?/LDjGjmHDFexSGUasTZXkBYYwJa8F0DKVSJYHMMMpu3fUN72QgmabdOOloPr?=
 =?us-ascii?Q?utJTxO37yFgiF3W2/V9wmOWPN3fV18wa6XGfqdOByfoYdTT/8ybhOGjlujbA?=
 =?us-ascii?Q?/6ONnj8TKMH4wcQk6M4OctF1eACZuDTePHFjLkmZkWtvRzi3PM5HAIz0yvhv?=
 =?us-ascii?Q?OQucFVMCOnHTG7aDXaT+q2CaRoFfwVTEnNC0OUaJHvBpmX2NwfuzF3xlVreD?=
 =?us-ascii?Q?FUqRyx3iQiSrCPIo8fdYr2BuAHv4Y6YgohPwmbtxP4xIbrJGlEPb4bGRJJjS?=
 =?us-ascii?Q?EM1Q9Hdt/ZeNFyUsAOvU/UlKT79TvacxrN1L1epCET6DPYoDTHMDnvmFSai8?=
 =?us-ascii?Q?pw9jEkNRujx+AFGX/0MRPG2aSAllYtGdCfTKGG8sp0Uy7U0A/RAz4qQSRJLA?=
 =?us-ascii?Q?qvh5Ohy37cmc6Tvdi9IbJBxA1JCW6k7N4NRYdIZD0QnDVAvCDtJhPhCWlVQv?=
 =?us-ascii?Q?JawuBm+suF3cdepzfVrviX8RIucm1Iwqau3s0w9d7oT2luANrkqidGcJqTCQ?=
 =?us-ascii?Q?k1ec2GHIve0OhVtHX8hdjxxhiLr1Zdf66I7eQVUEDy7KIPdNEm9o2OnvgaRo?=
 =?us-ascii?Q?AXxm34yRirvlwGWwTfA09ddcnFIemNxSOZiasQocpQfQUyDvXSIwVF9C4FK6?=
 =?us-ascii?Q?KeRNODYS6NleveLPHzBSiFqwmcrOqkdnHXY4zHDZfoGIJR8PxOlBFqRxg4P7?=
 =?us-ascii?Q?ORj9zdOUhDLxCHNEH3bzCcOdgpcF+m308Iv8vwVMhi6NGOmDdsIrtX3Zroz5?=
 =?us-ascii?Q?n12oyeYHV5c4KFeW6e3OMHqJT+gdqs7GaU4uGuTihhLhFSUzIiPGcz2y/HP8?=
 =?us-ascii?Q?PYvc1UacFpgrLyu/Nzj0SBB75wAIyWWBO5ReoRvKxhZX4aybBghes6m0Mbx4?=
 =?us-ascii?Q?yU5O15Cleaca0a+GOrVbZptwvU1IjKE6Qn1gQhfAXNLEv5h1zQiC1GbVDwL1?=
 =?us-ascii?Q?wgNSCaub/dJGmZkTUGnmO/x/rBRT1uzcNX7TOby1+m/8fytoapuMwuc6llPk?=
 =?us-ascii?Q?1iudA1QBPkjpLNwA29vOjXkzcTCa2oIDRZ71XdaDEPG4aGmcqavY+lvKx2jE?=
 =?us-ascii?Q?Ltb/raWxRZt/tk72Cu7tt54IN87w7+kpk8I/19+VR/s/j4k3cBqvscFku+xC?=
 =?us-ascii?Q?6QDQ8yiwt3vgRD7UsgZpN/CNPBFO0bM7NqYcGR3e?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8604.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6faff1aa-b2c6-4540-12ee-08dc7b243364
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2024 12:30:59.0475
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E7neWHGEzMM1VQnBlAZAenXdJjWoDR0himAGBscsnBUPnIaDZ3dfPT+WA8hn1ioU3SH5Kz5UmfMr6P8LhEOc9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB11069


> -----Original Message-----
> From: Rob Herring (Arm) <robh@kernel.org>
> Sent: Thursday, May 23, 2024 5:55 PM
> To: Pankaj Gupta <pankaj.gupta@nxp.com>
> Cc: linux-doc@vger.kernel.org; Jonathan Corbet <corbet@lwn.net>; Krzyszto=
f
> Kozlowski <krzk+dt@kernel.org>; imx@lists.linux.dev; Shawn Guo
> <shawnguo@kernel.org>; Fabio Estevam <festevam@gmail.com>; linux-
> kernel@vger.kernel.org; Sascha Hauer <s.hauer@pengutronix.de>; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; Rob Herring
> <robh+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Pengutronix Kernel Team
> <kernel@pengutronix.de>
> Subject: [EXT] Re: [PATCH v2 2/5] dt-bindings: arm: fsl: add imx-se-fw bi=
nding
> doc
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>=20
>=20
> On Thu, 23 May 2024 16:19:33 +0530, Pankaj Gupta wrote:
> > The NXP security hardware IP(s) like: i.MX EdgeLock Enclave, V2X etc.,
> > creates an embedded secure enclave within the SoC boundary to enable
> > features like:
> > - HSM
> > - SHE
> > - V2X
> >
> > Secure-Enclave(s) communication interface are typically via message
> > unit, i.e., based on mailbox linux kernel driver. This driver enables
> > communication ensuring well defined message sequence protocol between
> > Application Core and enclave's firmware.
> >
> > Driver configures multiple misc-device on the MU, for multiple
> > user-space applications, to be able to communicate over single MU.
> >
> > It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
> >
> > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> > ---
> >  .../devicetree/bindings/firmware/fsl,imx-se.yaml   | 154
> +++++++++++++++++++++
> >  1 file changed, 154 insertions(+)
> >
>=20
> My bot found errors running 'make dt_binding_check' on your patch:
>=20
> yamllint warnings/errors:
>=20
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/firmware/fsl,imx-se.example.dtb:
> /example-2/firmware/v2x-if@0: failed to match any schema with compatible:
> ['fsl,imx95-v2x']
> Documentation/devicetree/bindings/firmware/fsl,imx-se.example.dtb:
> /example-2/firmware/v2x-if@1: failed to match any schema with compatible:
> ['fsl,imx95-v2x']
> Documentation/devicetree/bindings/firmware/fsl,imx-se.example.dtb:
> /example-2/firmware/v2x-if@2: failed to match any schema with compatible:
> ['fsl,imx95-v2x']
>=20
> doc reference errors (make refcheckdocs):
>=20
> See
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpatch=
w
> ork.ozlabs.org%2Fproject%2Fdevicetree-bindings%2Fpatch%2F20240523-
> imx-se-if-v2-2-
> 5a6fd189a539%40nxp.com&data=3D05%7C02%7Cpankaj.gupta%40nxp.com%7
> C102225d4215b49f9e1e308dc7b2370cd%7C686ea1d3bc2b4c6fa92cd99c5c3
> 01635%7C0%7C0%7C638520639343681926%7CUnknown%7CTWFpbGZsb3d
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%
> 3D%7C0%7C%7C%7C&sdata=3DBO%2FhtixA%2ByKfjN2UZdas2VzEj9Aoq1I%2F%
> 2FH7m5pLAqPc%3D&reserved=3D0
>=20
> The base for the series is generally the latest rc1. A different dependen=
cy
> should be noted in *this* patch.
>=20
> If you already ran 'make dt_binding_check' and didn't see the above error=
(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
>=20
> pip3 install dtschema --upgrade

I have updated this. But still not able to see the above error.

But, I know why it coming. Following change will fix it.

In the compatible properties:
+  compatible:
+    enum:
+      - fsl,imx8ulp-ele
+      - fsl,imx93-ele
-      - fsl,imx95-ele
+      - fsl,imx95-v2x


Will correct in v3.
>=20
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your
> schema.