Received-SPF: pass (google.com: domain of linux-kernel+bounces-187534-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 23 May 2024 15:01:55 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Xiaolei Wang <xiaolei.wang@windriver.com>
Cc: wei.fang@nxp.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, imx@lists.linux.dev, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH] net: fec: free fec queue when fec_probe() fails or
 fec_drv_remove()
Message-ID: <ca1c4de5-537a-4aa9-851d-d37ce800fdac@lunn.ch>
References: <20240523062920.2472432-1-xiaolei.wang@windriver.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240523062920.2472432-1-xiaolei.wang@windriver.com>

On Thu, May 23, 2024 at 02:29:20PM +0800, Xiaolei Wang wrote:
> commit 59d0f7465644 ("net: fec: init multi queue date structure")
> allocates multiple queues, which should be cleaned up when fec_probe()
> fails or fec_drv_remove(), otherwise a memory leak will occur.
> 
> unreferenced object 0xffffff8010350000 (size 8192):
>   comm "kworker/u8:3", pid 39, jiffies 4294893562
>   hex dump (first 32 bytes):
>     02 00 00 00 00 00 00 00 00 50 06 8a c0 ff ff ff  .........P......
>     e0 6f 06 8a c0 ff ff ff 00 50 06 8a c0 ff ff ff  .o.......P......
>   backtrace (crc f1b8b79f):
>     [<0000000057d2c6ae>] kmemleak_alloc+0x34/0x40
>     [<000000003c413e60>] kmalloc_trace+0x2f8/0x460
>     [<00000000663f64e6>] fec_probe+0x1364/0x3a04
>     [<0000000024d7e427>] platform_probe+0xc4/0x198
>     [<00000000293aa124>] really_probe+0x17c/0x4f0
>     [<00000000dfd1e0f3>] __driver_probe_device+0x158/0x2c4
> 
> Fixes: 59d0f7465644 ("net: fec: init multi queue date structure")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>

Please read what i suggested. It is good to have code which is
symmetric. probe() and remove() should be opposites of each other.
probe() calls fec_enet_init(). So it would be good to have remove()
call fec_enet_deinit() which does the opposite. We then have symmetry.

Is there anything else in fec_enet_init() which needs undoing? A rule
of thumb: If you find a bug, look around, there might be others
nearby. Maybe leaking the queues is not the only problem?

	Andrew