Received-SPF: pass (google.com: domain of linux-kernel+bounces-187577-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 23 May 2024 15:31:03 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nikolay Borisov <nik.borisov@suse.com>
Cc: cve@kernel.org, linux-kernel@vger.kernel.org,
	linux-cve-announce@vger.kernel.org
Subject: Re: CVE-2021-47326: x86/signal: Detect and prevent an alternate
 signal stack overflow
Message-ID: <2024052322-outage-grit-a4fe@gregkh>
References: <2024052133-CVE-2021-47326-fd53@gregkh>
 <06570587-dc49-4885-83da-7a386f012106@suse.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <06570587-dc49-4885-83da-7a386f012106@suse.com>

On Thu, May 23, 2024 at 01:19:17PM +0300, Nikolay Borisov wrote:
> 
> 
> On 21.05.24 г. 17:36 ч., Greg Kroah-Hartman wrote:
> > Description
> > ===========
> > 
> > In the Linux kernel, the following vulnerability has been resolved:
> > 
> > x86/signal: Detect and prevent an alternate signal stack overflow
> > 
> > The kernel pushes context on to the userspace stack to prepare for the
> > user's signal handler. When the user has supplied an alternate signal
> > stack, via sigaltstack(2), it is easy for the kernel to verify that the
> > stack size is sufficient for the current hardware context.
> > 
> > Check if writing the hardware context to the alternate stack will exceed
> > it's size. If yes, then instead of corrupting user-data and proceeding with
> > the original signal handler, an immediate SIGSEGV signal is delivered.
> > 
> > Refactor the stack pointer check code from on_sig_stack() and use the new
> > helper.
> > 
> > While the kernel allows new source code to discover and use a sufficient
> > alternate signal stack size, this check is still necessary to protect
> > binaries with insufficient alternate signal stack size from data
> > corruption.
> > 
> > The Linux kernel CVE team has assigned CVE-2021-47326 to this issue.
> 
> 
> I'd like to dispute this CVE. Basically a process can pass in a
> wrongly-sized stack which will cause its own stack to be corrupted. If
> anything this affects the process rather than the kernel.

Ah, good catch, thanks, I'll go revoke this CVE now.

Thanks for the review, much appreciated!

greg k-h