Received-SPF: pass (google.com: domain of linux-kernel+bounces-187593-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Pankaj Gupta <pankaj.gupta@nxp.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
CC: Jonathan Corbet <corbet@lwn.net>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
	<conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Pengutronix Kernel
 Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, Rob Herring
	<robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v2 4/5] firmware: imx: add driver for NXP
 EdgeLock Enclave
Thread-Topic: [EXT] Re: [PATCH v2 4/5] firmware: imx: add driver for NXP
 EdgeLock Enclave
Thread-Index: AQHarP9ayLdOqCtfLEqTQR0Rf+AVuLGkztWAgAADNvA=
Date: Thu, 23 May 2024 13:43:46 +0000
Message-ID:
 <AM9PR04MB86047218A243EEB5BA79F69D95F42@AM9PR04MB8604.eurprd04.prod.outlook.com>
References: <20240523-imx-se-if-v2-0-5a6fd189a539@nxp.com>
 <20240523-imx-se-if-v2-4-5a6fd189a539@nxp.com>
 <Zk9DV6Ko-KO0kym_@pengutronix.de>
In-Reply-To: <Zk9DV6Ko-KO0kym_@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?dCs3iXFZJZR/xWHIhE1AvsfU7nw4zD0j0pJ5oKXcAIuP94203rOyuZleoMYk?=
 =?us-ascii?Q?wte5uJnj6ER/amPueiQiKAmj+g2PegQuiWYk5/MXTYrphK9OLtCPjZGRhpIi?=
 =?us-ascii?Q?8KNhiRsy8xlIHYP5fz0Y/gQFiiwyiFODA+MuGuADjKe+g2+tWIcb3pLT+obt?=
 =?us-ascii?Q?RM5lRZmoGzksQR8jPfuXhjWJPq7KJaxUshVCn6cfN/rjCfVJffnC7mVwIiNg?=
 =?us-ascii?Q?WxuMDbQUc3frkjNPcuZyi8WYA6h6pUEyfSJHhiBXM5vB8iAmuwGXqDdrLTu5?=
 =?us-ascii?Q?T5s/2EnHbV6rxQhsgvHDkOjhqAo+R44/FBIW1bFs4B5eUtcXnYw5DRAe/Ll7?=
 =?us-ascii?Q?ItYC5VrAZ5iryO6xxvizFJESnr1SWto8l30EpRjwJn50L6Lt+fKn6NeayMSU?=
 =?us-ascii?Q?c/pXMbnpvNhCpBCbkDY1cxHaHqDeBnRHTmLeHppoI7x52om7rifx4WF55iWB?=
 =?us-ascii?Q?pGlblWcezkpewakLzZRnpYv0gq7N10zb9W3JCfBrF9tbyqlOy3de/TnZ7JI4?=
 =?us-ascii?Q?Ve/pDz2kHnVVQRmIELN0kqjBwoAYWRP4H7pJEWozkdzQrNL0sl3HE+7U1Bzk?=
 =?us-ascii?Q?dL2s/poR3Zpr8iu4+l/puIl/G89h5P8i8DyEvoQfobW7caTYU8e8b28XImXf?=
 =?us-ascii?Q?xyuf5jpOUThJHDTsvjxKHxwqQ0LxdDSlMxT1eZgAd6wFCR0bM9GHkJcGFSvQ?=
 =?us-ascii?Q?7rEFe3PcavCRS1OCPo0WH9WC6NEbKMXvSZuA3eLieew3ILMhmTIWDvm8vryn?=
 =?us-ascii?Q?9851AdLT33t+w5UsLIqov/c9tXrNNqDOz6TTQ47LYbifJPUN+/hGT+d5vXLm?=
 =?us-ascii?Q?CFMuZW6wEZzLcopuv32o0M1wVfi/dgajMaQ0z4G8DYNGLDXrR4KZAlxa8BrY?=
 =?us-ascii?Q?JLofBu8SwAkVBbDYQmPU3mpums3Kv7Sj8VWFvMDkp0O1l3jkmme1fX9DKTJq?=
 =?us-ascii?Q?z1ZcSraPaF2HuhP1QnMx2k0hOuoSB7YgSrIeSdzFy1ibo6nuL2qjbCSC6Llk?=
 =?us-ascii?Q?O1fgFZgBK8YObRaw0EvVj0dX3F0i079ga9FQwvOvIRLcfvoRB7YpvZ3MWQsW?=
 =?us-ascii?Q?pOzQo2+9mcqh3iaR8tlVQkC18YhkxjfIvl9k5acY8EPXdHMf9Ck0aN6KTl8X?=
 =?us-ascii?Q?IhNUU6J8y17rGBzodXiHsUL6tHAVaGRF0h3hRIAjyh7Vs3vGUKDFFKsLe/xZ?=
 =?us-ascii?Q?RcfKo6T7p5kbbNLaIcuQ92riUOAw3PGYztUhsLUJFLGWyjY/2nRBemLZAnLI?=
 =?us-ascii?Q?Ah+SRYOnGqIw7o8hlmXqPRuLcAhtXbPra5sh1X7MktUNNchgNpaknRpcbtUK?=
 =?us-ascii?Q?Sc780Pr5uvFGLlClEoENt3Do7/lWRusfqWK0AvgOYLO/b2WViZbJgjPdbp5w?=
 =?us-ascii?Q?lhmHDISm6xz6MdLLovt3znvrvSl3SeKkg9lPf3WB/artzCAgkiRKJZV+5sC3?=
 =?us-ascii?Q?jFFuxN9j2fMZSCgMBJh+FT03lJfXyt+kCdMn0mH3Ywx+hS+WOO+1Dc/pVrvV?=
 =?us-ascii?Q?JilVabASqEBWQ1Of/wVYApsRPv0rxJ/1qfYk1Wf8+Z/LVIfHtbBbj2DCH1cj?=
 =?us-ascii?Q?Ju9uMFPmaxx7TXYMqljnvoU7uXGejmxFGrVPGLvI?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8604.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11782e91-b808-4947-896a-08dc7b2e5e57
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2024 13:43:46.1004
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7yWGzJfBqsj7tEEEypXpWCVPeIsiNu7HVIRwfGtw1m3FOOMg5e2NTsudSljEQ0c4HKfBepAz7h+AREyfdbUMNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8884


> -----Original Message-----
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Thursday, May 23, 2024 6:54 PM
> To: Pankaj Gupta <pankaj.gupta@nxp.com>
> Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh+dt@kernel.org>;
> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Pengutronix
> Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> <festevam@gmail.com>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; linux-doc@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; imx@lists.linux.dev;
> linux-arm-kernel@lists.infradead.org
> Subject: [EXT] Re: [PATCH v2 4/5] firmware: imx: add driver for NXP EdgeL=
ock
> Enclave
>
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Thu, May 23, 2024 at 04:19:35PM +0530, Pankaj Gupta wrote:
> > NXP hardware IP(s) for secure-enclaves like Edgelock Enclave(ELE), are
> > embedded in the SoC to support the features like HSM, SHE & V2X, using
> > message based communication interface.
> >
> > The secure enclave FW communicates on a dedicated messaging unit(MU)
> > based interface(s) with application core, where kernel is running.
> > It exists on specific i.MX processors. e.g. i.MX8ULP, i.MX93.
> >
> > This patch adds the driver for communication interface to
> > secure-enclave, for exchanging messages with NXP secure enclave HW
> > IP(s) like EdgeLock Enclave (ELE) from Kernel-space, used by kernel
> > management layers like
> > - DM-Crypt.
> >
> > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> > ---
> >  drivers/firmware/imx/Kconfig        |  12 +
> >  drivers/firmware/imx/Makefile       |   2 +
> >  drivers/firmware/imx/ele_base_msg.c | 286 +++++++++++++++++++
> > drivers/firmware/imx/ele_base_msg.h |  92 +++++++
> >  drivers/firmware/imx/ele_common.c   | 239 ++++++++++++++++
> >  drivers/firmware/imx/ele_common.h   |  43 +++
> >  drivers/firmware/imx/se_ctrl.c      | 531
> ++++++++++++++++++++++++++++++++++++
> >  drivers/firmware/imx/se_ctrl.h      |  99 +++++++
> >  include/linux/firmware/imx/se_api.h |  14 +
> >  9 files changed, 1318 insertions(+)
>
> [...]
>
> >
> > +int imx_ele_msg_send(struct se_if_priv *priv, void *tx_msg) {
> > +     struct se_msg_hdr *header;
> > +     int err;
> > +
> > +     header =3D (struct se_msg_hdr *) tx_msg;
> > +
> > +     if (header->tag =3D=3D priv->cmd_tag)
> > +             lockdep_assert_held(&priv->se_if_cmd_lock);
> > +
> > +     scoped_guard(mutex, &priv->se_if_lock);
>
> scoped_guard() with an empty block doesn't make much sense. Either use
> scope_guard() { /* do something locked */ }; or guard().
>
Need to allow send more than one message at a time. Hence, done it after ta=
king the lock.
Once message sent, scope of lock is over.
Thus, scope of the lock se_if_lock, to execute the function "mbox_send_mess=
age()", keeping the "se_if_lock" locked.

> Sascha
>
> --
> Pengutronix e.K.                           |                             =
|
> Steuerwalder Str. 21                       |
> http://www.pe/
> ngutronix.de%2F&data=3D05%7C02%7Cpankaj.gupta%40nxp.com%7Cbf79ff917
> 442406e454308dc7b2b8ef2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
> %7C0%7C638520674210595147%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM
> C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7
> C%7C%7C&sdata=3DUUYK6KTYzgxY5kO4McFy0%2FGrXxTrf2MG5g4cvJ6E4Qk%
> 3D&reserved=3D0  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    =
|
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 =
|