Received-SPF: pass (google.com: domain of linux-kernel+bounces-187597-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 23 May 2024 15:51:38 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: zhengzucheng <zhengzucheng@huawei.com>
Cc: Michal Hocko <mhocko@suse.com>, linux-cve-announce@vger.kernel.org,
	Lee Jones <lee@kernel.org>, Jun.Ma2@amd.com, cve@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: CVE-2024-26650: platform/x86: p2sb: Allow p2sb_bar() calls
 during PCI device probe
Message-ID: <2024052316-subtotal-fragrance-15e3@gregkh>
References: <20240326175007.1388794-18-lee@kernel.org>
 <Zkz2qpUP-HVROO1I@tiehlicka>
 <da7e8c85-52fd-b2f4-83da-751f812de6ae@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <da7e8c85-52fd-b2f4-83da-751f812de6ae@huawei.com>

On Thu, May 23, 2024 at 04:50:18PM +0800, zhengzucheng wrote:
> 
> 在 2024/5/22 3:31, Michal Hocko 写道:
> > This patch has been reverted in upstream by 03c6284df179 ("Revert
> > "drm/amd/amdgpu: Fix potential ioremap() memory leaks in
> > amdgpu_device_init()"") and based on the changelog the CVE should be
> > rejected.
> 
> hi Michal Hocko
> 
> This reverted patch was previously used to resolve CVE-2024-35928 ?
> 
> so CVE-2024-35928 should be rejected?
> 
> 
> commit 03c6284df179de3a4a6e0684764b1c71d2a405e2
> Author: Ma Jun <Jun.Ma2@amd.com>
> Date:   Tue Mar 19 15:24:03 2024 +0800
> 
>     Revert "drm/amd/amdgpu: Fix potential ioremap() memory leaks in
> amdgpu_device_init()"
> 
>     This patch causes the following iounmap erorr and calltrace
>     iounmap: bad address 00000000d0b3631f
> 
>     The original patch was unjustified because amdgpu_device_fini_sw() will
>     always cleanup the rmmio mapping.
> 
>     This reverts commit eb4f139888f636614dab3bcce97ff61cefc4b3a7.
> 
>     Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
>     Suggested-by: Christian König <christian.koenig@amd.com>
>     Reviewed-by: Christian König <christian.koenig@amd.com>
>     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Yes, this should be rejected, I'll go do that now, thanks for pointing
out the revert, we missed that.

greg k-h