Received-SPF: pass (google.com: domain of linux-kernel+bounces-187618-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <39ca29dd-f072-43af-96ab-0fbe24bdda61@amd.com>
Date: Thu, 23 May 2024 10:02:59 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] drm/amd/display: Enable colorspace property for MST
 connectors
To: Mario Limonciello <mario.limonciello@amd.com>,
 dri-devel@lists.freedesktop.org,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
 Aurabindo Pillai <aurabindo.pillai@amd.com>,
 Daniel Wheeler <daniel.wheeler@amd.com>, Fangzhi Zuo <jerry.zuo@amd.com>,
 =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
 Tyler Schneider <tyler.schneider@amd.com>
References: <20240508214535.356-1-mario.limonciello@amd.com>
Content-Language: en-US
From: Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20240508214535.356-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Um0wUW1QaWZMcm03ekZxSmVGeFBONE1zUWNkU3NlY1FrOTAzSmZqOFlLRlR1?=
 =?utf-8?B?RnhSMmFualJOVk0wclN5WmJvTWJCQjZJQmovV2J5MmFuNWRsSSt5dC9jRDhj?=
 =?utf-8?B?SGdqL3NRdUZaVDBlaXZucjlyamN0RjJzT2k4NlFJV09GdnBKUlRBVi9FOS9a?=
 =?utf-8?B?dHYyMFhrOVovcEg1UjRVeXZFaFEyTWtIeVdURXJZN1dIUFByWS9MRWNtbXR4?=
 =?utf-8?B?WXBsaG53SGtMQzJkcG1pNGFrRHN4MkN3UkEyd1l5dFNyUE1rZ0hta3FRL2V0?=
 =?utf-8?B?dWRDN3ZWSkdZZGtvNkozb3cyeXRCcFY5QlFKaHI4U3pwUXFiOWtSc29rQkpP?=
 =?utf-8?B?Z0UwSW1ncE90cnJud0RaMU5iSFVuRjRiTUJjMFhkUVNmeC9namRydjlOM09Y?=
 =?utf-8?B?djB0RnZ2N0JaK1dHbGZ1Mzh4djBCY3JNTzhCdWtiT1d1cU5QRWhxK2JsRWc3?=
 =?utf-8?B?bDFsTCswUlR3aytqWkhIYVE4YXpLNVZkcWpLaUVNMGo0bEVUb2VvdWhFRHVC?=
 =?utf-8?B?L1FwZFdLUis5T2hLaEVVeW90SzNqTWJ5VHpjK0JMYncydkZNWkhqVWhsSFVj?=
 =?utf-8?B?TndmdWtuZksvUDlQc0kvZFlUUnJhSUlHOU52TFZ5a0pjQngzbml0M1lpWUJJ?=
 =?utf-8?B?RlU0WEJxcXpqOHN0d2ZuUkZmRmI4TlFlUmNubzE4bXNQcGpidEpIZXFNLzRp?=
 =?utf-8?B?Mnh0VDN6Y2VYcWtrSC9VTmV5cGloVVFOdTRLNE9YQ0ZiZ1gyeE9zYjlHUE1Y?=
 =?utf-8?B?NjhRdjk3WVIwTTVLdHZsRWpVaEw1ejliUkpHNFFuSFA1OGluN250aytMbk5U?=
 =?utf-8?B?NGoxam16UHlmbGJzYmtWeVFQMXpoWGlSNStFdjliSGtqUmF1YS9VNlFQSDFm?=
 =?utf-8?B?S2VjTkFuU0V4ZTR0aEJYc1RQbUtFeDBlbzBmYUhQSWRObk5uVis4cVN6WEJL?=
 =?utf-8?B?WUpRZjBPWDV2ZXpseXdCeUwyQUJLYzVXWlRyMng1NTVneUFQbXVBNnJwWU9P?=
 =?utf-8?B?T1ExRnZJRVpraExmcDBpd2VCUkFrODVFaHFlUXNZcFBXSjVwYWhmTXlNd3Rv?=
 =?utf-8?B?OXBXOVJvT0xCdUl3WGxTU0VjMVpFM3N6ZWs2K1lteVV4VHQ5bXFFL3RScWhI?=
 =?utf-8?B?N0JHVEhFeVFZUUh0LzI4Qk1pVERlWERRR0lBK1FtZ3IwRFhYeEVYYlVwM3hH?=
 =?utf-8?B?eUk2Smw5eVhqU1NDSzVhenZ3SkNZdkc2MUtNbG1WaUpSbXhCaENuWU9yTDRw?=
 =?utf-8?B?cDduM1ZRRFhHdUtMMVA1WTFwNmxNaSt5cnhuNjcxVHJvN09IRnA4MjNCTTUr?=
 =?utf-8?B?d3VLQktDYm5SK0FHbDJLN2FLSkNkeWRBN0l6b1ZWWlFYZmZVQ2IzaTRSWnd0?=
 =?utf-8?B?YTI4bDRYWE5DS1NlekpaNDAxMnV4RG9qbU0wSkhIZnoyYm1kaGYyMGhBRGEz?=
 =?utf-8?B?b01aR2xsK0piMGRTZVUrL0FwZGd4ejFERG5tQkRtek9BL3VxMUpBQTZXTnVN?=
 =?utf-8?B?VFhkSFNVNUdjS1JkY2M3aTBFemFUdVEzWGlNRGhVNUJldTh3SUJzeWZMTjRz?=
 =?utf-8?B?MU1FR2RUWlNWQUFrOGw4ZE4weXlCdlgrRVAxL3NVOEo5TmZWOUFwNmhGSlJ4?=
 =?utf-8?B?akd2ODBPVFdYTFFnMG1OMU13enJqS1E0bytQdEIwOUt6ZVZDOU82UE1YcmE5?=
 =?utf-8?B?eVFQaEp2NVhCUkVrL1lvQjVZMFU3TmJTS0ZuL2hGd2NKcmM1OVd5a1ZSN1U1?=
 =?utf-8?B?NjRHRGg3QWNsNWdVZDVKaVo4SG5VTnl3Wm56dXdSMnB0aElCUnB0anQvSWhD?=
 =?utf-8?B?aDBES0ZzMUpRUk12blFTcVNoRDl6c3duRldKdm0rSktIZDJSazhtcDdsVFRl?=
 =?utf-8?B?RGt1ZXdQdGg0UGwvVFhsdysvU2UyQWZJRWNib3NsSVpNMEZCTEtvZXUwVkpy?=
 =?utf-8?B?QzYrWEFxOGw5eWE2L0hlTjFrVnM3bGZWdDFPNndORDdUSlFHdGYwNFVLNE9m?=
 =?utf-8?B?L3pLZjR3NU5kci9GYVY4Q0FMRzBCQ2N0NFN6M0FId3YrUWpvUGw4bWFoaGpn?=
 =?utf-8?B?VE5aVGFlYnZOR0hqN1d3MFRzK25BM2s5aXovMDF1eldtZDlRdmFZanBKTExE?=
 =?utf-8?Q?l5OJXbDPYb7tJinz2AzG4D2Wf?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8f40ff5-b7b0-4899-605a-08dc7b310fbd
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 14:03:02.9330
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4HyOs1d/Rg/5U1QLvLxxKxp93fQhhK+EWO1/+nzJ7mvkWTKMsYtpu2kgbXchTl/J+O2MzrFjGH1JCRKAEMTvxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7142

On 2024-05-08 17:45, Mario Limonciello wrote:
> MST colorspace property support was disabled due to a series of warnings
> that came up when the device was plugged in since the properties weren't
> made at device creation. Create the properties in advance instead.
> 
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Fixes: 69a959610229 ("drm/amd/display: Temporary Disable MST DP Colorspace Property").
> Reported-and-tested-by: Tyler Schneider <tyler.schneider@amd.com>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3353
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 941e96f100f4..12b036d511d0 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -613,6 +613,9 @@ dm_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
>   		&connector->base,
>   		dev->mode_config.tile_property,
>   		0);
> +	connector->colorspace_property = master->base.colorspace_property;
> +	if (connector->colorspace_property)
> +		drm_connector_attach_colorspace_property(connector);
>   
>   	drm_connector_set_path_property(connector, pathprop);
>