Received-SPF: pass (google.com: domain of linux-kernel+bounces-187660-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <536b0f03-db96-49a3-93de-d9ea835e8785@talpey.com>
Date: Thu, 23 May 2024 10:41:42 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH] cifs: Fix credit handling in cifs_io_subrequest
 cleanup
To: David Howells <dhowells@redhat.com>, Steve French <sfrench@samba.org>,
 Paulo Alcantara <pc@manguebit.com>
Cc: Shyam Prasad N <nspmangalore@gmail.com>,
 Rohith Surabattula <rohiths.msft@gmail.com>, Jeff Layton
 <jlayton@kernel.org>, linux-cifs@vger.kernel.org, netfs@lists.linux.dev,
 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <469451.1716418742@warthog.procyon.org.uk>
Content-Language: en-US
From: Tom Talpey <tom@talpey.com>
In-Reply-To: <469451.1716418742@warthog.procyon.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WmZlSVh2aTJWNCsybzVhb1BVY0kwYllqWDZZV2lHblNKN0ZzUCsrZVdvZ2NT?=
 =?utf-8?B?RzlQS0YxQlFoVUhaZndDWUJGQzNsZlFtYTkvSENtbjl4WE93OHkzT2FJSDMy?=
 =?utf-8?B?cGdkR25GV2crWi9uUlNpNkhlRk9kdHZDejVvTFVEUGx4cUI1Yno2N1FwS0lV?=
 =?utf-8?B?MkgraDNJS2tRQmljWCtXZFYzU0xZM3BkSjVTc3gvaG94VzVjVjFUWFdidEtv?=
 =?utf-8?B?K25UWXBuVEJhOTFxMjRPajVJdHhWWFEwV0pGV1R5Y0k3cS9paTl1cUxINXox?=
 =?utf-8?B?WlZCSkRTSzA1VHMwbTlHZ2h1NWg1UkdCTGdnNjZHN3hwK0dET1RPL0xzeTAv?=
 =?utf-8?B?RURRSEUybWNDZVlEVHh0MThRNjhEZmgvRmxpaXpVdXZXdUo1NlB6Rlp0ZmI5?=
 =?utf-8?B?dnZWWGd1SlVISlBTMklhQ2hYWnlDVm9DVWtWOXVDcFZyQ3FyUVhGTU1BdHk5?=
 =?utf-8?B?aTJHWXBNRWxpRW1vZTR1U09BSXZLY3FZNFFHM3ZwVWtINjROWGZ1TEk5NHFZ?=
 =?utf-8?B?S0ZPREx2UzNrblFjVVVVRGI1SHNldG5qd0lIcHIxYU5jamRaR2NCZUVQeWJx?=
 =?utf-8?B?b245Qnlpc1pUVHYzWSsweHFlbzMyeVltaSszZTVCYjd3ZFlxNGdCdmNoTU5P?=
 =?utf-8?B?djM5SWNLV3dEYk1Jejd2SktxVThXZ2xyMktkK01WQktkeU82bDh3MkhXRVNh?=
 =?utf-8?B?cFBycVJhVExDbnZtME1PQTFjT1d3QmZRRjJ0R2ZuYWJCVklFS1Vyc2J3VVNv?=
 =?utf-8?B?RU9Xa1pDcGVGK2pIRnEzTjJKTFhSMWV1VmY1cHFGUXhLbUl0R3V1dVlOZUg4?=
 =?utf-8?B?Qms3bDJpdUVLeDJNWncyY0JwQWtIZlRxOFBhUWt0TkdVMGVpT3ltVVFHdDAr?=
 =?utf-8?B?TVQ2aWZqNWhHSktEZzBQVEtXenRHUjBiRDN3L1JYQmhENWVmWjZqeTV2Tmp5?=
 =?utf-8?B?SHJLTmlmQXM3K240a3VWOWUxQ0hSTzFPbTBMWHJYTXU4dWNsTnp0R2F4czBF?=
 =?utf-8?B?MCtEWmgrRGdVbStUTTRDZUsrclJzOFQySTJSRUtadU5Kd0pjRmJHNTBheVRH?=
 =?utf-8?B?MzIzZWVtUlo1RmpwcnRHZVFnZEw4ZzBoMzR4Q01Ed1RGQ2ozYVd5bjNGenZE?=
 =?utf-8?B?d1BYK2JjYmpTQ0tJd0FXSFJVU0tsUkpkVE5FcDdPdWt1Y2doRHE3R2lMc1h4?=
 =?utf-8?B?c21xSExLM2p3N24yaXkxU0c4WFFIZWIzd1phaUtBemR2eXdYajl2bk5na1k5?=
 =?utf-8?B?d3k1UXN5T01yZDJDQk42YkF1M1NSajVJZ29vNHA5WEVvVlZxSzc1eStmQkJH?=
 =?utf-8?B?TzRWSW5mb1B4dkpScFU3NHp4by83VThSMlN4Smg5Q2ZhV0xja1MyV1JSZGUw?=
 =?utf-8?B?L29pUXNOS292VDhzYXd2N1REcUkyZXkwQTUrc0RhZUYvakQ2K2pXMmJxWG1H?=
 =?utf-8?B?QzdhNU1YVW9DazJOakNtRFJGazBDLzdsVmFSQ0JuQ2ttTndOcWgrVUlyNU1p?=
 =?utf-8?B?Rll3bUUzQlRxNjFIcmRBU2U0Zk8ySTc3aU5lb01paFMvcUQxb3MxQ2R0N3Jx?=
 =?utf-8?B?WkkrVkFMSWRud21QMU41ekFXSUgzdXJpQkhvcnhjYjZNaEdxWXRmd1dpV0px?=
 =?utf-8?B?Vkw0NVVYSDVuaXdKMXBxeTFocW5uZVZUY3pEbGc5aXc3UlFVWnFqOFlIOWtF?=
 =?utf-8?B?bHJ1Q1B6SklmR1dGQ3RMZkxqWnJ4NlFnR1hNdXlpRUZCV205SmFZSDl2cCto?=
 =?utf-8?B?U1QxZ0FmdzBlVklGWStvM1pWMkp6UXBJUTlITGVicHp3ZFdCRWM5ckN2RGty?=
 =?utf-8?B?cmkwNWJlREJCelllODJHQ00xa0VuMzlsOWV3L09aWjdFazVMS3pzVS95cEwz?=
 =?utf-8?B?dStXbnQydWxnN3JqL04zOUc1cmR2M3NDMkl4YzloUFM3WEoxcURJN1BCeVQw?=
 =?utf-8?B?bzRpQlEzQzdVZUl0ak11Sytsa3JJZGxvM3ZQVlFmdGNheDlTNUQ4U3NFWnFx?=
 =?utf-8?B?SVczL3lIdzRBZ1lqcjRweTZFMTZuOVoxbzBUK0dHdHF6eXdIaVRONjB1Y2Q1?=
 =?utf-8?B?Y2xhMnR2QkFGY2JaL0t3VTlNMXVCWlY0V0wyQ2xlTkZTUHpZRThEQ2x1MUlR?=
 =?utf-8?Q?tUVusMPLUwDG0x2MeJYU3iXeQ?=
X-OriginatorOrg: talpey.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4373abb-58c0-42bd-45ea-08dc7b3677d1
X-MS-Exchange-CrossTenant-AuthSource: CH0PR01MB7170.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 14:41:44.9479
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2b2dcae7-2555-4add-bc80-48756da031d5
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xSh0BfbURbR4YfN8Uu0AqWYv2tJeWWmI0Off2LbhceLgXi1X21F7H6AYvgfHchKs
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB8514

On 5/22/2024 6:59 PM, David Howells wrote:
>      
> When a cifs_io_subrequest (wrapping a netfs_io_subrequest) is cleaned up in
> cifs_free_subrequest(), it releases any credits that are left in
> rdata->credits.  However, this is a problem because smb2_writev_callback()
> calls add_credits() to add the new credits from the response header
> CreditRequest to the available pool.
> 
> This can cause a warning to be emitted in smb2_add_credits() as
> server->in_flight gets doubly decremented and a later operation sees it
> having prematurely reached 0.
> 
> Fix this by clearing the credit count after actually issuing the request on
> the assumption that we've given the credits back to the server (it will
> give us new credits in the reply).

 From a protocol standpoint it's correct to reserve the credits while the
operation is in flight. But from a code standpoint it seems risky to
stop accounting for them. What if the operation is canceled, or times
out?

I'd quibble with the assertion that the server will "give us new credits
in the response". The number of granted credits is always the server's
decision, not guaranteed by the protocol (except for certain edge
conditions).

I guess I'd suggest a deeper review by someone familiar with the
mechanics of fs/smb/client credit accounting. It might be ok!

Tom.

> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Steve French <sfrench@samba.org>
> cc: Paulo Alcantara <pc@manguebit.com>
> cc: Shyam Prasad N <nspmangalore@gmail.com>
> cc: Rohith Surabattula <rohiths.msft@gmail.com>
> cc: Jeff Layton <jlayton@kernel.org>
> cc: linux-cifs@vger.kernel.org
> cc: netfs@lists.linux.dev
> cc: linux-fsdevel@vger.kernel.org
> ---
>   fs/smb/client/file.c |    7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c
> index 9d5c2440abfc..73e2765c4d2f 100644
> --- a/fs/smb/client/file.c
> +++ b/fs/smb/client/file.c
> @@ -110,6 +110,7 @@ static void cifs_issue_write(struct netfs_io_subrequest *subreq)
>   		goto fail;
>   
>   	wdata->server->ops->async_writev(wdata);
> +	wdata->credits.value = 0;
>   out:
>   	return;
>   
> @@ -205,10 +206,12 @@ static void cifs_req_issue_read(struct netfs_io_subrequest *subreq)
>   
>   	rc = adjust_credits(rdata->server, &rdata->credits, rdata->subreq.len);
>   	if (!rc) {
> -		if (rdata->req->cfile->invalidHandle)
> +		if (rdata->req->cfile->invalidHandle) {
>   			rc = -EAGAIN;
> -		else
> +		} else {
>   			rc = rdata->server->ops->async_readv(rdata);
> +			rdata->credits.value = 0;
> +		}
>   	}
>   
>   out:
> 
> 
>