Received-SPF: pass (google.com: domain of linux-kernel+bounces-187663-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 23 May 2024 15:47:44 +0100
From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Tim Harvey <tharvey@gateworks.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Li Yang <leoyang.li@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: fsl: rename gw7905 to gw75xx
Message-ID: <20240523-vividly-sequester-d85ac7bccbbd@spud>
References: <20240522215043.3747651-1-tharvey@gateworks.com>
 <07250029-7cea-4a82-9e70-22e0e6f7fb37@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="mHB66SfMY12XnJ+/"
Content-Disposition: inline
In-Reply-To: <07250029-7cea-4a82-9e70-22e0e6f7fb37@linaro.org>


--mHB66SfMY12XnJ+/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 23, 2024 at 09:02:46AM +0200, Krzysztof Kozlowski wrote:
> On 22/05/2024 23:50, Tim Harvey wrote:
> > The GW7905 was renamed to GW7500 before production release.
> >=20
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documenta=
tion/devicetree/bindings/arm/fsl.yaml
> > index 0027201e19f8..d8bc295079e3 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -920,8 +920,8 @@ properties:
> >                - fsl,imx8mm-ddr4-evk       # i.MX8MM DDR4 EVK Board
> >                - fsl,imx8mm-evk            # i.MX8MM EVK Board
> >                - fsl,imx8mm-evkb           # i.MX8MM EVKB Board
> > +              - gateworks,imx8mm-gw75xx-0x # i.MX8MM Gateworks Board
>=20
> That's not even equivalent. You 7500 !=3D 75xx.
>=20

> >                - gateworks,imx8mm-gw7904
> > -              - gateworks,imx8mm-gw7905-0x # i.MX8MM Gateworks Board
>=20
> Compatibles do not change. It's just a string. Fixed string.

I think there's justification here for removing it, per the commit
message, the rename happened before the device was available to
customers.
Additionally, I think we can give people that upstream things before they're
publicly available a bit of slack, otherwise we're just discouraging
people from upstreaming early.

--mHB66SfMY12XnJ+/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZk9XEAAKCRB4tDGHoIJi
0pJIAQCdg1Tf5q/06rcKoEqgcWnLs/48jFh1hSVrAM3QZADuMQEA05roU61bH/VP
OkVQflknoA0fQLl2xRmXY0EunCIYEw0=
=v3l4
-----END PGP SIGNATURE-----

--mHB66SfMY12XnJ+/--