Received-SPF: pass (google.com: domain of linux-kernel+bounces-187665-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 23 May 2024 15:51:01 +0100
From: Conor Dooley <conor@kernel.org>
To: Oleh Kuzhylnyi <kuzhylol@gmail.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
	jeff@labundy.com, neil.armstrong@linaro.org, schnelle@linux.ibm.com,
	arnd@kernel.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org,
	robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	artur.serhiienko@gmail.com, igor.opaniuk@gmail.com
Subject: Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: add Hynitron
 CST816X
Message-ID: <20240523-hulk-sake-da52a7545ab5@spud>
References: <20240522203347.2263425-1-kuzhylol@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="0lfDBifo+k1uqAPQ"
Content-Disposition: inline
In-Reply-To: <20240522203347.2263425-1-kuzhylol@gmail.com>


--0lfDBifo+k1uqAPQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 22, 2024 at 05:33:46PM -0300, Oleh Kuzhylnyi wrote:
> Add documentation for the Hynitron CST816X touchscreen bindings.
>=20
> Signed-off-by: Oleh Kuzhylnyi <kuzhylol@gmail.com>
> ---
>=20
> Changes in v2:
>  - Apply pin definitions and DT headers
>  - Use generic name for DT node
>  - Drop status field
>=20
>  .../input/touchscreen/hynitron,cst816x.yaml   | 56 +++++++++++++++++++
>  1 file changed, 56 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/h=
ynitron,cst816x.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/hynitron=
,cst816x.yaml b/Documentation/devicetree/bindings/input/touchscreen/hynitro=
n,cst816x.yaml
> new file mode 100644
> index 000000000000..22bd145db5ee
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816=
x.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/hynitron,cst816x.ya=
ml#

Filename matching compatible please, so s/cst816x/cst816s/.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Hynitron CST816X series touchscreen controller
> +
> +description: |

The | here is not needed & you can drop the "Bindings for" below.

Maybe add a link to a datasheet if you don't want title =3D=3D description.

Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

--0lfDBifo+k1uqAPQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZk9X1QAKCRB4tDGHoIJi
0iLcAQCd9wA6lC/r6uoaFfC4d+Rr6zRitp2mhqDJZ9AH+SEkrQEAoNlgRPmKtt1o
BhQXnP0f3PcfwbvBrmiadI8uHUh8BwE=
=eJC5
-----END PGP SIGNATURE-----

--0lfDBifo+k1uqAPQ--