Received-SPF: pass (google.com: domain of linux-kernel+bounces-187762-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Luck, Tony" <tony.luck@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>, Zaid Alali
	<zaidal@os.amperecomputing.com>
CC: "rafael@kernel.org" <rafael@kernel.org>, "lenb@kernel.org"
	<lenb@kernel.org>, "james.morse@arm.com" <james.morse@arm.com>,
	"bp@alien8.de" <bp@alien8.de>, "Moore, Robert" <robert.moore@intel.com>,
	"Benjamin.Cheatham@amd.com" <Benjamin.Cheatham@amd.com>, "Williams, Dan J"
	<dan.j.williams@intel.com>, "arnd@arndb.de" <arnd@arndb.de>,
	"Avadhut.Naik@amd.com" <Avadhut.Naik@amd.com>,
	"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
	"john.allen@amd.com" <john.allen@amd.com>, "linux-acpi@vger.kernel.org"
	<linux-acpi@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "acpica-devel@lists.linux.dev"
	<acpica-devel@lists.linux.dev>
Subject: RE: [RFC PATCH v2 3/8] ACPI: APEI: EINJ: Remove redundant calls to
 einj_get_available_error_type
Thread-Topic: [RFC PATCH v2 3/8] ACPI: APEI: EINJ: Remove redundant calls to
 einj_get_available_error_type
Thread-Index: AQHaq8NuQgJGsroEcUGX/TI726xI2LGk8COAgAANJMA=
Date: Thu, 23 May 2024 16:02:45 +0000
Message-ID: <SJ1PR11MB608387C960ECC119B2DF7101FCF42@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20240521211036.227674-1-zaidal@os.amperecomputing.com>
	<20240521211036.227674-4-zaidal@os.amperecomputing.com>
 <20240523161357.00007532@Huawei.com>
In-Reply-To: <20240523161357.00007532@Huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0wkoQskOnoL7jckHc0uxS1MyzrNN36lhOoi9468Vv6XqLeT9Brl93vphuZa6?=
 =?us-ascii?Q?uD9ay54NKGNo1i6I+Fw3Esz/8rXty/b21tNPzOauWITsjdtBAh+80qkFxBQR?=
 =?us-ascii?Q?KCC5hB00dIAo8b2CalCgEdrk2mbEcHCJdBZz7c2IjUTEEpZtMkpgOdhLpKPC?=
 =?us-ascii?Q?+PCsB527BpwtBJqFt8LJXlaOtEmsk4Rs6eVlmUnBvL8tQ7KXMG+1iNZVlQ8C?=
 =?us-ascii?Q?5jGC3pZkCDXKL8eUoh4FrA6MGYCXEtWixFM6ZdXz6GYLJW+DTBQaoPBxMh4Z?=
 =?us-ascii?Q?F/n6H9zTyON9/Gb+NlRN3C/CX8LGo754Ke77MrlgIJjwDBQnnDddCPkBD0Yl?=
 =?us-ascii?Q?6LhLAJBKpGiDYKhbkRaCFRjk9q27+wnGhrvJfRMW0vEt/3f+XwJiawA2n97e?=
 =?us-ascii?Q?aH5lDmw6iXfCUnJFkzvlwaXWFVTPtrDD/4ww7+su/cEaX4wVw2alsuUeKxmv?=
 =?us-ascii?Q?tBUrBOYuEtIc3LnIK7WlKQpS2CJGno+7qS/gvixiKy7b7iyUpwy/dYaoQUFt?=
 =?us-ascii?Q?ofQ/BktJ93vm9DvDQ4b9EW0vu9gAQivPj/Jg4z+5LeAm+V41R/w/8djQ/OvW?=
 =?us-ascii?Q?F3DXuVIrau2ZkZY2aES+hoDaRDOtCWWFdxMcXN8ba1d7zAUdX7iU4iw2Y0FO?=
 =?us-ascii?Q?hPwhbOC3JS8uC27DFod+IvV46reOLaQB7URtX9SnNE/IftupuwiTugwB1Nes?=
 =?us-ascii?Q?j8RifzmMOH2PNDOGxGHtr3nDenPn51D63LkeoPvw+4ttTuh375cKYLbyniPZ?=
 =?us-ascii?Q?IST7PU3l1218ss5fqi+1vhK+Nw/2fp6aYVazk+ApPpgjmsUVEwVYCGBaUI2d?=
 =?us-ascii?Q?KVx9hLejTKbUkRQDE7Hu0FdURpTaL18m4hio8qBMXrX/7Y3U7D4I37eLsGqV?=
 =?us-ascii?Q?IOhIMjkmgIqdIRfBd1+SpAikUiiV6MIluROnNJ2NnshZUTC6C44hqL2jnYM1?=
 =?us-ascii?Q?hcsMmUoX6vdSVmddIzA8YTDQpcptxiiu5hc/iFJ5gL1vdJPzEeHOmeOpF4rm?=
 =?us-ascii?Q?hbLx7XgvdeOElrzIpRSNoyePO6BGGOvyRT8poa4ZJZB1XA2NNbZ5RwziZaPx?=
 =?us-ascii?Q?p+9K/JunqbDGysNF/D/XFwUJ7tpp26MAf2/4OndzBp6xq5jwSemG82+a6xPt?=
 =?us-ascii?Q?IEWuEHpguWAO6ZUmzCX8SQS+LDyDUt/AzyFp+l++gvup6zHf9P0ZoWfyva60?=
 =?us-ascii?Q?Ikm0X2eZAVMgHrEJqmqnL9R4TsuGtd4ZFTrMI6OfIJHbspt2YwD7vr2oHYHr?=
 =?us-ascii?Q?idAoWWyJfhuIVJ8SRaz5LE6bEPmTbp6Y95dFRlhUz6A4LXJcADiKY074Mv6d?=
 =?us-ascii?Q?iIX468xIUtFQo7qNFc2n6Q/guDZqXUlOpyPvSjgHVKAcKSh2tbWZQzC4mG3X?=
 =?us-ascii?Q?VVb+a1t+skhRm21YqFdIq7AO/Bl/vgOmroWFREqYUhZtPQ2EbFFEF9/N6x6Z?=
 =?us-ascii?Q?cTfiqQC4O5zekxYkNRH/QqAYpRl+EKOgh189vbU0q5wdd6JmRniQ1Ee7QDZk?=
 =?us-ascii?Q?fUUMucoOmnNLpoDVB2lMHB/BwJ7uT1K7z/Bvi1ggMMnmwW8J0MXfyccGCMYN?=
 =?us-ascii?Q?0AROSFrL+8xYzDiecUH7VKX+alLqA/Euim0HOKUP?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9955715b-931c-463d-cceb-08dc7b41c8d6
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2024 16:02:45.2282
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: h7M99Pu7kqkMYYAIgCtVmAz4FgUjeSIgAJ3Wjw7TGeXkO9gEHM3uWX8zhMjKmNBt38INQ4tR1vrAwxCtoif7zg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6774
X-OriginatorOrg: intel.com

>> A single call to einj_get_available_error_type in init function is
>> sufficient to save the return value in a global variable to be used
>> later in various places in the code. This commit does not introduce
>> any functional changes, but only removing unnecessary redundant
>> function calls.
>>=20
>> Signed-off-by: Zaid Alali <zaidal@os.amperecomputing.com>
>
> Seems reasonable to me.
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Agreed. I've thought about making this change many times, but always
distracted by other issues. Thanks for doing this.

Acked-by: Tony Luck <tony.luck@intel.com>

-Tony