Received-SPF: pass (google.com: domain of linux-kernel+bounces-187777-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: <Woojung.Huh@microchip.com>
To: <Parthiban.Veerasooran@microchip.com>, <steve.glendinning@shawell.net>,
	<UNGLinuxDriver@microchip.com>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <Parthiban.Veerasooran@microchip.com>
Subject: RE: [PATCH] net: usb: smsc95xx: fix changing LED_SEL bit value
 updated from EEPROM
Thread-Topic: [PATCH] net: usb: smsc95xx: fix changing LED_SEL bit value
 updated from EEPROM
Thread-Index: AQHarO64heFno/z1gkqlQ83Rc4JXn7Gk/xpQ
Date: Thu, 23 May 2024 16:17:09 +0000
Message-ID: <BL0PR11MB2913CE81AFC08F2D619C3B6CE7F42@BL0PR11MB2913.namprd11.prod.outlook.com>
References: <20240523085314.167650-1-Parthiban.Veerasooran@microchip.com>
In-Reply-To: <20240523085314.167650-1-Parthiban.Veerasooran@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yfZxOOKWwsyDHwED2CNylFHYBQj+JOXtzNBGYKgTplNa9Be4r9ejhyiTxSuc?=
 =?us-ascii?Q?xN9/Q5D2WjpA55uhiSg2GaJnLxOEbLkV0Ypdn2u42i9SgZidCxJRQn5xcGj9?=
 =?us-ascii?Q?Yewfz8fyEZUknFWqwrGsl2FhXHBto0NkSPIx3n4nJ3tsmh1q9XsILUuL2S3m?=
 =?us-ascii?Q?0r45gUZg7E0c4eLv16rZdeRk02vy7Rh0mLFBRgz4Y/dNxceYC61NY3cqmdVR?=
 =?us-ascii?Q?9nMJwLaUJIlMg3EIE+LNYCFQPqhwZpuST5tvd8nDFiFV2ajAeyEVG2WYDYM4?=
 =?us-ascii?Q?9WYvOpSVKjcD3/KQy/BjO/UPwpdCLkJMmZrm1VfBQvvB1fTrhyMCXMtGkPKd?=
 =?us-ascii?Q?3iyUJBgctztTbA137cBww0ySE2Jm+TTCatKOHnytB8tddbdJH3djQbDClId4?=
 =?us-ascii?Q?clNLQv1Vewymb4BuXMZ1IunTyng+G/mbv8R6rv50Db9GXtRoa1ZeBI0LVMRR?=
 =?us-ascii?Q?rZwumOhA5w6YwwIFQ1B4LEZRb0fwyGv1Nk76zlbi9/dohB/ecAxWuaIEHtZL?=
 =?us-ascii?Q?BtXUzwAoXGST/X2Eo5dpd1qPMja6D+hLMaZmgKq7+Dffm+l/JGmODYU9OLK7?=
 =?us-ascii?Q?pV2xanMRbW1baUuOVWBYxgc7YDvqjtW3UajNoipczXWdZwqeIUTYp6BOO09+?=
 =?us-ascii?Q?kBvsdCX6+dhrittyBUI2EO9id5/lWGa1nup8ZzMrs2Q93k5YmuEmxNCNHi9n?=
 =?us-ascii?Q?VIt75dRmwVdgUHk7rvKpv5duCo/21szuZI8UlFi/Hv9sZFkVEOgrECddTC+e?=
 =?us-ascii?Q?CD/LdWEfTS6e3zdPFJgpHDyuenF0gZY+593WBWDrXh7bDszdzFXAWvNrLgKc?=
 =?us-ascii?Q?8FkFY+/cMik9HEfr91HDenZeLHmXalP70vv3Vcax9MbevatsvjfwmgZep92p?=
 =?us-ascii?Q?qk5Pn4q57Ipa+9MWJxi0HMXViHJZ4GQk5ZMLmpDJ8AMGXGOD/akXttv7diQi?=
 =?us-ascii?Q?/sH193xe1KtSvWMvfuvmMT3Bm6shhPLSIOeUB2KP9PMjfb/Q4QhO9B5jJxs+?=
 =?us-ascii?Q?ANQuWLyIMoJ4dvzy8OkEVZeJEd+jgN5jqTZhNXNxVPW5gTP+wi9MXJpBOZge?=
 =?us-ascii?Q?t7Mq7DNbdga4DqxAisz+kLFGA98t3vwuPAk3O6BVq6tru8E5HJAv6ATxgf8F?=
 =?us-ascii?Q?Z/SZsHsBzppymYP5Plugk0gEJDcaiokp4g17cmqmlmjQA6r2+nT9vAoaOsAx?=
 =?us-ascii?Q?BjpApxCZ4zVf3/yEunaGAiQPWDF6xTh/gcPcu4Jzd6Omk7FU4qM7H3eR1/bo?=
 =?us-ascii?Q?Gi6Mm3Nkjh7CS7UeKTZ7UTKVZe6kLfkyHegvB2r71mytYl2UaHgTtx4ERyy0?=
 =?us-ascii?Q?fckFhN/prYHWZNAt+50vBEKR2RXb2SfpSmSdrEVxQV8FoRo7KFES2hfKjKVa?=
 =?us-ascii?Q?NtWr5HJS6+3EMG/ChorcZC5m5I5JiAcPWiYH5autMDv8135ouIgSzcB7seRA?=
 =?us-ascii?Q?2Q8Etph0dgnL026lPwO06lsiiYqMoNhTK8xta129W7NFltuKmqXDsNsFkPgi?=
 =?us-ascii?Q?lSl8Cgl5f+sR7Sl33jIxmGzNoh20AByIvd7NTElqjXoLPVnkkILAADGpVMsh?=
 =?us-ascii?Q?FWmvONqs+ozmkukj2Qdmo+tIbLglzTxO9jM/P4nb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB2913.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c507c97-11d9-450f-a239-08dc7b43cbea
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2024 16:17:09.3772
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BnkoZtEcmcHfrlVLUdu+vXP7TUBtAz7u0oAX/QKI6kKhoazjR0eahik11AMvxq9PEHlwa1RbyGgg/Z+nPjUBsKmTkwMLs0h8z9xZOC7fbpk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6695

> -----Original Message-----
> From: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
> Sent: Thursday, May 23, 2024 4:53 AM
> To: steve.glendinning@shawell.net; UNGLinuxDriver
> <UNGLinuxDriver@microchip.com>; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com
> Cc: netdev@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org; Parthiban Veerasooran - I17164
> <Parthiban.Veerasooran@microchip.com>
> Subject: [PATCH] net: usb: smsc95xx: fix changing LED_SEL bit value updat=
ed
> from EEPROM
>=20
> LED Select (LED_SEL) bit in the LED General Purpose IO Configuration
> register is used to determine the functionality of external LED pins
> (Speed Indicator, Link and Activity Indicator, Full Duplex Link
> Indicator). The default value for this bit is 0 when no EEPROM is
> present. If a EEPROM is present, the default value is the value of the
> LED Select bit in the Configuration Flags of the EEPROM. A USB Reset or
> Lite Reset (LRST) will cause this bit to be restored to the image value
> last loaded from EEPROM, or to be set to 0 if no EEPROM is present.
>=20
> While configuring the dual purpose GPIO/LED pins to LED outputs in the
> LED General Purpose IO Configuration register, the LED_SEL bit is changed
> as 0 and resulting the configured value from the EEPROM is cleared. The
> issue is fixed by using read-modify-write approach.
>=20
> Fixes: f293501c61c5 ("smsc95xx: configure LED outputs")
> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com=
>
> ---
>  drivers/net/usb/smsc95xx.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

Reviewed-by: Woojung Huh <woojung.huh@microchip.com>