Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp16417lqb; Thu, 23 May 2024 09:32:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVltjSuUvrYCcYlRnGLXviUlWDoskPtleaSQDDDxFmGeJMkVZkFa9rPBaHJJW/7ahf/gfJSKH3iJlGdNvHidGzSvWdhj+mN/rg5ciREwQ== X-Google-Smtp-Source: AGHT+IEp45cFRMprJFVZmSjtlxMBzmDlw+ztlxwl8NEUOEcRbKmnT4qVBZLhWu7iqgfaXs/qr0vh X-Received: by 2002:a05:6512:ba6:b0:523:8b4b:8c9f with SMTP id 2adb3069b0e04-526c096f13fmr4813772e87.43.1716481929132; Thu, 23 May 2024 09:32:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716481929; cv=pass; d=google.com; s=arc-20160816; b=X5Xpcu4qLtxqafhJ010YdwL1ddPLTDxV4iMhD9D8K4SQisPIpgaFW7BVPFH4OcwOXg 5+UZoE7p6gOSjCt/UixG9+ObMqZ036eCVBGIok7bQy3cG1DsRwwQlUXTUjWICw0CRc29 UD7cCLHzRaHiTUgj/ucLdjfGDoF5OldSJ1XcOUDiqxZPuVycmDwedoYzbwYCuvW3WJu6 SDe/GWFGyczStdY9pTMndfOoMsfcovHIARkec9lu++ann1K85OAHIeenooMKtBIMVicl ZUWAQ17ruxutL4sC11u3xPBYS0RF4lDgc0wcGvpednnPRkgoydjdqh4JGXD/BwWObFsk ZgTw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=LyhHISfR2nUTU/8V7ncUf/5ydB/oH1DtTZodkLYFngk=; fh=OAQ++rtvwCqQeFDa1f2PcxHF3YTbVbzNt+9tNrP9r3U=; b=S0vhaFxI2xooOMtI0g3JukLB4ZNsC/nok8VCm2jEaBv5KEv5yN91GfV0FZldJkysHo YpW1wK0DNxTFo+tzmt7QfYd+E+D3kYPvDebjDwaOEh8qaeUT01XIs38M8MM+flii+dkP Nl1s3H/olciPhLQOPyOpYxnx6WQoeWGaa8adnFO+0Dkvt7r8zKFT5oOIp9x05+SmWnI8 3keJZi5TSAycywduNpOCQg8PmQrw++sk8taNPEtuEPxfuCi3D6O/qfJj2ek0w0Jsvwds wJzFKZiBQCbIR3np6dbdv969bI311BDbMUI/5C9OPDyuhwBUH77FMoCgt5tIqn91TQ2y lOlg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fJp6Xc4x; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-187785-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-187785-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57838a59308si1486096a12.125.2024.05.23.09.32.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 09:32:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-187785-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fJp6Xc4x; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-187785-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-187785-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A8D391F228B2 for ; Thu, 23 May 2024 16:32:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0CF121CFBE; Thu, 23 May 2024 16:31:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fJp6Xc4x" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 905651BC39; Thu, 23 May 2024 16:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716481916; cv=none; b=WDbtRssZ7Z5nUjpgTTy5whlikpcoej5AaLdKplRO5wQhDfdMCzRQXbyFopv2Kbqnw1l5G9QtkeKvAPJWrp4EmMipI81Vjpe8875dEW0d7WMi3fTrC+C4UZtCt5bni3HK8V1atLne4yUGzR2i2JNiqzfMOkoUc1MzzVnwrgxJRXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716481916; c=relaxed/simple; bh=BIV4oelLREsw1BHdiAVnVRU0aKkmcra+o9gjdpAyFV4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uJuftAozJk7MsQSJFH+ttkY32P/Gx6Ed3YOMFk/jAvqldtNJODmT/yRB7VXnmd6kxaC3DPOsIUyx6LWxMZiIIh2DO/G64bP+SIiR/JufDBtnIIO0tSOmQ1Ia0rkSs5jvyOcWfdSwvvKtx/X6jeQYrnGABpmHQdZtueEZG8KphzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fJp6Xc4x; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716481914; x=1748017914; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=BIV4oelLREsw1BHdiAVnVRU0aKkmcra+o9gjdpAyFV4=; b=fJp6Xc4xOor6IKa3Oh70l2NK2d0CjB6G2FWlyoVhsgG3TVQ4+/zXTFTM i92R+dPfwfG+EHPsPyeLCCR7I8RspCz5K72pypKNADayMi0rAMsNbMn8X lPiqpiBffSpZw9LtNfcVYQPEoRRFgUhsmsyRJRP48MeJVxOPDkQugGLer yD8F/U/JHBNvrH+TTM+udmoOQZl90TAKkFQCS84N/9TEN5qGJkL21o+1C tiTUYCbx6YLvEPLnSovmz8XnNbbWLbq9UGUofV8TAHgbMcboVG1pKGTnZ mdBOWQiuojH13C0bH7XTqoK/z7W037OxLpmbn+FygZ2uBCrVFgjH8So4C A==; X-CSE-ConnectionGUID: /zL5pCHBSKylQfmxldJYKA== X-CSE-MsgGUID: dcRcnhcVTrO4n8KO6tyTyA== X-IronPort-AV: E=McAfee;i="6600,9927,11081"; a="12990880" X-IronPort-AV: E=Sophos;i="6.08,183,1712646000"; d="scan'208";a="12990880" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 09:31:54 -0700 X-CSE-ConnectionGUID: TKPBX1INQzCGxw1D2USyNw== X-CSE-MsgGUID: Ab2krLjGRyuQnHQIVXw/iA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,183,1712646000"; d="scan'208";a="33790563" Received: from kinlongk-desk.amr.corp.intel.com (HELO [10.125.110.49]) ([10.125.110.49]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 09:31:52 -0700 Message-ID: <5c14a151-25c9-41f5-af65-d2a8ffe548fa@intel.com> Date: Thu, 23 May 2024 09:31:51 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] x86/cpufeatures: Add AMD FAST CPPC feature flag To: Xiaojian Du , linux-kernel@vger.kernel.org, x86@kernel.org, linux-pm@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, daniel.sneddon@linux.intel.com, jpoimboe@kernel.org, pawan.kumar.gupta@linux.intel.com, sandipan.das@amd.com, kai.huang@intel.com, ray.huang@amd.com, rafael@kernel.org, Perry.Yuan@amd.com, gautham.shenoy@amd.com, Borislav.Petkov@amd.com, mario.limonciello@amd.com References: <691ec6cf79788e6db919965f787505434b072fac.1716444920.git.Xiaojian.Du@amd.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <691ec6cf79788e6db919965f787505434b072fac.1716444920.git.Xiaojian.Du@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/22/24 23:16, Xiaojian Du wrote: > #define X86_FEATURE_BHI_CTRL (21*32+ 2) /* "" BHI_DIS_S HW control available */ > #define X86_FEATURE_CLEAR_BHB_HW (21*32+ 3) /* "" BHI_DIS_S HW control enabled */ > #define X86_FEATURE_CLEAR_BHB_LOOP_ON_VMEXIT (21*32+ 4) /* "" Clear branch history at vmexit using SW loop */ > +#define X86_FEATURE_FAST_CPPC (21*32 + 5) /* "" AMD Fast CPPC */ It'd be nice to expand the CPPC acronym at least _once_. Also, this is used _once_ at boot and not exposed in /proc/cpuinfo. Is it even worth defining an X86_FEATURE_ for it?