Received-SPF: pass (google.com: domain of linux-kernel+bounces-187789-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Suman Ghosh <sumang@marvell.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
        "andrew@lunn.ch"
	<andrew@lunn.ch>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] [PATCH net] net: micrel: Fix lan8841_config_intr after
 getting out of sleep mode
Thread-Topic: [EXTERNAL] [PATCH net] net: micrel: Fix lan8841_config_intr
 after getting out of sleep mode
Thread-Index: AQHarOT3UyOxKcfaoUSXaQoYOaBJMbGlBGjw
Date: Thu, 23 May 2024 16:35:51 +0000
Message-ID: 
 <SJ0PR18MB52169D42D6D26244E003BCC8DBF42@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20240523074226.3540332-1-horatiu.vultur@microchip.com>
In-Reply-To: <20240523074226.3540332-1-horatiu.vultur@microchip.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?qIcxO1n4uCvVdQbvSqylrgZr/FWe5wENwCPr9Kpy360nSZKQeh180wi6HgFB?=
 =?us-ascii?Q?8gjhFN5vLU6IEIrriS+UucFpP8ys6dr/OrcTWUIg6g3FwgLv1ReN333yO6xl?=
 =?us-ascii?Q?JrNRGa5Ypvh7qtMa+4M5Hl1vn3AF1Ut3xCkVSRvW3doEg/uUAzpEvA3E5gEk?=
 =?us-ascii?Q?WAei/dj0QBvROCacfZHu3ImoRaUkruvsqXJsekkpWBTFiiCQe284vDKFfBtI?=
 =?us-ascii?Q?d0UJBRCsqyux1fXnwUbg6gL1s5espW2ohO2k/SO5w1SCVFJ91TBAOkf0BTZk?=
 =?us-ascii?Q?RyRjpvrACqqAAcI8t4wo0ElcwAAvOI1y2dxG/pF11MziGzCBn34GZ89dNGh6?=
 =?us-ascii?Q?WpMHfo6HzHmHZbommnuoUwCXFCyTTEHlx/9hlsxPPZNX61UbpatVxDVcR9P7?=
 =?us-ascii?Q?ya2mvWTXsmLUapVfgoYH+PtWlg6YHVKtwTmeA9GLlB48yFH+Hz723emiABXJ?=
 =?us-ascii?Q?SpLbMVQEouQ4tIGyxPI+8FfuNdBicqKnRTnMssKO+pxfccWYdXP7kTXWwj4m?=
 =?us-ascii?Q?vQdzqyc2U4caURP/3we8t5u9jbu4BzOWLtUle0ErN2XAFWngvkoTppArEDQS?=
 =?us-ascii?Q?ZkWG8HzYAKUn8kkzPemslxoiP2X6uqo3bkT4WJntzdFUrPMm5cM940lFd2dH?=
 =?us-ascii?Q?Ac9wi7FCPoTaLXy3FbYmLlUqG2JLP8J8/1r82RGpCVvJiyGNmCjB5iT7NhP2?=
 =?us-ascii?Q?EDCSBZhbxxTArkPHH80n1wRFqnonQUg34/KVGl5XYzCzXL+wJ7qe0Milz//u?=
 =?us-ascii?Q?DC1Hd3n5EY7+GUXiABT5j+YPeAnsvhXt3UVMPxr5915Zt4/IwTRxmNNQi2N8?=
 =?us-ascii?Q?DvWMyzPTcCZrae0LQc+jXCGhkzDG44Fgm8VMZRVm2wsiIrlE2bZn31wFot55?=
 =?us-ascii?Q?fQJsS6+Vl1NPrVAqDsxlWbepqqkvTmCk2BiQ2cYQomRfJsn6TXWTAfkxO1ch?=
 =?us-ascii?Q?VkgLPhOaPWcVuZ4E70Cdqq0Y78YNn+VsFPK/XKnO2cVTqg65lnKWFuGUYCmq?=
 =?us-ascii?Q?oE+9lvzhepuxL7P7mBQdxxN409lZiHVWRV4BqV77UBw/jTfqF8BBZ+JyATA5?=
 =?us-ascii?Q?m40N2jYOwwcTW89ULNfWMJR2rVmrx2Pn1u61bTv8kJuE0wEjOCnFnQywNLcb?=
 =?us-ascii?Q?DZIOfSzU27OsvD192Go9FjSFCCs6lqsotOZXUODQz6uqE/zNRQKo9Cvtf4wV?=
 =?us-ascii?Q?fShVq23L83maKFhRs/kZmD5pjYqhBD5N2Um0EixcC+34ly189ud4Y1zswWdy?=
 =?us-ascii?Q?dRv4dEaxoidB6KVW//NAPOK7QbWZjelK+73Y+O/T0Nh7OqOrsN5EuxtWLxAV?=
 =?us-ascii?Q?AG2ZiakgTDvM/Bb5/L4/lcCjgajt9WNLqnSJvDw6ZgesVnvhw+usSxMyQb9m?=
 =?us-ascii?Q?wfOmeo7IngIm5QUQmW3bb3k6YMkoa2nORtoxpHBeqGCh1NekFcpEiDTTJtgx?=
 =?us-ascii?Q?UuLh7N13C8EjL4l3n/OdsM+S3Pyj4vEYXDu4h9GM0J1n67FEsoGynlX/ASwF?=
 =?us-ascii?Q?D10XVeNHwQrbRVdcTg1xkHml36WFckjfLIsLfh71tuAvn8ebwlp6Il4svE2T?=
 =?us-ascii?Q?xfqxTM+BIG52csi/VmoXQD8/ZAfBuWDqx/RScgYM?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ee369ca-9ea4-4021-b89a-08dc7b4668e0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2024 16:35:51.7064
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H0wyflwBrAV3r2+LnHqSfdki23qI/cBQJt+kymgBE9UHGW7li/S4heUPeWL3QeMYUveFeP20gK0/LCbpwv9bpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS1PR18MB6147
X-Proofpoint-ORIG-GUID: qHt802B7hr6AFEscS8AHbHNbXqP9uxoQ
X-Proofpoint-GUID: qHt802B7hr6AFEscS8AHbHNbXqP9uxoQ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-23_09,2024-05-23_01,2024-05-17_01

> 	if (phydev->interrupts =3D=3D PHY_INTERRUPT_ENABLED) {
> 		err =3D phy_read(phydev, LAN8814_INTS);
>-		if (err)
>+		if (err < 0)
[Suman] Hi Horatiu,
Should we modify this check for phy_write() as well?
> 			return err;
>
> 		/* Enable / disable interrupts. It is OK to enable PTP
>interrupt
>--
>2.34.1
>