Received-SPF: pass (google.com: domain of linux-kernel+bounces-187793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 23 May 2024 18:43:12 +0200
From: David Sterba <dsterba@suse.cz>
To: syzbot <syzbot+85e58cdf5b3136471d4b@syzkaller.appspotmail.com>
Cc: amir73il@gmail.com, brauner@kernel.org, clm@fb.com, dsterba@suse.com,
	jack@suse.cz, josef@toxicpanda.com, linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-unionfs@vger.kernel.org, miklos@szeredi.hu,
	mszeredi@redhat.com, syzkaller-bugs@googlegroups.com,
	viro@zeniv.linux.org.uk
Subject: Re: [syzbot] [btrfs?] [overlayfs?] possible deadlock in
 ovl_copy_up_flags
Message-ID: <20240523164312.GD17126@twin.jikos.cz>
Reply-To: dsterba@suse.cz
References: <000000000000f6865106191c3e58@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000000000000f6865106191c3e58@google.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Thu, May 23, 2024 at 03:09:26AM -0700, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    c75962170e49 Add linux-next specific files for 20240517
> git tree:       linux-next
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=1438a5cc980000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=fba88766130220e8
> dashboard link: https://syzkaller.appspot.com/bug?extid=85e58cdf5b3136471d4b
> compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=115f3e58980000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=14f4c97c980000
> 
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/21696f8048a3/disk-c7596217.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/b8c71f928633/vmlinux-c7596217.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/350bfc6c0a6a/bzImage-c7596217.xz
> mounted in repro: https://storage.googleapis.com/syzbot-assets/7f6a8434331c/mount_0.gz
> 
> The issue was bisected to:
> 
> commit 9a87907de3597a339cc129229d1a20bc7365ea5f
> Author: Miklos Szeredi <mszeredi@redhat.com>
> Date:   Thu May 2 18:35:57 2024 +0000
> 
>     ovl: implement tmpfile

In the C reproducer it's btrfs + overlayfs, this more looks like a bug in
overlayfs handling the tmpfile and sb_*_write accross layers. Btrfs
functions are not on the stack.

#syz set subsystems: overlayfs