Received-SPF: pass (google.com: domain of linux-kernel+bounces-187838-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6928d21f-90c5-47ea-81e8-1838ad9ce618@oracle.com>
Date: Thu, 23 May 2024 10:38:10 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 3/5] mm/memory-failure: improve memory failure
 action_result messages
To: Oscar Salvador <osalvador@suse.de>
Cc: linmiaohe@huawei.com, nao.horiguchi@gmail.com, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20240521235429.2368017-1-jane.chu@oracle.com>
 <20240521235429.2368017-4-jane.chu@oracle.com>
 <Zk5Xoc1aXuw-KMJG@localhost.localdomain>
Content-Language: en-US
From: Jane Chu <jane.chu@oracle.com>
In-Reply-To: <Zk5Xoc1aXuw-KMJG@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?ZSt3Yk5WMW1sYzFoV3ZvTWxWNUpKV1RURkJDeGRCVUZHRGRMblpydTgzSFJw?=
 =?utf-8?B?d0NVMmh0L1d5Y1RTQlFJaEVEcjlHa0hDT05lNWt6eXhEclpUclhJalZmN3p5?=
 =?utf-8?B?R1VkOS9oU0Rmb2FCNU1hbGYyODIyOFR0aHBkaHhFb0ZheXNoVldHUmdmNDZa?=
 =?utf-8?B?NXliZW5nNHpjd0w3VFZocTV3NGh5SytseWJkSGVDcm5ZUW1NdnlnajJ2dUxH?=
 =?utf-8?B?ajZpVDBRalJLam85VHNDWm15dzAwQW1laEY4cnVDMDJUYUUxelNMREw1Q3NS?=
 =?utf-8?B?cVRTUzZMQlk0djhxNkx4WG01MFRPR095cVJMUlQzVHBZU1o4MU1NNy8rSm9J?=
 =?utf-8?B?MnFsNFdxU1NOc3RxUW1NaXRJaTd3MVNyeVhiWEJNaXhiRytqVVJGckdMRFVR?=
 =?utf-8?B?OGhZZUFYQ3pzNXljdmlobzVKUEFGdTVEYWQzR2V3L1RnWmlDcHIxRkx4RXJm?=
 =?utf-8?B?UEkzT29FVWFUTksvZ0dMeGc1NmYzOWFUc1ExWjdaVklPemhuWmVlTkpPOURO?=
 =?utf-8?B?TUlqUldRcVkwU1NrS2ZyWUJ3L0FWSFhNdjFuakVMUGJYME5nVXlMalE5c01X?=
 =?utf-8?B?NllwaGduS2pYbFQwSnZOZmttcXlZMllmUi8wQ2RQMXhJSEtWZ1Y4L0tqK3BP?=
 =?utf-8?B?SW9SdS82ZStUMStxMk5BQ21zcWlsVitUa3NHU0hIK1JpMmZUME5vYzdVNThz?=
 =?utf-8?B?ektwTTRpbUp0dllwckl0R2kwdkdDTE50L1I4ZXlNbDlzbHVMSzRMcVpNU3hO?=
 =?utf-8?B?SkVPVis0Zm1WZk90dCtMbndXeDFOY0pjR3JDWjY0ejZtNWVMVEdYcVR5cjdJ?=
 =?utf-8?B?VEVZL2Z4ZzRZbFM0VjFjOCticklNOHRCR2xLOHlYQ0tDVUVkNHl6OHhzWmY0?=
 =?utf-8?B?TkJUajVDYzdTYVdjRmNYZGRJbTc5YThWR0N3OGR2YVhVcThwSFhzczBVL3Aw?=
 =?utf-8?B?MUV6UHBCZndpS1J2eHg5UXpuYStsZWthWTg2dzM4bk1JWFJ4WUkxemtZc1h3?=
 =?utf-8?B?MFRHV05id1dTQ24yY1B0cHNQdUF5T0JVNm4yMCtweHc5Q25YeTJ2ZjRWUzNu?=
 =?utf-8?B?K2xXUVhsbkxzcWNqQmw5OEFmR2ZXNDF3dk9yUVdFNmNuZkRBWjdybjRiY3Zn?=
 =?utf-8?B?OWNCdVZPWlJvZ1U5Vlowb1plY0ZWTGJFdVVMT3lRMnFBbmNlajhVYU1jVmxN?=
 =?utf-8?B?R2RjdDIrVFBMNlY0ZnNtTlVpVkZtVFd1WHRZalVsUUhSQ2NVRzZndGpQRkdy?=
 =?utf-8?B?VDdNb2ZMZk1VMnREMDdhdUczSnlnNCsrMlVwVk5SNi9rQTJsdmNVUGVudGl5?=
 =?utf-8?B?MW1STXVGRnY1SXcvbWdYSitaZFdlZDY0dnBZUlU0MFZkYk16NFBjSWh4dzlV?=
 =?utf-8?B?UXorekJ0OTd3QXRla0d3bjFFWGtDbGpuZHlsbHBmYXVWemtlNmQxWENSN2JL?=
 =?utf-8?B?SU5GRzdFL2tlMG1IVkV4azVPYzBnNTJCSGREQnZ1SnhBMkt6bDlpd3Jya1Jw?=
 =?utf-8?B?Qis5cWJzYmpRb1VzMHJ6bnFBN2hMUG5tRS9pSVlwa3hBVkpKamYwZFZjOWFB?=
 =?utf-8?B?STY2NVlmbUszL0VqeEJhRHBHL3RkQUI3NlVOZDNKVmh6VEVBMElLcFpnYUYr?=
 =?utf-8?B?YjNqZ2Ztak5RRFI5dW8vVGJ6Z1VDNjd5cHoxaTNyZmI3dFJCemsybURFZk01?=
 =?utf-8?B?U2tEclpSUDZnYnhvVmFYY051WWFOekZuZGVJRmVUM1l1YUFzRHJGUDBoOEVu?=
 =?utf-8?B?WGFiUTdJMmZQNldKOWlIbFEwMXZ1K2ZyUDZ5aFpUMmN0Vzhkd1hsVFB4U0tj?=
 =?utf-8?B?cWV1N0RRVkFjblU1cTI4R2EzWExNb2s2NTV2TnZoMlpXc01CLzBLcS9mNVdS?=
 =?utf-8?B?S1A2bnh4SXhka2dOY1ZVSkFyS1c0bU1ycHpKMis1R1pjNVYwWFJBU0pqaXZO?=
 =?utf-8?B?VytsMXphYmx2NGNTM0YxcG90THU2VDBMdklSVlhuNWppN2pVMmFXRUNMbWUr?=
 =?utf-8?B?YzdKWUFjOXYwNGZqc29SQTA3c3BsUnB4bDNXVHJiMmRPV1FVYW40eitmRmht?=
 =?utf-8?B?T2diYjA4R2t0dXdiWTYwQkNmQ1VEbzQrWlJoV2xVMVIzTHZSc3puVnZ4alE5?=
 =?utf-8?Q?CwQvAoE/uqXrSLFGYJvF2DUQM?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	O8VCGYkJJDxrl+4i/6Jk1a5SUnL0lmZSRN/B0P7JAaK1YZMHqojXTCw2kgYE6FPSetLj+92uqVrHU9WCKcQxy+3842nz5ipcyvK4NhHizOJ0b2dhsRLdVq1aWr2MWNbsujURQ5gVmqoT/CuUiKxcEK3rsm+tqre7BOK9h90xMb8tGjE2a4ztxeRk4fisiTSUzZ/8fnmSiopYhq0DRPJcUkj657UMka84DtwU/jqumIk7JpPhVBN6dNCVWBGcynxT8MynAvjQx/g9OrXeKafNawfd3sGN70GgZA3TCKOUlQ8ybFO2nTXx2J+XYH+GdwpjbZiow/Fj7bS5sFUG6EfirwaGJsVxlkFJ/CmLPkEPcRmpJL0W3oG6iK4SrziNK6Oc2yOvVshIQ+R9QuuT4QYyxLg8uVM3df+F9sqbwrIdxjSdF1VBzl/6repvCIYocgOukHnxNMkyGuELlB3q9qAjG0c7YAUys2PhrElPuoya9D+bWH19NZEUifZBoCweytT1MR/uRvZ+iHaQzAUJe0Vxa7r3DMfpik96/gtDudjCjXCE2oosP+AplGPl9zG1HSDqtfzgS9W8jci0m5Hfd6KTmKZR1GLlWdB44YvkQ+wWhIY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: edecfee0-4da7-4868-6f15-08dc7b4f2130
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 17:38:17.0876
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z9SIHGRIhIySL6OfukQF9syD0rdNh5doiDG4JZPGPM/ws4W9Ow+aGZJmxq9lnNIPvnRAYixiLZcgsICB7H9M3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7733
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-23_10,2024-05-23_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0
 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=897
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405230123
X-Proofpoint-GUID: OFFO3xYuCHqHxk8j0zGyAYu6zgK0LL2C
X-Proofpoint-ORIG-GUID: OFFO3xYuCHqHxk8j0zGyAYu6zgK0LL2C

On 5/22/2024 1:37 PM, Oscar Salvador wrote:

> On Tue, May 21, 2024 at 05:54:27PM -0600, Jane Chu wrote:
>> Added two explicit MF_MSG messages describing failure in get_hwpoison_page.
>> Attemped to document the definition of various action names, and made a few
>> adjustment to the action_result() calls.
>>
>> Signed-off-by: Jane Chu <jane.chu@oracle.com>
> This looks much better, thanks:
>
> Reviewed-by: Oscar Salvador <osalvador@suse.de>
>
> By the way, I was checking the block in memory_failure() that handles
> refcount=0 pages, concretely the piece of code that handles buddy pages.
>
> In there, if we fail to take the page off the buddy lists, we return
> MF_FAILED, but I really think we should be returning MF_IGNORED.

I guess you mean this code -
         if (has_extra_refcount(ps, p, false))
                 ret = MF_FAILED;
?

It appears in below code paths-
     hwpoison_user_mappings
       identify_page_state
         me_huge_page || me_swapcache_dirty || me_swapcache_clean
for LRU pages.

And for non-LRU
     if (!folio_test_lru(folio) && !folio_test_writeback(folio))
             goto identify_page_state;

My hunch is that the most common calling path would be: 
hwpoison_user_mappings has unmapped the page, then identify_page_state 
is called, but for some reason failed to take the page off the LRU.  The 
m-f() handler has isolated the page to avoid further MCE, so I think in 
general return MF_FAILED is okay.

That said, the line is not always clear, for example in the non-LRU 
case, where the m-f() handler may have done only a little, I guess I 
just need to let the case rest.

thanks,

-jane

>
> Thoughts?
>   
>