Received-SPF: pass (google.com: domain of linux-kernel+bounces-187891-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <a931f44e-0c10-426d-9b65-6541f2068eb2@oracle.com>
Date: Thu, 23 May 2024 14:49:10 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/4] Export APICv-related state via binary stats interface
To: kvm@vger.kernel.org
Cc: seanjc@google.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org,
        suravee.suthikulpanit@amd.com, vashegde@amd.com, mlevitsk@redhat.com,
        joao.m.martins@oracle.com, boris.ostrovsky@oracle.com,
        mark.kanda@oracle.com
References: <20240429155738.990025-1-alejandro.j.jimenez@oracle.com>
Content-Language: en-US
From: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
In-Reply-To: <20240429155738.990025-1-alejandro.j.jimenez@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?RUd1L08wVllUMlNaRkErMmlMakhtY3N6T1RtWGFlNVRKQmJETnlVVDJnZGUz?=
 =?utf-8?B?Z0JuSXNOMFlPbzY1cENhbVp0ZnBIRXVNWFJtNkZQZzE3R0FzMC8yVnhrR3N1?=
 =?utf-8?B?bG9MNGhqQjZiTVhHRjkrYmUvbTBDUDA0aGhpMWY1anAwVExWWkltdXVEa21o?=
 =?utf-8?B?TzRsWTJ0dzRVUUtUTGtONklqVWR5SUdtM1ZGS3JsSm02eUVhSEZjRU9naGZF?=
 =?utf-8?B?SEI2bUxwNXFtVi9mVFRRWDl4RDZQNlFsRFpZWUZHd2NlVTVzbDRxY2s3WVl3?=
 =?utf-8?B?Tms0TzdVdHg3Zmlqa0FSRnkzMytMczNPa1h4cko5dEdCdUVaSG5qcTBnK05V?=
 =?utf-8?B?aWRhYzNmczlpSkxzWDNlSkJmcEZ2QUxrdG5sbHVqUDBYcSsvM0VsNWg0Q1Az?=
 =?utf-8?B?cHhCQmVtdE5rNncrMFl6YzJvMlF3Zk9aWnViNHRaTzZKdy8xMVBQVlp3dUIy?=
 =?utf-8?B?VDVVUE1mVVAwcmxmbjlnVFhyRGJ2aUdiSTNhdHdwL2V3SGFJcnE2TlRZd2Iw?=
 =?utf-8?B?VlhaTGZ0alI1eVpyR2V6dldYZTVzVnBOK1FVZnlHcFI4RFI2cER2eWE5RDBY?=
 =?utf-8?B?aDFDQ1F3L1Y1QzNSV2ZySVp1bXk0UHlBeEVUUk5RYTF0bWZBbzlSaDM3eUkr?=
 =?utf-8?B?SzUyRXdwRjVRNUV3SjVQYzAzT1h6U0Vsb0ZXN24ySXhIcHpoTElxc1E3cEJM?=
 =?utf-8?B?cHpaQnZuUXdkNFc4c3VqU2hjVm4xblhLRk52YktpZ2NPTHNpVFM3eTVYOElK?=
 =?utf-8?B?andTUjRmek1uQ1FSN054TW52SlVpQUVDb1dlYVo5Vi9uakVKMkhJbjA4ZFNt?=
 =?utf-8?B?UTZhRWhPVDdodFZBUGlLbGt2eGQwdXlkd05ZZmdxdGhqb2p5VHg3VE1RaHBn?=
 =?utf-8?B?ZUpOUXZ6N2lsZG0yTkczcjhqMnB0NUx0cUszNTh6RHU2L3RzemQrSkFRVWh4?=
 =?utf-8?B?d0JEYUhpSCsvUWFValdNSXBpbzk5bDBGcmV2OHBkN2pLSjhBSHZkM3d4YlVG?=
 =?utf-8?B?eGcxL3l4MWZMNGhPRW02dW5lVlJNaDdyRkRFeDJuaEcrVkJYa2NsSXRhdjky?=
 =?utf-8?B?cUZqTU1KbGxnTFBpYkl0Tm5XNkw1V2k0eTBoY2tJN3VQai9KVStBU0ZneUlQ?=
 =?utf-8?B?WXBrU0lqU3kvdUFZLzVNNTB5REZ2dG8zMjV6blBZaEdrSm5LdnltSTlONFJz?=
 =?utf-8?B?Y2Q2bDNVYUdaekwrYVlpT0xrSmRCMWlQSmpDSkZYS0F3WXAxWVZpWENzR0hW?=
 =?utf-8?B?NDFDQmIwZ0ExVmVzRzgvMXBFT040SmdHZUYrNldnRU5SYzlYeE03bWpTSEph?=
 =?utf-8?B?dHZIazNoQVFaTEdReWFYZ1liZS9RcEl4ZnhMQWpJYmpsc1JXODhrZSszTWVX?=
 =?utf-8?B?Z1dOSGhNS05USnJ5WHN5QW5sdWxzbnY2bVFuZElyZnVjR3h4dG5LKysxWDA1?=
 =?utf-8?B?TEVObFNjSG5LdHJENllzU1Z2WWZkajdFYzc3QVpaOXZyZTlCYnV5UWp2UEF0?=
 =?utf-8?B?enVTMzNqb1hwSkE2aG5FNndFVGs2dFZCdzZwN0tQMTU1RWpTdnNHczZsRHQv?=
 =?utf-8?B?bUlSMlFDdjNzaXJUekpreGdma3p3YURmSmt3NHBEZlMrVlVONG9KSlcvTnJR?=
 =?utf-8?B?R2dTZHlrY3FkTTBjUmlJSjgweEF0T2RzTEg4ZVhXN2hycGpWQm84emVKQmtV?=
 =?utf-8?B?NzJ1dmZaMFpkQ1E0cXpuc3ZJMHR0b0RHaHd1Y1NseUpyRGhncTBUZmJ2YmlX?=
 =?utf-8?B?UVVMS1ZmcTJwaXN1dGZBNDI3N25MNlV0VkwybHBmSlJqdVJOQUJSV3ZBNXl6?=
 =?utf-8?B?QS9pL1p0bDhlTzAwZFRSemE2Tkp2WVVLTE81bkxoQnEyWHpZeVlUc0N3UEhB?=
 =?utf-8?B?U0Ryb1RtaW1DTCtmNDVXQUE5bFBvUjhSMGhGUmFaY29SYm1RYXJDS1FLK2I2?=
 =?utf-8?B?anJPazlNL1l4dkxSZHdubDdkOXczalExWFM3OFlpeFpmeGMwY2FLWUZoNlBF?=
 =?utf-8?B?RklTL2NyVWVDcW5ucmVxeFFUZkx6YTljNllWODM3NGZtcDBDU01aOXRvUy81?=
 =?utf-8?B?U05PNTRJSlFaZlR5OThraEhwSHVTdmRNOHFnZnA0MVRNbmUwV3dVaVhpT1Rt?=
 =?utf-8?B?b01tMlFwOUhYaHplRk5MM25SZlJFSmNTYkVNOHBTejFvVnA5VU9ObFd0QktN?=
 =?utf-8?B?Znc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	aL0LfdDoFE7nOfrEl+8v/zm4VMt+mMF4hxDAkxB0cX/+u/T/2CJU53jQT8N5WyoIgFG9lw9UIJDM72CKqBGzQcXKuO632tkZ20lgmtPa4ZLiOFXLSRMZZr8mfln5rwyBhDy0oDKImBXINb/r3D/Rgoqs9MlFGQ7eRk4R6C1h7EUHup3mtYNmi/BkQ36v+9IbM/A+dxpvCklkOrfAI/aDKHfx5VzkzG5jy3j4q11P6llY0DPJjY34zt22aXmz/GOKHzb3ksLB3dY8lh9GdPiRo4HIzX4fr4Ehgo6N01dkgUXDNwxntnIID/vsg6yWg6Nq3QaSwLcqJgByvekA+aTkaJKHIFIF+3qRFR+/71sBR7uDZiEf4TFLHvQ1Bxeq7w+FZjKA+QOo1YbAI2UFePD3Cb72mzWZ3itXXkTlV7ST0/ZpkD1/ftq19PlTor8qC88Si34/rbpFx9aq8eSysz5hbr2ZwP+zTe0A8rjpNQE1PTxP/FxMAaYfCYbMkxg840KwCYoomBmYmArZv65KXV4d/sdSEwwwAaRtA4inHuszaIK72A6unJadswC1gY5W8hEqdlHe8guBHxOEQM4/DtUn8jNIefhavx3sCT/OUetUY1g=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61c0b80e-dd5f-45b9-8b5e-08dc7b590a09
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5280.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 18:49:13.3689
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fncoSFDfsdjgDOxA7vOtXf62BQHitcvgwi8E4qREI66quGu44NljyhafoMnUCQGWHQnaOtwMZAgNy425ibn7t/bI5TTafT4m30aYXwBYN1E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7655
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-23_11,2024-05-23_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405230130
X-Proofpoint-GUID: 9ESO7RCqlUS0CoAKM5t4S6_sYq3sdpvv
X-Proofpoint-ORIG-GUID: 9ESO7RCqlUS0CoAKM5t4S6_sYq3sdpvv


On 4/29/24 11:57, Alejandro Jimenez wrote:
> After discussion in the RFC thread[0], the following items were identified as
> desirable to expose via the stats interface:
> 
> - APICv status: (apicv_enabled, boolean, per-vCPU)
> 
> - Guest using SynIC's AutoEOI: (synic_auto_eoi_used, boolean, per-VM)
> 
> - KVM PIT in reinject mode inhibits AVIC: (pit_reinject_mode, boolean, per-VM)
> 
> - APICv unaccelerated injections causing a vmexit (i.e. AVIC_INCOMPLETE_IPI,
>    AVIC_UNACCELERATED_ACCESS, APIC_WRITE): (apicv_unaccelerated_inj, counter,
>    per-vCPU)
> 
> Example retrieving the newly introduced stats for guest running on AMD Genoa
> host, with AVIC enabled:
> 
> (QEMU) query-stats target=vcpu vcpus=['/machine/unattached/device[0]'] providers=[{'provider':'kvm','names':['apicv_unaccelerated_inj','apicv_active']}]
> {
>      "return": [
>          {
>              "provider": "kvm",
>              "qom-path": "/machine/unattached/device[0]",
>              "stats": [
>                  {
>                      "name": "apicv_unaccelerated_inj",
>                      "value": 2561
>                  },
>                  {
>                      "name": "apicv_active",
>                      "value": true
>                  }
>              ]
>          }
>      ]
> }
> (QEMU) query-stats target=vm providers=[{'provider':'kvm','names':['pit_reinject_mode','synic_auto_eoi_used']}]
> {
>      "return": [
>          {
>              "provider": "kvm",
>              "stats": [
>                  {
>                      "name": "pit_reinject_mode",
>                      "value": false
>                  },
>                  {
>                      "name": "synic_auto_eoi_used",
>                      "value": false
>                  }
>              ]
>          }
>      ]
> }
> 
> Changes were also sanity tested on Intel Sapphire Rapids platform, with/without
> IPI virtualization.

ping...

This series implements the suggestions from earlier RFC discussion [0]. Additional comments/reviews are appreciated.

Thank you,
Alejandro

> 
> [0] https://lore.kernel.org/all/20240215160136.1256084-1-alejandro.j.jimenez@oracle.com/
> 
> Alejandro Jimenez (4):
>    KVM: x86: Expose per-vCPU APICv status
>    KVM: x86: Add a VM stat exposing when SynIC AutoEOI is in use
>    KVM: x86: Add a VM stat exposing when KVM PIT is set to reinject mode
>    KVM: x86: Add vCPU stat for APICv interrupt injections causing #VMEXIT
> 
>   arch/x86/include/asm/kvm_host.h | 4 ++++
>   arch/x86/kvm/hyperv.c           | 2 ++
>   arch/x86/kvm/i8254.c            | 2 ++
>   arch/x86/kvm/lapic.c            | 1 +
>   arch/x86/kvm/svm/avic.c         | 7 +++++++
>   arch/x86/kvm/vmx/vmx.c          | 2 ++
>   arch/x86/kvm/x86.c              | 7 ++++++-
>   7 files changed, 24 insertions(+), 1 deletion(-)
> 
> 
> base-commit: 7b076c6a308ec5bce9fc96e2935443ed228b9148