Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp99520lqb; Thu, 23 May 2024 11:56:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVKEZFQMOLc9QfeAaHkg5Eg3JpBiFte+9ACNDTbKPk8BeDPl31TCL306J5LUp39KOBNCqlOF2FjWEa8L3f4P9ODp+ixf6QJNTTocD0Nhg== X-Google-Smtp-Source: AGHT+IEmzDXsSuZI/7vFBlngHSXrsj/LIUz4P/PjMukYew+DDnKsVegsTHJekn1wJIkzDrmK29zF X-Received: by 2002:a17:906:4a91:b0:a59:cd1e:2012 with SMTP id a640c23a62f3a-a623e9d499cmr225172366b.23.1716490596283; Thu, 23 May 2024 11:56:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716490596; cv=pass; d=google.com; s=arc-20160816; b=i11Yw1WGZ39ywoPtN5rWvkmMZMncs/NRw1kgHOWiJqwv2RUSFIiEKGyj5t9GuQblD8 xrOtsBs42vVH99lqHhLeUs+eORCXCe5Yrz3fUTmsD3W1QU99o0+oOM5NCziTPl/r8yOY DHmlCxze+khUp3myEpFFNi1UfxyOPCtGjkHzbr7UYSah+/eUTBHylzyse4dx2PTowhg+ pAlFbLr3BcEdMbFWB3hMk/I1hgJLfYKTSbAv6rQfcsIqvC71R6+BNMb0u/1sZCBRa9I2 3RM383YEPj8krXZUEa1t38nfv8iv0nlmGen8YZt80j3hy1+yqlO44ak7++HQiNlfjr9U 8r+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=3Qz0A4s+ac1o4DbUxhqgH8R8y+ZiUZY1MRJROuRI7/U=; fh=HF+WU1kbfmyzFoNW2fwPNf9N1geI/alMHbMzbwRKBhI=; b=WHQMRDwX86TmhR5ThNMzSFExWz3zTjwVMKLIxhhhb0oW12qQzWXjEZZXxmI75OQwhp 3ScSe6u2RTXsiBNcVPKYfVwAaecoscQRkIpk9j7sf6AbjNirXzN3HPQRhGwkf+MFaSLQ xe17woQfOVkAvAwn3j/MWKLOBxDnTCs9jr1xNYv3/UnIj8E8WdJejWbQipAuZ0TQQTO/ qblLnfbyyC6hpTbiNlaUIpRyXGLjP6O+yZrNB1JERDAUvgFVbBfVnxJ3+APqsnHSghCm glM/4UZplj1JtpXzz5lyuRdcmPDT4GKTi1GiDwVDfLBLA27BiT/MMi3dAAmmTljcyxmW 7Qrw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=J2Nraw2g; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-187895-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-187895-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a17945eeasi1602381966b.92.2024.05.23.11.56.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 11:56:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-187895-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=J2Nraw2g; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-187895-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-187895-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 068611F22090 for ; Thu, 23 May 2024 18:56:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89D3F823AF; Thu, 23 May 2024 18:56:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="J2Nraw2g" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 744C0171A5; Thu, 23 May 2024 18:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716490587; cv=none; b=RrEezAFNo0zO6hVKuNp0GTRbpb6vroDgFPaYsFunMLH4bK7VJdPQry1znkmLz0qe8CNYdct2XzfZ3M6KHay1gGja/2M3s03RB6qWz8hKJoGekWMK9Q8N8EWY+7SgSoszYaZs5wHAX1M7F2yLJ5QyHicQXWX9FuCRfr6S6hZWm+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716490587; c=relaxed/simple; bh=GMvp4ZUa5auyWW48u3nDaI5JWsfDmBZz1W/ehEXgqs8=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=bcizJ6YmYfZ6Q1p5eqPDeF50Ns4ppP+tBP77Qk0CjlRH+VzbP5xe1ixwvHKUZkywtPDl5o0xp6weVtPwQo+llFkIPzYJKDYwGKcgxv9yqY19qURPWgaDtf9RSwdAo8AA9gzw1xGXxb04AZTMl64tnp42Gw2Q5c+jujBpCJge7A0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=J2Nraw2g; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAD8BC2BD10; Thu, 23 May 2024 18:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1716490586; bh=GMvp4ZUa5auyWW48u3nDaI5JWsfDmBZz1W/ehEXgqs8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J2Nraw2gaH6n3MhgobyWRQcVgP6jAWECBzB95SjfoVBQJmBDmSNJZDtSOjFJ4JlAt F4W6jfmG+4pH2rfoHIiPlrLeKyO9ulz746Hu/tTOEZGDO51VthSHB81abHQHqj2vKY OI3ineFKsxEaxMgE/dRhUP0goHVQ7NaCG+OwWmGI= Date: Thu, 23 May 2024 11:56:24 -0700 From: Andrew Morton To: Yuanyuan Zhong Cc: David Hildenbrand , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mohamed Khalfella Subject: Re: [PATCH] mm: /proc/pid/smaps_rollup: avoid skipping vma after getting mmap_lock again Message-Id: <20240523115624.d068dfb43afc067ed9307cfe@linux-foundation.org> In-Reply-To: <20240523183531.2535436-1-yzhong@purestorage.com> References: <20240523183531.2535436-1-yzhong@purestorage.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 23 May 2024 12:35:31 -0600 Yuanyuan Zhong wrote: > After switching smaps_rollup to use VMA iterator, searching for next > entry is part of the condition expression of the do-while loop. So the > current VMA needs to be addressed before the continue statement. Please describe the userspace-visible runtime effects of this bug. This aids others in deciding which kernel version(s) need the patch. Thanks.