Received-SPF: pass (google.com: domain of linux-kernel+bounces-187923-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <4a43cda4-dfa4-4156-b616-75e740f6fd64@web.de>
Date: Thu, 23 May 2024 21:18:02 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Sean Anderson <sean.anderson@linux.dev>,
 linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
 =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
 Lorenzo Pieralisi <lpieralisi@kernel.org>, Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
 Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
 Michal Simek <michal.simek@amd.com>, Michal Simek <michal.simek@xilinx.com>,
 Thippeswamy Havalige <thippeswamy.havalige@amd.com>
References: <20240520145402.2526481-6-sean.anderson@linux.dev>
Subject: Re: [PATCH v3 5/7] PCI: xilinx-nwl: Clean up clock on probe
 failure/removal
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240520145402.2526481-6-sean.anderson@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:8904RJMpJ9s=;JCdx0Wo9Q99BWW96f6JOVg6LGWm
 LfsVgGkVDiGOWkaLD+6IlQ19BwbXymHEY5wAkAxJPs4HLHTe6gc533PPj/pd9A413cpYTvVzO
 0pSZNJtInjL9SXUbWNjXZT52JplYKE3e3xvxFMcNtMwrcr+ypTdmy3PRX9iJLNlSBgiMbE980
 icgFe9m1X0Q8ibra/KXnD3oqJFN38RFCyJ67kWibhqvRCJqRjbPlOscxylyei5hG+ddJJYngh
 bVPH6kNtf8w0/CU7pqavi78vcsr8sGI7ayVjP+rSsciYK0qR9s+CHbfT/0L1WGssx4FnQPUAN
 Mu/cizYp+8FY5qWwcK06y4sGeutiPxwAUG9DR0cQS/bHUYNTAAAMX5N6kQI93ckuR6r4g9QE1
 Uyp2fkOnaSAhTpQymtfqv6M3LEQaASspMEG6rC81XBz1V7pypm2nlgE0DvccPVfURCyOwumLq
 LEveRUL/+Z2XtD4Cjf9yB+UB8/fxLkKCHWy633eaDRgWgbloTpOskTnw2Mgh/FVLvFcCuy2ti
 2jhq9jTWTCML2lTRFWPevvdmOxMwr95OUHwUGkP/VMztNdVrwZe4AVMV+JXnHtt0yMZ6LBIMG
 WO0wlk7Xv8KhLylz+G8pphyCXJGKgot769BQBEV0139ijhV7OEGsccyT4s4y22f6Kd8z6zWx6
 K+zBua0IsI1XHP0rV8MWNhdfUUjtutwb0h0klVtRXWAq+p4gURyJupfOfMxN83bnBTzNWAEyp
 SDlOjSl2x+Bo8SUOw0GIzOf1ww6HpVyafDKKf0PKExOrtyCnSGTHmcJZDjKVY1ndy23YzuwhJ
 UvzcxnF+gBzYIyEkr/R9531wUVjiOBlfqlUjxWWN0pEHE=

> Make sure we turn off the clock on probe failure and device removal.
=E2=80=A6
> +++ b/drivers/pci/controller/pcie-xilinx-nwl.c
=E2=80=A6
> @@ -817,11 +818,23 @@ static int nwl_pcie_probe(struct platform_device *=
pdev)
>  		err =3D nwl_pcie_enable_msi(pcie);
>  		if (err < 0) {
>  			dev_err(dev, "failed to enable MSI support: %d\n", err);
> -			return err;
> +			goto err_clk;
>  		}
>  	}
>
> -	return pci_host_probe(bridge);
> +	err =3D pci_host_probe(bridge);
> +
> +err_clk:
> +	if (err)
> +		clk_disable_unprepare(pcie->clk);

I suggest to use the label =E2=80=9Cdisable_unprepare_clock=E2=80=9D direc=
tly before this function call
(in the if branch) so that a duplicate check would be avoided after some e=
rror cases.

Regards,
Markus