Received-SPF: pass (google.com: domain of linux-kernel+bounces-187976-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 23 May 2024 16:36:20 -0400
From: Frank Li <Frank.li@nxp.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com,
	sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, marex@denx.de,
	linux-clk@vger.kernel.org, imx@lists.linux.dev,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
	shengjiu.wang@gmail.com
Subject: Re: [PATCH v5 2/5] clk: imx: clk-audiomix: Add reset controller
Message-ID: <Zk+oxAh9+c0RIQ/t@lizhi-Precision-Tower-5810>
References: <1716458390-20120-1-git-send-email-shengjiu.wang@nxp.com>
 <1716458390-20120-3-git-send-email-shengjiu.wang@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1716458390-20120-3-git-send-email-shengjiu.wang@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?szODnEkJ1USazeIDiUV8n5U4lz2gCrgOo2XH03s2VVLqlJ1O8OGX1clrvGID?=
 =?us-ascii?Q?SAnOa64BqPckLdG0QO1Odb+1SVa/lurhSac0o+t3m62uwqxX11OtrxdLIktB?=
 =?us-ascii?Q?iBwxElVyU9VxMkkcnoX4xm4jTeVFDbZXTPcX0NNl/XYcn2SJms8H2YG3/GYN?=
 =?us-ascii?Q?6zhJuD+iSX40ppA5XOKzmm2kryGNSv/s3p/y8aYDNNu/k6/k2ZxhlcDlh8iu?=
 =?us-ascii?Q?6KksLabXuYhLzM6c4m4/XjrmvK2sT+TgVdqZfPGck2Qn3Mw4HYxeUFA6fH1J?=
 =?us-ascii?Q?werBOn31Izzw60vh3oU+Yvuj4sWrEhCKDNKSmHxMgVi1+3/l3NNs2yWqLZKh?=
 =?us-ascii?Q?RPSVqp/4E+hav5ocUrQ04i59ior5fH4RZHckGkUWN8OWVNEHWOKSdDQufkTN?=
 =?us-ascii?Q?qpbb4WbZFQ1QGQc2HMbQZkujpVwMn4JAfQvTwHgZcu2P0pJVQdF5Exb0cGbQ?=
 =?us-ascii?Q?SdPJQzocvwQoAdgdmpCGgdi5v2X/jO41NDzeZfeR/7xaePUZ7ErdrZR56/qr?=
 =?us-ascii?Q?C3hRuUS1agIr+a4qVBr+8FKWBYubUjMxI5Oy7fiIcNaoRk8AThmYeZk84Rnm?=
 =?us-ascii?Q?hFaCeC4dcNDX34JAIKNHx0czTHcnEFUdnTmWI5KeGC12JzhHuMV1XsTsqCgf?=
 =?us-ascii?Q?2a7jmlJEn8N20C3D2m4ayqvanilr0ioFf+yTX86oqtuxdaA7H1AVL6NTWMw7?=
 =?us-ascii?Q?h/VNUAX3plHyDjQvFiyaNx+TJXDNt3oLW9tJo0eRJfb+VeGVcfiz1AJe4sID?=
 =?us-ascii?Q?HFxtfQbFaVZdwBfQv4jYUDFhIg7gZnIos/m2qE2O7qqk4KuJsvxkW4++RRnC?=
 =?us-ascii?Q?W6e5n8jSiDEaNQaEcKZ8zi1uBmPwlXs/muq0jabZ1ASFPL0Wc8GOCQvECnOu?=
 =?us-ascii?Q?yrA8ZdluUjChgghTcb35qZg4HuT+nxSgyEnvZhan9kyssnt2CEvSDaTWcXse?=
 =?us-ascii?Q?Efl6RuDlRVF1CV4zm2+KUUH6AoNedx3cXHVl1tk476KzTZEBiixYj/gTHts6?=
 =?us-ascii?Q?Qc5gc8IOAqGiXT0fxANJmc0ysUup37/87B8elo9duRXvxWMK1WGTcFMGvIfT?=
 =?us-ascii?Q?rlBwsfcC3g0NXRZiOJ3KVH4NerIelJeoexF7pr4hV0x/S6gnwdINVkGY7j/R?=
 =?us-ascii?Q?IB93kzBAwMexTlGm2vgQB1STfVjir0W+RKAUFNxrXNSLX4wTWT2iaB+b0ZJw?=
 =?us-ascii?Q?TmaKGTVddXzREWKTwXxw093OCeszlp1KaR2C7v23kVM1SOBaZ+4uhPzkStsj?=
 =?us-ascii?Q?Q7k8FEgl3zj1ACUeEPxhiiUiw9OaFsUIlXA3wtBkLEhUSOQMkoaWgSuMg/nF?=
 =?us-ascii?Q?Pl6Ct5G0YLrNctaJ88flXx/J2txi4Mtv8yjlq5fYwZ5RtbhfXDlQaIvZPcw/?=
 =?us-ascii?Q?ffHeDgVXZTy3FQUrqfnMgTV2+oIX76bh+wGbRvAdQWr76qyX0H/ro8zNZV+4?=
 =?us-ascii?Q?SKcYREkYjri8WNYHBm4obHaqxNj9CJ1eljnBbsLo8lpvaUVnLYDrcQN9Zc0D?=
 =?us-ascii?Q?iAErGEyQYkNUYlBIpsqNJ1A6Twn1LHI5WDfx/zj27xrRpUqiS7t6sUDPh+XS?=
 =?us-ascii?Q?bOpRsYzdJ4xGQsWTh0o=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b9a07cd-e3af-49ca-82be-08dc7b680773
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 20:36:31.3061
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bTY6LAPZf+hSakjhmhlmu8bv4BF3M5a+OYgxmTnqrwqxR7BMfONht6tACwqnBLQYMJBgpNbaOLysxca/9kafEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9785

On Thu, May 23, 2024 at 05:59:47PM +0800, Shengjiu Wang wrote:
> Audiomix block control can be a reset controller for
> Enhanced Audio Return Channel (EARC), which is one of
> modules in this audiomix subsystem.
> 
> The reset controller is supported by the auxiliary device
> framework.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  drivers/clk/imx/Kconfig               |  1 +
>  drivers/clk/imx/clk-imx8mp-audiomix.c | 60 +++++++++++++++++++++++++++
>  2 files changed, 61 insertions(+)
> 
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index 6da0fba68225..9edfb030bea9 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -81,6 +81,7 @@ config CLK_IMX8MP
>  	tristate "IMX8MP CCM Clock Driver"
>  	depends on ARCH_MXC || COMPILE_TEST
>  	select MXC_CLK
> +	select AUXILIARY_BUS
>  	help
>  	    Build the driver for i.MX8MP CCM Clock Driver
>  
> diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c
> index b381d6f784c8..2ee68f518850 100644
> --- a/drivers/clk/imx/clk-imx8mp-audiomix.c
> +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
> @@ -5,6 +5,7 @@
>   * Copyright (C) 2022 Marek Vasut <marex@denx.de>
>   */
>  
> +#include <linux/auxiliary_bus.h>
>  #include <linux/clk-provider.h>
>  #include <linux/device.h>
>  #include <linux/io.h>
> @@ -13,6 +14,7 @@
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/slab.h>
>  
>  #include <dt-bindings/clock/imx8mp-clock.h>
>  
> @@ -217,6 +219,60 @@ struct clk_imx8mp_audiomix_priv {
>  	struct clk_hw_onecell_data clk_data;
>  };
>  
> +#if IS_ENABLED(CONFIG_RESET_CONTROLLER)
> +
> +static void clk_imx8mp_audiomix_reset_unregister_adev(void *_adev)
> +{
> +	struct auxiliary_device *adev = _adev;
> +
> +	auxiliary_device_delete(adev);
> +	auxiliary_device_uninit(adev);
> +}
> +
> +static void clk_imx8mp_audiomix_reset_adev_release(struct device *dev)
> +{
> +	struct auxiliary_device *adev = to_auxiliary_dev(dev);
> +
> +	kfree(adev);
> +}
> +
> +static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev,
> +							 struct clk_imx8mp_audiomix_priv *priv)
> +{
> +	struct auxiliary_device __free(kfree) * adev = NULL;

nit:  *adev = NULL;

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> +	int ret;
> +
> +	adev = kzalloc(sizeof(*adev), GFP_KERNEL);
> +	if (!adev)
> +		return -ENOMEM;
> +
> +	adev->name = "reset";
> +	adev->dev.parent = dev;
> +	adev->dev.release = clk_imx8mp_audiomix_reset_adev_release;
> +
> +	ret = auxiliary_device_init(adev);
> +	if (ret)
> +		return ret;
> +
> +	ret = auxiliary_device_add(adev);
> +	if (ret) {
> +		auxiliary_device_uninit(adev);
> +		return ret;
> +	}
> +
> +	return devm_add_action_or_reset(dev, clk_imx8mp_audiomix_reset_unregister_adev,
> +					no_free_ptr(adev));
> +}
> +
> +#else /* !CONFIG_RESET_CONTROLLER */
> +
> +static int clk_imx8mp_audiomix_reset_controller_register(struct clk_imx8mp_audiomix_priv *priv)
> +{
> +	return 0;
> +}
> +
> +#endif /* !CONFIG_RESET_CONTROLLER */
> +
>  static void clk_imx8mp_audiomix_save_restore(struct device *dev, bool save)
>  {
>  	struct clk_imx8mp_audiomix_priv *priv = dev_get_drvdata(dev);
> @@ -337,6 +393,10 @@ static int clk_imx8mp_audiomix_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_clk_register;
>  
> +	ret = clk_imx8mp_audiomix_reset_controller_register(dev, priv);
> +	if (ret)
> +		goto err_clk_register;
> +
>  	pm_runtime_put_sync(dev);
>  	return 0;
>  
> -- 
> 2.34.1
>