Received-SPF: pass (google.com: domain of linux-kernel+bounces-187997-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 24 May 2024 05:57:17 +0900
From: asmadeus@codewreck.org
To: David Howells <dhowells@redhat.com>
Cc: syzbot <syzbot+d7c7a495a5e466c031b6@syzkaller.appspotmail.com>,
	brauner@kernel.org, hdanton@sina.com, linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [v9fs?] KASAN: slab-use-after-free Read in
 p9_fid_destroy
Message-ID: <Zk-trSrUlNmodxLx@codewreck.org>
References: <Zk9y21FktxyLGqDJ@codewreck.org>
 <00000000000092914806191382ac@google.com>
 <580959.1716475058@warthog.procyon.org.uk>
 <641239.1716487625@warthog.procyon.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <641239.1716487625@warthog.procyon.org.uk>

David Howells wrote on Thu, May 23, 2024 at 07:07:05PM +0100:
> asmadeus@codewreck.org wrote:
> 
> > > There's a problem in 9p's interaction with netfslib whereby a crash occurs
> > > because the 9p_fid structs get forcibly destroyed during client teardown
> > > (without paying attention to their refcounts) before netfslib has finished
> > > with them.  However, it's not a simple case of deferring the clunking that
> > > p9_fid_put() does as that requires the client.
> > 
> > "as that requires the client" doesn't parse
> 
> "... as that requires the p9_client record to still be present."?

Ah! yes, that works.
'as that uses/depends on the client' would also work.

Thanks,
-- 
Dominique Martinet | Asmadeus