Received-SPF: pass (google.com: domain of linux-kernel+bounces-188046-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Subject: Re: [PATCH 4/4] cxl/pci: Define a common function get_cxl_dev()
To: Dave Jiang <dave.jiang@intel.com>, linux-efi@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
 Alison Schofield <alison.schofield@intel.com>,
 Vishal Verma <vishal.l.verma@intel.com>, Ira Weiny <ira.weiny@intel.com>,
 Dan Williams <dan.j.williams@intel.com>,
 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
 Yazen Ghannam <yazen.ghannam@amd.com>, Bowman Terry <terry.bowman@amd.com>
References: <20240522150839.27578-1-Smita.KoralahalliChannabasappa@amd.com>
 <20240522150839.27578-5-Smita.KoralahalliChannabasappa@amd.com>
 <dd0f3183-e10b-4a3d-98b6-c6963dc86512@intel.com>
From: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Message-ID: <07d6242c-b6fd-f651-3c72-e3fe26eddbe5@amd.com>
Date: Thu, 23 May 2024 14:37:33 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
In-Reply-To: <dd0f3183-e10b-4a3d-98b6-c6963dc86512@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M0J4ZFhjTFN6WEVGekdRNk1jdXpwc1c1VEptN2VOR1dRTjFuUzNRaFd4ZXpE?=
 =?utf-8?B?bG01N0F0QlJXR2ZmNStUTCtyZGgzd25MeHg2bjlnTUtCMjlpZmFUNXZMSFV3?=
 =?utf-8?B?c0Z4UjZLZkcycEpMdk5LWE5BdTVzNnozK1JpM3FqTGdYVUtFUHJWbHQ3TVNr?=
 =?utf-8?B?OTVXZ1JoWjhqVlQ3aFUwbmQxdUxkTGppR3RBZ2t1WFp4SDRkcEVEL0NQajRD?=
 =?utf-8?B?bFdSUzBDNS9waEV0YTFWSStzSS8vL1pCcVVmMG9CME8wU2JWaUh1UUZmc3RR?=
 =?utf-8?B?MC9ZaWxMU2JEZlZrUFZibE1hRzNpNmprWnhIV2pmT24zQnJPaEs3UmNFNmdj?=
 =?utf-8?B?dzBQazB2VkJiRzZVOGpuUWhkSC9DZnRYcElYK1dHbjdmUFVPSGx4WjNtRVR6?=
 =?utf-8?B?ejNnVHV1cGg5VXlKZ1pFM0pEYTJOd2I1V2wreEVCMXUyTU5DZU5DYXdRcEYx?=
 =?utf-8?B?clJKTlBLSHVtNkttcnJEOFFQZFlNVU1HYVNtakt4THBURWhTdGw5VjNDVlo0?=
 =?utf-8?B?eldFSmV1ZHJaUzdBMVJLMERCVnBhVUVrRVNKbG94R1Y1eFNhcmMza0pETnFS?=
 =?utf-8?B?eWJwMkJaSzV2bXA1ZmRwdjVxOG5GTWNtdkh6V1ZoSXkrSUkxL3ppTzN3WEVG?=
 =?utf-8?B?MlYwUzMxaWh4ZVpjc0ZBVWlQWFlOOW9qSWNQejQ2OUxiWERjOHcwT3h6Uk55?=
 =?utf-8?B?aFhEYy9wUm1WOW5kQ01VcHR1SFlIK2h5ajFEeC81NlE1ekxlSU5VdVpReFl3?=
 =?utf-8?B?YU9kdURVZGxvaEdSODA5S3Iwb2h0OFlSWU5FT3puRGFPNUM2OE05cTJqaS9r?=
 =?utf-8?B?ekxiTzE5Q0lXUGY0R3NmVXNqVWpKRDNrY2d2SlBINGNtOGtpS21ld1VncGRP?=
 =?utf-8?B?aU5qNGR6VDJRb3k3akMxUDNTZUhWQk5sZzgxZEZPWWlHbU9PNGU1ZlRDak4v?=
 =?utf-8?B?Tmkzd0NZOW1WaUxKanVVcW01SW54L0tGNHBIYXlQTTBoQmlJNkJlVFFxNW9x?=
 =?utf-8?B?VHAwNGNZZEJzZXF6ZWhsOWlNSjhvVHh5M0N2RVBKRVppeWJvRFF0eE5wVHVW?=
 =?utf-8?B?UjlPMFhFMDRZRzFlRXVnZmFzSTZFeCtRUFlrdS9MR05vNmZmUkw0Vm9Cd1Ns?=
 =?utf-8?B?WkFaZFZENTgyMFdnYWdBODl5Q2V4eDYvSVdUc2tWc0dVSHNjVGRnTVR5Z2Ry?=
 =?utf-8?B?L1Zuc0tBYTdiT0dhZXRyV21jbGRkV1RCaHR0MHQ3aEZNNFJUSmN5NFIyQVdm?=
 =?utf-8?B?K3hKRDVjdG52QnVTUzFSRXNYb1F5U2MwVFNYWDM0YWpubVk1Tnk4dStjUC8y?=
 =?utf-8?B?dURkeU5lMmhvMzg4bFlYUm8yOXJ0Uk1qd2hWZ21WVlAvd1JaOGl1aTZ0SnJJ?=
 =?utf-8?B?UUpUaG9NYTJXVnd2R2Y4MGhoem1KaHRqaDZUcGxqQkZoYjdqRytCNEdlWU9o?=
 =?utf-8?B?WHRJOTIyNVkxRnpOTlMvN3pnS2FIdStQaHo3ZzhZamwvaE0xSFo3TG1rcVFU?=
 =?utf-8?B?cXI1U0gycTdETGp6SkdKNCtSN1RaVDVsWFkrOVlWZE1ia1AyTklaNFhRb2FG?=
 =?utf-8?B?UTdhYndsSDZ5TDRpcXpjdWxPTHRPNi9ESzE5WjhSWUs4S1ZDVkRIWnZSQXpH?=
 =?utf-8?B?SlF5clBwNDFTYTVkdzZRa0xEWXBUNEZzYWlrWnJqcTgxSG9GeXRNU1JYU1hl?=
 =?utf-8?B?VjErZmZER0F1Mm9WQXllMG5sbG9vSzFkaHpEeGUwRjhrckhkbXJJTVRDQ2NC?=
 =?utf-8?B?WXpycW5haFBmVHZSbUhMNDhTOUxyV1RJeUhyNllkdkpEd3pOUXQvRklYcmlM?=
 =?utf-8?B?cGxwSUlNVzFWUGlvdjJvSngxMkd3QmR6bWZ6cllUUEl1MmZTamlhaVFrZk1Y?=
 =?utf-8?B?VkJqRUFzZlVQNzhld3JpaEpPVVAxMUo0UTdZejI3YVdnbUc3cTltMjY3M0pt?=
 =?utf-8?B?am5TUDZJL21iWjR4RDdVRVl3V0h0SG51WmprRGE3UU9Bcll5SFp3NE5JdHVq?=
 =?utf-8?B?Y3VtV2FGUFRCZHVIVWI2UVg4WlVkd3lucWhiVGVwTzdlc1ROd05YSGNmQ0Rz?=
 =?utf-8?B?N1NXNkRuWXlkMytpRGh2TkVSeHNXM1pNL2FTdHNSOXBYdHROcjJpWU1nTHJO?=
 =?utf-8?Q?peIB45FfiZ3ME4ozccBjIy4Uo?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c75da61-b282-4c72-5d89-08dc7b708ee8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 21:37:34.5107
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fKVFE3v0j62y+7zhjMKIL7w14O3P0HdBft6G6tlmscUFHPqXNJtBjZvQ80Kb8NpO8Nmh08XOyQdpNda4oWtP0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6856

On 5/22/2024 12:42 PM, Dave Jiang wrote:
> 
> 
> On 5/22/24 8:08 AM, Smita Koralahalli wrote:
>> Refactor computation of cxlds to a common function get_cxl_dev() and reuse
>> the function in both cxl_handle_cper_event() and cxl_handle_prot_err().
> 
> I think just introduce the function where you open coded it instead of adding code and then deleting them in the same series.

Okay refactor first, then add trace support. Will change.

>>
>> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
>> ---
>>   drivers/cxl/pci.c | 52 +++++++++++++++++++++++------------------------
>>   1 file changed, 26 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
>> index 3e3c36983686..26e65e5b68cb 100644
>> --- a/drivers/cxl/pci.c
>> +++ b/drivers/cxl/pci.c
>> @@ -974,32 +974,43 @@ static struct pci_driver cxl_pci_driver = {
>>   	},
>>   };
>>   
>> +static struct cxl_dev_state *get_cxl_dev(u16 segment, u8 bus, u8 device,
>> +					 u8 function)
> 
> get_cxlds() or get_cxl_device_state() would be better.

Okay will change
> 
> DJ
> 

Thanks
Smita

>> +{
>> +	struct pci_dev *pdev __free(pci_dev_put) = NULL;
>> +	struct cxl_dev_state *cxlds;
>> +	unsigned int devfn;
>> +
>> +	devfn = PCI_DEVFN(device, function);
>> +	pdev = pci_get_domain_bus_and_slot(segment, bus, devfn);
>> +
>> +	if (!pdev)
>> +		return NULL;
>> +
>> +	guard(device)(&pdev->dev);
>> +	if (pdev->driver != &cxl_pci_driver)
>> +		return NULL;
>> +
>> +	cxlds = pci_get_drvdata(pdev);
>> +
>> +	return cxlds;
>> +}
>> +
>>   #define CXL_EVENT_HDR_FLAGS_REC_SEVERITY GENMASK(1, 0)
>>   static void cxl_handle_cper_event(enum cxl_event_type ev_type,
>>   				  struct cxl_cper_event_rec *rec)
>>   {
>>   	struct cper_cxl_event_devid *device_id = &rec->hdr.device_id;
>> -	struct pci_dev *pdev __free(pci_dev_put) = NULL;
>>   	enum cxl_event_log_type log_type;
>>   	struct cxl_dev_state *cxlds;
>> -	unsigned int devfn;
>>   	u32 hdr_flags;
>>   
>>   	pr_debug("CPER event %d for device %u:%u:%u.%u\n", ev_type,
>>   		 device_id->segment_num, device_id->bus_num,
>>   		 device_id->device_num, device_id->func_num);
>>   
>> -	devfn = PCI_DEVFN(device_id->device_num, device_id->func_num);
>> -	pdev = pci_get_domain_bus_and_slot(device_id->segment_num,
>> -					   device_id->bus_num, devfn);
>> -	if (!pdev)
>> -		return;
>> -
>> -	guard(device)(&pdev->dev);
>> -	if (pdev->driver != &cxl_pci_driver)
>> -		return;
>> -
>> -	cxlds = pci_get_drvdata(pdev);
>> +	cxlds = get_cxl_dev(device_id->segment_num, device_id->bus_num,
>> +			    device_id->device_num, device_id->func_num);
>>   	if (!cxlds)
>>   		return;
>>   
>> @@ -1013,21 +1024,10 @@ static void cxl_handle_cper_event(enum cxl_event_type ev_type,
>>   
>>   static void cxl_handle_prot_err(struct cxl_cper_prot_err *p_err)
>>   {
>> -	struct pci_dev *pdev __free(pci_dev_put) = NULL;
>>   	struct cxl_dev_state *cxlds;
>> -	unsigned int devfn;
>>   
>> -	devfn = PCI_DEVFN(p_err->device, p_err->function);
>> -	pdev = pci_get_domain_bus_and_slot(p_err->segment,
>> -					   p_err->bus, devfn);
>> -	if (!pdev)
>> -		return;
>> -
>> -	guard(device)(&pdev->dev);
>> -	if (pdev->driver != &cxl_pci_driver)
>> -		return;
>> -
>> -	cxlds = pci_get_drvdata(pdev);
>> +	cxlds = get_cxl_dev(p_err->segment, p_err->bus,
>> +			    p_err->device, p_err->function);
>>   	if (!cxlds)
>>   		return;
>>