Received-SPF: pass (google.com: domain of linux-kernel+bounces-188044-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Subject: Re: [PATCH 3/4] acpi/ghes, cxl/pci: Trace FW-First CXL Protocol
 Errors
To: Alison Schofield <alison.schofield@intel.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-cxl@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
 Vishal Verma <vishal.l.verma@intel.com>, Ira Weiny <ira.weiny@intel.com>,
 Dan Williams <dan.j.williams@intel.com>,
 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
 Yazen Ghannam <yazen.ghannam@amd.com>, Bowman Terry <terry.bowman@amd.com>
References: <20240522150839.27578-1-Smita.KoralahalliChannabasappa@amd.com>
 <20240522150839.27578-4-Smita.KoralahalliChannabasappa@amd.com>
 <Zk6MWMYUg77HxbVr@aschofie-mobl2>
From: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Message-ID: <34fe7471-d17e-b802-f9cc-a83ad23ef409@amd.com>
Date: Thu, 23 May 2024 14:35:51 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
In-Reply-To: <Zk6MWMYUg77HxbVr@aschofie-mobl2>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SDhtYklUVEJIME0vME8xK3creEh4ekw5VWwwbXFyVWY2a2cxeVBhSWZmZ0RP?=
 =?utf-8?B?ZHViZEN2emtkRjlsRGNEWFE3UjNpNHNpdDNFMllWNmdXWmY1RldJdGFOVzFj?=
 =?utf-8?B?MGd5eGNXTmZIVnRoZ3BJOEVva2VZT25RYUQ3RTBydjJFcnE0bWZxUGpzVU5F?=
 =?utf-8?B?Nzc3WTQ5YURiaTJYQzZESnQxMFVlR2hwd20yaWEvNVFJd09VQmtOU29pdEVD?=
 =?utf-8?B?ajVJNHV4QXVNaHJvSmFsUm90VEFkaTI1SnY2Mzl5S1VVaTRHeHkxeHlZRDdB?=
 =?utf-8?B?T3FvZlNsYjVVTHFNV3g5TzlFVW9xQlRBSXJRemIyOUhBckxVbThJd3dWWkJz?=
 =?utf-8?B?bGsxMTRTZjlzdzFPU1FycGhkNCtkZ1ZLZ0RrVHdTTE9qV3BuQmVudzZYQlBY?=
 =?utf-8?B?U1BsTE5UaXFoRkp3ekdzY3liK1pxSW1JZEgycFNvdmVub1RkYUxvSVRjNUJ6?=
 =?utf-8?B?d0ZnM2ljOWx4RFpWdHhrMExXeUg5dW1jdklBRFZLQ1NSelJnaG8xdVVUbXdE?=
 =?utf-8?B?bHpwMVdWN0w2b2ZRVjdrblMrTEFvcjhoem91L09MZklVNmc0Q241MFRYTjJy?=
 =?utf-8?B?TTRoS3Vsd0dWL1B5a3JnbUpWMjczSExYYThhTmxuT3dUMm4xQW9nYlJqbTh5?=
 =?utf-8?B?M1I2bTNxNkNCNWxkUUdjb0FuTytNNHl2dVJlY0pVQjhtSGNqSFJ5cU9vaTRN?=
 =?utf-8?B?U2FKWGlOWXJZTGpoYWtDTDRXVGhXaTlPajRXeGpBT0ZhMHFtcUtHK24rdk1N?=
 =?utf-8?B?RG1tOWVyODNXdUZac0J1N2lmOFV4R2ptWTNzbEdGZDdyenVLekJQa09zMXcx?=
 =?utf-8?B?dlN3NXhzZk93YjJaMzZIa2lDaEFIMWFYWkxkY1ZIZjZlZ0x2aURKYXFiOW0r?=
 =?utf-8?B?N2lUSmhVc1dqQjhPeWp4K3pFT3ViVWVyN2hyTDByQ2o0Znp6ZzlwSVJpbGt1?=
 =?utf-8?B?QUtpOWIramRzaFhqWTk3bGxHWWlIMHBROHZKd1hLTHlWTzJoRjhwOFJxTktV?=
 =?utf-8?B?a2ZqNldKWW8vS0N6dDNOTHV6dlJwOW1zYUVMNlYyMzRJU1FtcUlvWjRjZXc4?=
 =?utf-8?B?SitZK2FxcDZFWTN4cmhkTEkwK0hJVHcrbkgrNXU0bVlSRjc3MXlJcklleHVH?=
 =?utf-8?B?VmRaNHdrWE5ZaThQNW02RjhIUmRtenFZeDNxRE9iOVVNZFBhT1lQcWV5enVy?=
 =?utf-8?B?RVFvKy9aOXVKR3REYXdXN2JCUFBiYnM1OTBsK1pwSi9URmJTMkhOanNQU1Q1?=
 =?utf-8?B?Qlp2VHVueC8zb0hlVzVsZW1MU0xrdFFEdW1mQ3M1UXFzN1B5M2ZxOUJCZFFM?=
 =?utf-8?B?ckdwTVFvK1MwSUdlalo1TFBWQnA5WXdZdXlqWHlEV00xTVVtbmYvd3JqUWVl?=
 =?utf-8?B?RHpiaTN3VkdnM0IzWUFxQTE4UHZjckdGY3BjYWZFamhGY3ZSak8zaDlTYXZT?=
 =?utf-8?B?MWdBN0ZjT1FoOTBTdEIzaWYrR0JSRVhSODVBeTRFU00yZGJZaThBTXY2dWlY?=
 =?utf-8?B?SWg2MmtqeHd0Y1RHVElLMUdRUlJqaG1hNkMwL1UzbjFPNVZEUTN0TjZZMi8v?=
 =?utf-8?B?L2N1Qkdxdi91cG5wd0dnUmQrMHpIdFJVaUxUakQ1enhmTTdVcEg1NWtPWmV5?=
 =?utf-8?B?RnVQN1Q4V2tOTld0MndDTGpyS0lZeGZ5MEhGdWF2QUtPZU9EdmQxTUdZSXR4?=
 =?utf-8?B?ekx5a01lVTROZW9wL202bnpVNWtqamF2MW9JSFVHU2hZOXJ6KzVUeUg0c2I4?=
 =?utf-8?B?Q3JDYkg1SmNucmg2QUhBZkNlWXM2L1RwM2gweHB0TjV5N2NoN2EwNEJUZTJk?=
 =?utf-8?B?ZXkwRDFKQXZPZ0RIN0JOczB5QVdWemIxdWhkRUR0d0ZEVjJBQ3ZhdUNVVyty?=
 =?utf-8?B?QVpmWlFqaUozOGEyNks5U3NPcHlMT1BQdnYxWnM1SGtzbUtzdVdYaEtOcHJV?=
 =?utf-8?B?S2pUTHpieFF6L09TRkcxWWFBbThUWFN3U3BCOWE5QkJJek9saHM3c0pJMEZI?=
 =?utf-8?B?YjVGemhCWm80T0tiYUFvcmZkRjJkNlBETXhPQlZodlRjS0xnVWpVMStnMDda?=
 =?utf-8?B?RkQrQ2NKT05NTnladEFoMFFBMEd5UytBdjljV3VTTmhjc3RTY0JRUi9Md3hM?=
 =?utf-8?Q?dQ/pTtXhqVHRiTEGFJgIzCgnq?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b471c22b-ce89-4da9-b69c-08dc7b7052a5
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 21:35:53.3922
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JUUkcr30miH15wsSsGkVy4xmBXxDLfdC5cBWDy8otQmSeEdpsiDwwKrpQTmbcfiPLEbwAooV8mMg6s52CTsFmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6856

On 5/22/2024 5:22 PM, Alison Schofield wrote:
> On Wed, May 22, 2024 at 03:08:38PM +0000, Smita Koralahalli wrote:
>> When PCIe AER is in FW-First, OS should process CXL Protocol errors from
>> CPER records.
>>
>> Reuse the existing work queue cxl_cper_work registered with GHES to notify
>> the CXL subsystem on a Protocol error.
>>
>> The defined trace events cxl_aer_uncorrectable_error and
>> cxl_aer_correctable_error currently trace native CXL AER errors. Reuse
>> them to trace FW-First Protocol Errors.
> 
> Will the trace log differentiate between errors reported in FW-First
> versus Native mode?  Wondering if that bit of info needs to be logged
> or is discoverable elsewhere.

No, the trace log won't differentiate currently.

But just a side note, FW-First also logs errors in dmesg. I'm not sure 
if going forward, we would still continue to log errors in dmesg. But I 
feel it might be needed so that we don't miss errors from RCH Downstream 
Port or hexdump of unrecognized agent types.

Thanks
Smita

> 
> Otherwise, LGTM,
> Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> 
> 
>>
>> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
>> ---
>>   drivers/acpi/apei/ghes.c  | 14 ++++++++++++++
>>   drivers/cxl/core/pci.c    | 24 ++++++++++++++++++++++++
>>   drivers/cxl/cxlpci.h      |  3 +++
>>   drivers/cxl/pci.c         | 34 ++++++++++++++++++++++++++++++++--
>>   include/linux/cxl-event.h |  1 +
>>   5 files changed, 74 insertions(+), 2 deletions(-)
> 
> snip
> 
>