Received-SPF: pass (google.com: domain of linux-kernel+bounces-188084-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <cdeb291d-0b8f-4c82-be1f-77d5708af685@acm.org>
Date: Thu, 23 May 2024 15:43:10 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ufs:mcq:Fixing Error Output for ufshcd_try_to_abort_task
 in ufshcd_mcq_abort
To: Chanwoo Lee <cw9316.lee@samsung.com>, alim.akhtar@samsung.com,
 avri.altman@wdc.com, James.Bottomley@HansenPartnership.com,
 martin.petersen@oracle.com, stanley.chu@mediatek.com,
 quic_nguyenb@quicinc.com, quic_cang@quicinc.com, powen.kao@mediatek.com,
 yang.lee@linux.alibaba.com, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <CGME20240523002322epcas1p2a63dfc646a2b2dd8fcadad2a8807bcee@epcas1p2.samsung.com>
 <20240523002257.1068373-1-cw9316.lee@samsung.com>
Content-Language: en-US
From: Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20240523002257.1068373-1-cw9316.lee@samsung.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/22/24 17:22, Chanwoo Lee wrote:
> An error unrelated to ufshcd_try_to_abort_task is being output and
> can cause confusion. So, I modified it to output the result of abort
> fail. This modification was similarly revised by referring to the
> ufshcd_abort function.
> 
> Signed-off-by: Chanwoo Lee <cw9316.lee@samsung.com>
> ---
>   drivers/ufs/core/ufs-mcq.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index 005d63ab1f44..fc24d1af1fe8 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -667,9 +667,11 @@ int ufshcd_mcq_abort(struct scsi_cmnd *cmd)
>   	 * in the completion queue either. Query the device to see if
>   	 * the command is being processed in the device.
>   	 */
> -	if (ufshcd_try_to_abort_task(hba, tag)) {
> +	err = ufshcd_try_to_abort_task(hba, tag);
> +	if (err) {
>   		dev_err(hba->dev, "%s: device abort failed %d\n", __func__, err);
>   		lrbp->req_abort_skip = true;
> +		err = FAILED;
>   		goto out;
>   	}

Why does the word "Fixing" occur in the title of this patch? I think
that this patch does not affect the value returned by
ufshcd_mcq_abort(). From the start of that function:

	int err = FAILED;

Thanks,

Bart.