Received-SPF: pass (google.com: domain of linux-kernel+bounces-188085-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <c77f3931-31b2-4695-bd74-c69cba9b96c1@intel.com>
Date: Fri, 24 May 2024 10:47:12 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into
 kvm_arch_vcpu_load()
To: Sean Christopherson <seanjc@google.com>, Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>, Tianrui Zhao
	<zhaotianrui@loongson.cn>, Bibo Mao <maobibo@loongson.cn>, Huacai Chen
	<chenhuacai@kernel.org>, Michael Ellerman <mpe@ellerman.id.au>, Anup Patel
	<anup@brainfault.org>, Paul Walmsley <paul.walmsley@sifive.com>, "Palmer
 Dabbelt" <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, "Christian
 Borntraeger" <borntraeger@linux.ibm.com>, Janosch Frank
	<frankja@linux.ibm.com>, Claudio Imbrenda <imbrenda@linux.ibm.com>, "Paolo
 Bonzini" <pbonzini@redhat.com>
CC: <linux-arm-kernel@lists.infradead.org>, <kvmarm@lists.linux.dev>,
	<kvm@vger.kernel.org>, <loongarch@lists.linux.dev>,
	<linux-mips@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
	<kvm-riscv@lists.infradead.org>, <linux-riscv@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
References: <20240522014013.1672962-1-seanjc@google.com>
 <20240522014013.1672962-4-seanjc@google.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240522014013.1672962-4-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkpWNjhydW9GT2N4ZjhKODhFcFFtcDNWMUUxM0pLSTdjSjZTOUc5YzR3UzNn?=
 =?utf-8?B?THNBZGxwbWlRRUx3LzRUNFlzMTJjQ0NRQ0RaMjhrR1E5aUpHZUVVMmxMRDBT?=
 =?utf-8?B?eHZRNU5SaWJ4WWs1alFkVjJZa1BWbTJuaUpmVFZkOVZ4RXowY0VwMlRVa3FF?=
 =?utf-8?B?Z2lQWXkrYm1kVldhRmhqNlZSekE0eFBWRFVrNlk3UEViVDNhSk5DMEZxd3l0?=
 =?utf-8?B?Yk1DODRpYkVycWJVVUEvbm5kYVEwTnByZ3hEYlZCTnFheitHWVhLYlV1b0Rp?=
 =?utf-8?B?TGg2UkZBOVBGUTFNSURKYkM1N0ZleU1IOXduMGNFcU1ueVB2RTFMSXFuaVFU?=
 =?utf-8?B?U2VPSkJhUzNGM25YWC9NL2Vwd0RwZEUyMElIQllDUDd1U1Z5eHg4Nzl4YjlG?=
 =?utf-8?B?OFd2aWxHVkhPQnhVdXlpVnBvcGFaMUM0bWxhSmE4RWhrM2kvRjBHYXRleHZk?=
 =?utf-8?B?N2E1V1hTUUR5VXQ4MFhrbUt2azR0bnlRMk44MElGZkxEdmxvTnUvNU4waEhJ?=
 =?utf-8?B?RDNVSFlQL2luRjNWdmdLcytpQUNwMlBNekRlckVzRmsyeDdueVVKM3lUS1k0?=
 =?utf-8?B?WkFVVDd6SVVEWVd5U01HbFJGWHVSaitJUU1HT3hrZ0hTYTZSa21sZTVKejJ0?=
 =?utf-8?B?NnNWSWI2Vk1hWm41a2I4bjl1VkRZZDVFYkZoNS93VHBzUVRuTGlwR1VVcm9O?=
 =?utf-8?B?Y0haV3c2QmlwcGZGQkhOS3hyYWpTNVZBTVVvTEp5OW45YzY1aTJNdmNoNzNP?=
 =?utf-8?B?czRqYTgwZ3l6SmZXbjJBNDZOckNkSjZ5em1NcUxmVWwzZzdkZ1R6a3F4dzhz?=
 =?utf-8?B?QVZKS21oOElTcnB3RmJJclBidzBjZGdiNHZWNTdyQkRDMmwxRURSUDA0YU0y?=
 =?utf-8?B?ZlZPK1kvaXRkS1lWRW5HK1NrUWpDS2tCTzU4RndPb2VjTkcvZVhVMTVwKzh2?=
 =?utf-8?B?VGpCQ0VMT0RnbFVFbC9UNlU3eFM1LzBtdU8xWEM4Ry93Nzk3M3FBK1ZjU0RS?=
 =?utf-8?B?bDBud1V1OWNOVkJEVDYvdzhCblhaZWFnell4OHZPMjVsbm5YeHpyenJaalVC?=
 =?utf-8?B?S0wrc05WMVZWWGJUOUJzWDdDMFlEeTRjN1JwbmhXaHlGbTBhMlZpVUNyYmF3?=
 =?utf-8?B?a1hpVlM5bTBwSUhPRHJaVHZ0VXVkdU9vOXlHcHpKWHB3ekQ3Zzk4SXNPSzI1?=
 =?utf-8?B?WldMeWQ3R2Q0WXd0emFkZmN6NDQyNlFCbzhlVTQ0eUZudk5wK2dhazA5ZFZX?=
 =?utf-8?B?bmh3djE5alBIL2haeUxDZDdWZ0tLUjdmTE9RbWxTQ2M0V2JycEdWLzk0MHd1?=
 =?utf-8?B?TnJ4ZDNma3lST0pZSDJCa1hHekdMWmFZSzZZcmY0dWNXUlgzR2MwdkxhVFV6?=
 =?utf-8?B?empTMGVLSGhjNXVHbzdCSHBBcUc2dERaK3l3dE9aVnFtUHM0K3dhS2pWdGV6?=
 =?utf-8?B?NHQ2WUdWWVc3Q3dObUM3QnlTbXpqVlhobVJUV3kzNTJXajRLdkF6UldtWHFO?=
 =?utf-8?B?QjAvclB1M09zcGhtUkxHK3AvSkxOd3BaRmxqUUpVNlJnM3hjcmQzeVNNTHVy?=
 =?utf-8?B?c2FpQmQzK3Q1YjZXQTVtWHF5VjJjSzhMY2laUzlZbWtHYVowem5XenNiZnBj?=
 =?utf-8?B?NHV0b0pGeVJIRFlUU3VXZUk4d0NyVGNmQWx5OFJZeVRLekE0WTZQM2o5cGM3?=
 =?utf-8?B?d1FHeFppcGlMUGxvUS96S2IycFlFNHJQWDJ1aHhLM1QraDA3NlRhOVRTREJW?=
 =?utf-8?B?Uk9qVVAyV1RTS2tiWktXSzg3YjlqVWpTWlZObXplNzNXdHMzWG1Ma3FCN21v?=
 =?utf-8?B?c2JWNVBvZERyVFFNbjFEcCtvV1JRMUM3SnRrUWpmMFBkc0lnT1Zqdk5TbUd3?=
 =?utf-8?B?RjhEUk5OSDN5V3FlenBFa1ViWi9QODFqazBIKzJHKzZPZzkxSHU3TnJ1WmNi?=
 =?utf-8?B?U081QTVnQXZmRGJ4MWNiRUwzOUtvanF3Z29kenpRUzg3VTl5dGp6cGlHc1M3?=
 =?utf-8?B?NDhicmljSHliWTQwb09aTm80VTZXaXA4RGhqUXJMaHFMRHZhckxqNitKaTAx?=
 =?utf-8?B?NXN4NzU5VVhKSS9IMDJtbnNYdzBHaEpna2tSSk9LS2x5dkhRbEp2Mi9EQjhn?=
 =?utf-8?Q?9Mg6rnPpvFZnsdZQT1+xHc3Hl?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 323e7688-f8fc-4479-febc-08dc7b7a506a
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 22:47:24.6903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CKq/xzMtXRRR/iXeOibK3SrYcknmMSVExmwpLWnLyClsQh1VOfSXjhPqhJRC7R4LNWiV2oigR+elATOOdpeJTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6885
X-OriginatorOrg: intel.com


On 22/05/2024 1:40 pm, Sean Christopherson wrote:
> Fold the guts of kvm_arch_sched_in() into kvm_arch_vcpu_load(), keying
> off the recently added kvm_vcpu.scheduled_out as appropriate.
> 
> Note, there is a very slight functional change, as PLE shrink updates will
> now happen after blasting WBINVD, but that is quite uninteresting as the
> two operations do not interact in any way.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---

Acked-by: Kai Huang <kai.huang@intel.com>

[...]

> @@ -1548,6 +1548,9 @@ static void svm_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
>   	struct vcpu_svm *svm = to_svm(vcpu);
>   	struct svm_cpu_data *sd = per_cpu_ptr(&svm_data, cpu);
>   
> +	if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm))
> +		shrink_ple_window(vcpu);
> +

[...]

> @@ -1517,6 +1517,9 @@ void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
>   {
>   	struct vcpu_vmx *vmx = to_vmx(vcpu);
>   
> +	if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm))
> +		shrink_ple_window(vcpu);
> +

Nit:  Perhaps we need a kvm_x86_ops::shrink_ple_window()?  :-)