Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp205124lqb; Thu, 23 May 2024 15:48:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUX8gGJJTfvNQl0GipxvGq6X42uFq5W/ANaEyN6AOnNy1/jOsZoWx3Z7eOL4AnLI3gI4UuvynTJrLJXpRs81H8aw90MPVgyzbHZ4Jdh7w== X-Google-Smtp-Source: AGHT+IG8PCeW+6vm8fgTarWupI4GcP/XC/XVEQ3dKWqqOH0wCv6PP0ewwzLcnT5zhoTdFQcwN/8O X-Received: by 2002:a17:90a:ead8:b0:2b2:ce88:c68c with SMTP id 98e67ed59e1d1-2bf5e170f1bmr521050a91.19.1716504539237; Thu, 23 May 2024 15:48:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716504539; cv=pass; d=google.com; s=arc-20160816; b=XisCvBgdrGoNyPKjYJtxjdE6XYjtfSM4KE03dmPFGBMZoeWd8JlaMHsWS9tVLAgMe+ Cr/o4x4hryMMd9RhTWv8w2ctAgzQpe+XdC++8/22gO9esW/1mJjdU1OZJfc3G75QO0HE eHGdJNU0XzJ6CbS4GYE2eloMLQj8pED7SxKRGUIhozwOib8rV3f6f6yqBZxGjTcoEb0f kLlQLW8IGycVU1KcSMecgeCDZ9rlgkwhTwGGA0vdnDELvpJNq4S9MeJ5rsm0GMHoml8m /zaPAtiZAlEHqkqdRbpCByUn+vwFWoTRYzmZ6xMpzD4UqXi9SZBt6oqES6CE4PwFBm+k tvOg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=TPr3aG1MtplD+AxrlL7bPoel3bwYFIv+2atj6R7Nirs=; fh=FKjs5HOUKASoLTW3zb8xEQ7EIVugvR8F3fnDDYclKUg=; b=VblXo8BwsT5waTE5N+p/I7CgqO4Bbi7cWyp9lEoJyc2iPKJ/rpeXTQWrPFoy2sNP3w h2bgn1ypya47xXaMqRdDqsuynxAxF+YeN/CG+Sp8COiQXXKW4O54gn0UAf3Ymxnh9n62 Xj4xYOFi/hrdECuXR+IDX+FgUFoUEJsaGP+Lc0d2vvG/F+guzOZqFjXzWGNgTyWcm/Ej iZDEiDq4It5XYTJs5IrtY6YHa/Iwf7BaZUfUY0aR8mevkDCGAv+zzni4I3kp5yp6cxOQ D+kLjihhh++wdQ2g182wjzQn5Ok450KTMt7ICUymdZl1r9B+EaK3oBleeb16q/zj++RH +zjw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DLwlbxNB; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-188088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188088-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bf5fccbf8asi255505a91.42.2024.05.23.15.48.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 15:48:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-188088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DLwlbxNB; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-188088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188088-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 915AEB23950 for ; Thu, 23 May 2024 22:48:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD38312837C; Thu, 23 May 2024 22:48:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DLwlbxNB" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3090782D9A for ; Thu, 23 May 2024 22:48:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716504515; cv=none; b=OTJ+c6hIPQiUyE2A8+GkYEsAaa25LCLJs0HjEGz9GSnzDokf77IpMBZEK5xYmt5THQHEVNoRPfWR6pgWl63sT8BQsQFLD3AdZpUnGcgYtu8wqxWk4UkONzfZUNND6x62fSeJCQLulr6MRYAmogIobA0n1AlEAgDE1f84vZG/Hrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716504515; c=relaxed/simple; bh=FVjf8wrlV7NMGMbPBklu5L3+XCMuQXEvjmuSJKVs8nA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z6aIY7LBZSlNhYbWwvo2tM38fpcZVb6gmD1GdbbHhAJVEYEfdkQ87v1FwHns/kksMmOUxk8QrEDt8bTSqwWcQinJNC8KhQrUhbEHlrZUZNli0jnSRDK02rmKsTOYcdLnQdofZtJzodlJ0kqX+ksD9YTTxTE6h07E0Mov/YiUsCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DLwlbxNB; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716504514; x=1748040514; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=FVjf8wrlV7NMGMbPBklu5L3+XCMuQXEvjmuSJKVs8nA=; b=DLwlbxNBNA0Un0oQv3ok8NoIwD1Pa36HzjWqa5D4WZV5qHTHjNfgUgYJ +DLCzlBeh+jHh7XNyyMtL0+bCRY+cK+35gEQEiqnr6aio1ecvyQ1yUZG0 DUWvva2mzpmD+q6EO/zJ92rPSmixKtuRQylW+6pAXtJEaYZHEGWeMM9gM FyVQ3L8E3cUOlZyQE/NgqKhr/GZwBgw2hB04fuLCWaFTYNe9pa1lUCzzX Hx29v1Cndves7fq/NIMTVDDSdpU1l6vJ76ax8XM+h8iMuNiDIP8oCXO70 NbiuMVOk/2W63BiNMPTqw6rPIsfdIezgYdii+UB2zU78DJDcpc45TlSH8 A==; X-CSE-ConnectionGUID: 9Ipa2gl9ToyLwgxbB7aXLA== X-CSE-MsgGUID: 8oFf9p+1Rau6e8SH+K1lVg== X-IronPort-AV: E=McAfee;i="6600,9927,11081"; a="23467783" X-IronPort-AV: E=Sophos;i="6.08,183,1712646000"; d="scan'208";a="23467783" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 15:48:24 -0700 X-CSE-ConnectionGUID: MoVaye90TUGa3MBDutcPlw== X-CSE-MsgGUID: u7aNR404Qpmcpe3YXuvdyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,183,1712646000"; d="scan'208";a="38390291" Received: from unknown (HELO [10.125.110.91]) ([10.125.110.91]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 15:48:23 -0700 Message-ID: Date: Thu, 23 May 2024 15:48:22 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 2/2] mm/x86/pat: Do proper PAT bit shift for large mappings To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Jason Gunthorpe , Andrew Morton , Al Viro , Dave Hansen , Andy Lutomirski , Matthew Wilcox , Dan Williams , "Kirill A . Shutemov" , Mike Rapoport , Ingo Molnar , Michal Hocko , Alex Williamson , Peter Zijlstra , Suren Baghdasaryan , Borislav Petkov , x86@kernel.org References: <20240523223745.395337-1-peterx@redhat.com> <20240523223745.395337-3-peterx@redhat.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240523223745.395337-3-peterx@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/23/24 15:37, Peter Xu wrote: > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 317de2afd371..c4a2356b1a54 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1135,7 +1135,7 @@ static void insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr, > goto out_unlock; > } > > - entry = pmd_mkhuge(pfn_t_pmd(pfn, prot)); > + entry = pmd_mkhuge(pfn_t_pmd(pfn, pgprot_4k_2_large(prot))); > if (pfn_t_devmap(pfn)) > entry = pmd_mkdevmap(entry); > if (write) { Does this even compile on non-x86 architectures?