Received-SPF: pass (google.com: domain of linux-kernel+bounces-188122-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <46713df6-d73e-4816-bbda-a3b2dc723438@intel.com>
Date: Fri, 24 May 2024 11:37:15 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 039/130] KVM: TDX: initialize VM with TDX specific
 parameters
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	=?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= <jgross@suse.com>
CC: "Yamahata, Isaku" <isaku.yamahata@intel.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "isaku.yamahata@gmail.com"
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, "Aktas,
 Erdem" <erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>,
	"Sagi Shahar" <sagis@google.com>, "Chen, Bo2" <chen.bo@intel.com>, "Yuan,
 Hang" <hang.yuan@intel.com>, "Zhang, Tina" <tina.zhang@intel.com>, "Li,
 Xiaoyao" <Xiaoyao.Li@intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <5eca97e6a3978cf4dcf1cff21be6ec8b639a66b9.1708933498.git.isaku.yamahata@intel.com>
 <46mh5hinsv5mup2x7jv4iu2floxmajo2igrxb3haru3cgjukbg@v44nspjozm4h>
 <de344d2c-6790-49c5-85be-180bc4d92ea4@suse.com>
 <etso5bvvs2gq3parvzukujgbatwqfb6lhzoxhenrapav6obbgl@o6lowhrcbucp>
 <e8b36230-d59f-44f1-ba48-5a0533238d8e@suse.com>
 <pfbphwefaefxw2l2u26qr6ptq7rtdmnihjmxvk34zv4srlnsum@qyjumzzdnfxo>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <pfbphwefaefxw2l2u26qr6ptq7rtdmnihjmxvk34zv4srlnsum@qyjumzzdnfxo>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGxLNm9DM1h4WHR1cjVsUWZkRTRPdmxYM1pZOVNqZHArOThjS29MUXZ6Tk5K?=
 =?utf-8?B?V0x4VlB1VzJHR1BGa1oreEdOcVJHL3kxZzJiWjl6WC8xUm1XRFA5OUc0MGdP?=
 =?utf-8?B?SjN2anRQUGl0LzcyK2VvUzEzNlRscUtmTzIyK2EwTElKNGpWcjhieE5DN3ZE?=
 =?utf-8?B?RkZZVXF1eDl2MExNdGczbDlkR3gyVVVMTFBkYzlpTDlYUkhBRC9UZ1pIeTF4?=
 =?utf-8?B?cXFBZExVcmtobmY2M2p6R3hwNG5NbkR3eUlVajVRcGh5VTNUaWw4dngrOUhY?=
 =?utf-8?B?aEh3aS81cUpuMHRCa0NDZGpUR05nZE5XQVBoM1NKbXo4WFFoWEdkaWI0dU93?=
 =?utf-8?B?aVlHS0tCSkhWTzNLbzkyWEZqUS9HMXJ0Zk11RHFPaG45R0NVNVpLZExyQTdn?=
 =?utf-8?B?VmFIMWN1YVY3bmtiTVBid0NlU0xJd0sxR1Y3NXluc1BWQTZWa2EvOEp5blhS?=
 =?utf-8?B?MjNFRUhCOHZqU3NGL3ZQUVBLNmQwODBRQVBoclNUYTVlMDBSbUxYdEFaQ2xa?=
 =?utf-8?B?ZUVjTWZmaVIzZEJac0w5bTlRN2JYVjFRQnFMTzRkb3p3aGtFQklYUTlTYS9Z?=
 =?utf-8?B?MS91TkFIbEduWCtONlRMci9pSkN3Qkk1SEw3TUlvblU0NHU3YkszVHlaWVJG?=
 =?utf-8?B?NENQbW9lQ0pMRERLbHlmQ3RCNHIwb3phcmxpdzcvY0F1Y1lYdU5wUWZxZ0hG?=
 =?utf-8?B?YmFiYkdlMys5VGc5ZFJGN2tqMTk5cXdIZXQ0YUo4TDZUYmRpRVdHSXNhdGUy?=
 =?utf-8?B?Y3JGckUvelExbVVnWVlPNVJUVi8rcms3UENsTjdidXI3bmt4aUFxWDZqZWxj?=
 =?utf-8?B?VzVIMjMvRnYrT1NnWllzWjRHTWFkZFc4S3g2VlQyRnJVME1jeWxQWElQc0Fz?=
 =?utf-8?B?b084bnhrY1ZucWVFdmQwVVA5eXBZRHgrandMc2ZjOExBa0RFUXBLeDgzQXNi?=
 =?utf-8?B?akh1bzhPOGljTlMxQzFnRDNmcE13RUx1YUNReWN4d2JhbFJlYWJJVGw0VDN6?=
 =?utf-8?B?aEc0b0NlaXd1NE1yWUk0aHN0UmpTRVo5eHZiMW10enpUd2sxVFUzZm1uU2FK?=
 =?utf-8?B?WUlGTHA5MFVtNStjVTd5Tjgwelk0bWUyOW40OGxwbHR3QWVzeStnRStTdS80?=
 =?utf-8?B?U2lNKzFUYUpBNkpPN0kzSkIrRGZNZi9ISSs3ZFlPVlJJN2hFNXVNR3RKRWRl?=
 =?utf-8?B?cTgxT29WQkJmbko5NkRzOEpwbHIrSHJJWGRmV2xWYkJ6YktFUlpvV210cklL?=
 =?utf-8?B?dkNtc1VwTDlKYVk4UHFURGovTWdjUE5yck1HQStYd3BaTGhld2pxWWQ5RnhF?=
 =?utf-8?B?UC8yc1hrK1plQlRKRUVOa1Flc0gwam5NZVVoVERVb3E3NklHSzZoV0NQdnl0?=
 =?utf-8?B?MDdzL0V6aHNVSVo0dWtROWt5bFpSVjNzdFZUdkc1aU5KTUFEQ1V3dzhxUEJp?=
 =?utf-8?B?NFFPdG5aUzdBbUJlcmdrY2Qzem5QVndFdWtQZVB4RzNYMTZZbUdXaDA2a080?=
 =?utf-8?B?eVdVbmt5blVVd1lORG1IZytVUWZaWDlSRGdBNE55eFY1K3FRS1AxN0JjQkVs?=
 =?utf-8?B?Y0hjQ1ZiWEpsNjBoWEtCMVptRFB6T0RoeHFNYzJQdjFGNFdCYlZZMW1ScnRy?=
 =?utf-8?B?aXJ3dVhhY1RSYlFxYkRIc0g2NWo4UFI4RmZPd0QyNVlXVVdHVlJUY1lMMUxU?=
 =?utf-8?B?L0pKTWt0ZkVqMkp6NEtFWWlUdlhiemFNYlZzQVdZN2JSazFFY2ZjTEhhMS91?=
 =?utf-8?B?M09namJWdktsZW5RSlhhdW5XNFBReHpqT1FRKytCeCt6cDFXYVM1S3JZYnRS?=
 =?utf-8?B?dXJtQmpTUDFrQXRoVlhxQ0VFdVpyaTQzTk9KNjdJSFFGN2VPL3F2Z25WdTZR?=
 =?utf-8?B?eHVHbnJtekZhakFsWitMQmlLWS9wa2oxdzlwSHdGY05CN29wQVlZSHRJclkx?=
 =?utf-8?B?bU03aHNBelBoTjFHdVNSY2FIYUszcy9JVDN1UXd6QmZvZ1RHaXhqa2FhZHlE?=
 =?utf-8?B?WkgvYnVzUlNENkRLcFdjWldwNHRvWGlhdkwxZS8vODBGRFl1Zm5iWkJKMXl0?=
 =?utf-8?B?amkrYWZ4aEFhNjBVaDVEUkgreU5FYmpDajBhU2lBcEd2cm9DMnFtQ2dmSzNQ?=
 =?utf-8?Q?3vFypgmBGHU4IopjCDzgvh7Zc?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 42cb34ce-478c-4a15-3b93-08dc7b814d0e
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 23:37:25.5564
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vwUgeY9BhWlXswX3fD5oCktgdzRTmzL08EKiXiQZqZLYGf+pJhhNWyA/KB3/Dqli5ZVynqsw8XLNVLfcBvObJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6915
X-OriginatorOrg: intel.com


On 18/05/2024 4:25 am, Kirill A. Shutemov wrote:
> On Fri, May 17, 2024 at 05:00:19PM +0200, Jürgen Groß wrote:
>> On 17.05.24 16:53, Kirill A. Shutemov wrote:
>>> On Fri, May 17, 2024 at 04:37:16PM +0200, Juergen Gross wrote:
>>>> On 17.05.24 16:32, Kirill A. Shutemov wrote:
>>>>> On Mon, Feb 26, 2024 at 12:25:41AM -0800, isaku.yamahata@intel.com wrote:
>>>>>> @@ -725,6 +967,17 @@ static int __init tdx_module_setup(void)
>>>>>>     	tdx_info->nr_tdcs_pages = tdcs_base_size / PAGE_SIZE;
>>>>>> +	/*
>>>>>> +	 * Make TDH.VP.ENTER preserve RBP so that the stack unwinder
>>>>>> +	 * always work around it.  Query the feature.
>>>>>> +	 */
>>>>>> +	if (!(tdx_info->features0 & MD_FIELD_ID_FEATURES0_NO_RBP_MOD) &&
>>>>>> +	    !IS_ENABLED(CONFIG_FRAME_POINTER)) {
>>>>>
>>>>> I think it supposed to be IS_ENABLED(CONFIG_FRAME_POINTER). "!" shouldn't
>>>>> be here.
>>>>
>>>> No, I don't think so.
>>>>
>>>> With CONFIG_FRAME_POINTER %rbp is being saved and restored, so there is no
>>>> problem in case the seamcall is clobbering it.
>>>
>>> Could you check setup_tdparams() in your tree?
>>>
>>> Commit
>>>
>>> [SEAM-WORKAROUND] KVM: TDX: Don't use NO_RBP_MOD for backward compatibility
>>>
>>> in my tree comments out the setting TDX_CONTROL_FLAG_NO_RBP_MOD.
>>>
>>> I now remember there was problem in EDK2 using RBP. So the patch is
>>> temporary until EDK2 is fixed.
>>>
>>
>> I have the following line in setup_tdparams() (not commented out):
>>
>> 	td_params->exec_controls = TDX_CONTROL_FLAG_NO_RBP_MOD;
> 
> Could you check if it is visible from the guest side?
> 
> It is zero for me.
> 
> diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c
> index c1cb90369915..f65993a6066d 100644
> --- a/arch/x86/coco/tdx/tdx.c
> +++ b/arch/x86/coco/tdx/tdx.c
> @@ -822,13 +822,33 @@ static bool tdx_enc_status_change_finish(unsigned long vaddr, int numpages,
>   	return true;
>   }
>   
> +#define TDG_VM_RD			7
> +
> +#define TDCS_CONFIG_FLAGS		0x1110000300000016
> +

Hi Kirill,

Where did you get this metadata field ID value from?  I assume you meant 
below one, from which the ID is 0x9110000300000016?

Or is there anything special rule for using metadata field ID in the guest?

     {
       "Control Structure": "TDCS",
       "Class": "Execution Controls",
       "Field Name": "CONFIG_FLAGS",
       "Description": [
         "Non-attested TD configuration flags"
       ],
       "Type": "64b bitmap",
       "VM Applicability": null,
       "Mutability": "TDH.MNG.INIT/  TDH.IMPORT.STATE.IMMUTABLE",
       "Initial Value": "From TDH.MNG.INIT input",
       "Field Size (Bytes)": "8",
       "Num Fields": "1",
       "Num Elements": "1",
       "Element Size (Bytes)": "8",
       "Overall Size (Bytes)": "8",
       "Base FIELD_ID (Hex)": "0x9110000300000016",
       "Host VMM Access for a Production TD": "RO",
       "Host VMM Access for a Debug TD": "RO",
       "Guest Access": "RO",
       "Migration TD Access": "RO",
       "Host VMM Rd Mask for a Production TD ": "-1",
       "Host VMM Wr Mask for a Production TD ": "0",
       "Host VMM Rd Mask for a Debug TD ": "-1",
       "Host VMM Wr Mask for a Debug TD ": "0",
       "Guest Rd Mask": "-1",
       "Guest Wr Mask": "0",
       "Migration TD Rd Mask": "-1",
       "Migration TD wr Mask": "0"
     },