Received-SPF: pass (google.com: domain of linux-kernel+bounces-188174-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Chanwoo Lee <cw9316.lee@samsung.com>
To: cw9316.lee@samsung.com
Cc: James.Bottomley@HansenPartnership.com, alim.akhtar@samsung.com,
	avri.altman@wdc.com, bvanassche@acm.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
	powen.kao@mediatek.com, quic_cang@quicinc.com, quic_nguyenb@quicinc.com,
	stanley.chu@mediatek.com, yang.lee@linux.alibaba.com
Subject: RE: [PATCH] ufs:mcq:Fixing Error Output for
 ufshcd_try_to_abort_task in ufshcd_mcq_abort
Date: Fri, 24 May 2024 09:18:40 +0900
Message-Id: <20240524001840.1104839-1-cw9316.lee@samsung.com>
In-Reply-To: <20240523002257.1068373-1-cw9316.lee@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20240523002257.1068373-1-cw9316.lee@samsung.com>
	<CGME20240524001842epcas1p3a66b301f7aad3a8da28869db634221d1@epcas1p3.samsung.com>

On 5/24/24 12:08, Bart Van Assche wrote:
>On 5/23/24 16:56, Chanwoo Lee wrote:
>> I thought this patch would be appropriate to "fix" the following log.
>>    * dev_err(hba->dev, "%s: device abort failed %d\n", __func__, err);
>> If "Fixing" is not appropriate, could you suggest another word?
>
>That's something I had not noticed. This is indeed a bug fix. Please add
>a "Fixes:" tag as is expected for bug fixes.
>
>BTW, I think that ufshcd_mcq_abort() can be improved significantly. How
>about reworking that function as follows before the bug reported in this
>patch is fixed?
>- Remove the local variable 'err' (and reintroduce that variable in your
>patch).
>- Change all 'goto out' statements into 'return FAILED'.
>- Add 'return SUCCESS' at the end.
>
>I expect that this change will make that function easier to read and to
>maintain.
>
>Thanks,
>
>Bart.

Thank you for the good suggestion.
I will create a new patch and reply with v2.

Thanks,

Chanwoo Lee.