Received-SPF: pass (google.com: domain of linux-kernel+bounces-188193-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <5c063045-4bce-14e4-9930-77cc0ed2edad@redhat.com>
Date: Thu, 23 May 2024 20:57:53 -0400
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] dm vdo: remove unused struct 'uds_attribute'
Content-Language: en-US
To: linux@treblig.org
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20240523210716.309324-1-linux@treblig.org>
From: Matthew Sakai <msakai@redhat.com>
In-Reply-To: <20240523210716.309324-1-linux@treblig.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/23/24 17:07, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'uds_attribute' is unused since
> commit a9da0fb6d8c6 ("dm vdo: remove all sysfs interfaces").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Yes, this was clearly an oversight on our part. Feel free to add:
Reviewed-by: Matthew Sakai <msakai@redhat.com>

> ---
>   drivers/md/dm-vdo/dedupe.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c
> index 117266e1b3ae..39ac68614419 100644
> --- a/drivers/md/dm-vdo/dedupe.c
> +++ b/drivers/md/dm-vdo/dedupe.c
> @@ -148,11 +148,6 @@
>   #include "vdo.h"
>   #include "wait-queue.h"
>   
> -struct uds_attribute {
> -	struct attribute attr;
> -	const char *(*show_string)(struct hash_zones *hash_zones);
> -};
> -
>   #define DEDUPE_QUERY_TIMER_IDLE 0
>   #define DEDUPE_QUERY_TIMER_RUNNING 1
>   #define DEDUPE_QUERY_TIMER_FIRED 2