Received-SPF: pass (google.com: domain of linux-kernel+bounces-188007-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 23 May 2024 22:11:02 +0100
From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	Goldwyn Rodrigues <rgoldwyn@suse.com>,
	Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
	Jens Axboe <axboe@kernel.dk>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] mm/filemap: invalidating pages is still necessary when
 io with IOCB_NOWAIT
Message-ID: <Zk-w5n769fyZWTYC@casper.infradead.org>
References: <20240513132339.26269-1-liuwei09@cestc.cn>
 <20240523130802.730d2790b8e5f691871575c0@linux-foundation.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240523130802.730d2790b8e5f691871575c0@linux-foundation.org>

On Thu, May 23, 2024 at 01:08:02PM -0700, Andrew Morton wrote:
> On Mon, 13 May 2024 21:23:39 +0800 Liu Wei <liuwei09@cestc.cn> wrote:
> 
> > After commit (6be96d3ad3 fs: return if direct I/O will trigger writeback),
> > when we issuing AIO with direct I/O and IOCB_NOWAIT on a block device, the
> > process context will not be blocked.
> > 
> > However, if the device already has page cache in memory, EAGAIN will be
> > returned. And even when trying to reissue the AIO with direct I/O and
> > IOCB_NOWAIT again, we consistently receive EAGAIN.
> > 
> > Maybe a better way to deal with it: filemap_fdatawrite_range dirty pages
> > with WB_SYNC_NONE flag, and invalidate_mapping_pages unmapped pages at
> > the same time.
> 
> Can't userspace do this?  If EAGAIN, sync the fd and retry the IO?

I don't think that it can, because the pages will still be there, even
if now clean?  I think the idea was to punt to a worker thread which
could sleep and retry without NOWAIT.  But let's see what someone
involved in this patch has to say about the intent.