Received-SPF: pass (google.com: domain of linux-kernel+bounces-188199-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 24 May 2024 01:09:34 +0000
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Matthew Sakai <msakai@redhat.com>
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dm vdo: remove unused struct 'uds_attribute'
Message-ID: <Zk_ozpHryOiMLx_Q@gallifrey>
References: <20240523210716.309324-1-linux@treblig.org>
 <5c063045-4bce-14e4-9930-77cc0ed2edad@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <5c063045-4bce-14e4-9930-77cc0ed2edad@redhat.com>
User-Agent: Mutt/2.2.12 (2023-09-09)

* Matthew Sakai (msakai@redhat.com) wrote:
> On 5/23/24 17:07, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'uds_attribute' is unused since
> > commit a9da0fb6d8c6 ("dm vdo: remove all sysfs interfaces").
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> Yes, this was clearly an oversight on our part. Feel free to add:
> Reviewed-by: Matthew Sakai <msakai@redhat.com>

Thanks for the quick review.
Is this something you'll send a pull for, or do I need to
ask someone else to include it?

Dave

> > ---
> >   drivers/md/dm-vdo/dedupe.c | 5 -----
> >   1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c
> > index 117266e1b3ae..39ac68614419 100644
> > --- a/drivers/md/dm-vdo/dedupe.c
> > +++ b/drivers/md/dm-vdo/dedupe.c
> > @@ -148,11 +148,6 @@
> >   #include "vdo.h"
> >   #include "wait-queue.h"
> > -struct uds_attribute {
> > -	struct attribute attr;
> > -	const char *(*show_string)(struct hash_zones *hash_zones);
> > -};
> > -
> >   #define DEDUPE_QUERY_TIMER_IDLE 0
> >   #define DEDUPE_QUERY_TIMER_RUNNING 1
> >   #define DEDUPE_QUERY_TIMER_FIRED 2
> 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/