Received-SPF: pass (google.com: domain of linux-kernel+bounces-188208-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <cc86b717-e060-2d73-88a6-1625285c47c5@redhat.com>
Date: Thu, 23 May 2024 21:34:41 -0400
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] dm vdo: remove unused struct 'uds_attribute'
Content-Language: en-US
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
 Mike Snitzer <snitzer@kernel.org>, Mikulas Patocka <mpatocka@redhat.com>
References: <20240523210716.309324-1-linux@treblig.org>
 <5c063045-4bce-14e4-9930-77cc0ed2edad@redhat.com>
 <Zk_ozpHryOiMLx_Q@gallifrey>
From: Matthew Sakai <msakai@redhat.com>
In-Reply-To: <Zk_ozpHryOiMLx_Q@gallifrey>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/23/24 21:09, Dr. David Alan Gilbert wrote:
> * Matthew Sakai (msakai@redhat.com) wrote:
>> On 5/23/24 17:07, linux@treblig.org wrote:
>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>
>>> 'uds_attribute' is unused since
>>> commit a9da0fb6d8c6 ("dm vdo: remove all sysfs interfaces").
>>>
>>> Remove it.
>>>
>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>>
>> Yes, this was clearly an oversight on our part. Feel free to add:
>> Reviewed-by: Matthew Sakai <msakai@redhat.com>
> 
> Thanks for the quick review.
> Is this something you'll send a pull for, or do I need to
> ask someone else to include it?

No need to do anything else, I think. Mike (or Mikulas), can you
include this with the next set of device mapper patches?

> Dave
> 
>>> ---
>>>    drivers/md/dm-vdo/dedupe.c | 5 -----
>>>    1 file changed, 5 deletions(-)
>>>
>>> diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c
>>> index 117266e1b3ae..39ac68614419 100644
>>> --- a/drivers/md/dm-vdo/dedupe.c
>>> +++ b/drivers/md/dm-vdo/dedupe.c
>>> @@ -148,11 +148,6 @@
>>>    #include "vdo.h"
>>>    #include "wait-queue.h"
>>> -struct uds_attribute {
>>> -	struct attribute attr;
>>> -	const char *(*show_string)(struct hash_zones *hash_zones);
>>> -};
>>> -
>>>    #define DEDUPE_QUERY_TIMER_IDLE 0
>>>    #define DEDUPE_QUERY_TIMER_RUNNING 1
>>>    #define DEDUPE_QUERY_TIMER_FIRED 2
>>
>>