Received-SPF: pass (google.com: domain of linux-kernel+bounces-188220-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 24 May 2024 09:50:26 +0800
From: Yan Zhao <yan.y.zhao@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
CC: Sean Christopherson <seanjc@google.com>, Kai Huang <kai.huang@intel.com>,
	Rick P Edgecombe <rick.p.edgecombe@intel.com>, "dmatlack@google.com"
	<dmatlack@google.com>, "sagis@google.com" <sagis@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Erdem Aktas
	<erdemaktas@google.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>
Subject: Re: [PATCH 02/16] KVM: x86/mmu: Introduce a slot flag to zap only
 slot leafs on slot deletion
Message-ID: <Zk/yYkLCUi17RghH@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <ZkUVcjYhgVpVcGAV@google.com>
 <ac5cab4a25d3a1e022a6a1892e59e670e5fff560.camel@intel.com>
 <ZkU7dl3BDXpwYwza@google.com>
 <175989e7-2275-4775-9ad8-65c4134184dd@intel.com>
 <ZkVDIkgj3lWKymfR@google.com>
 <7df9032d-83e4-46a1-ab29-6c7973a2ab0b@redhat.com>
 <Zk1KZDStu/+CR0i4@yzhao56-desk.sh.intel.com>
 <Zk1ZA-u9yYq0i15-@google.com>
 <Zk2VPoIpm9E6CCTm@yzhao56-desk.sh.intel.com>
 <CABgObfaq4oHC9C_iA2OudmFN-7E9RDiw-WiDu9skmpsW39j0nQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABgObfaq4oHC9C_iA2OudmFN-7E9RDiw-WiDu9skmpsW39j0nQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGZ0bjg4NEpiUWNsdkMzYjhHdTdtNktleEZ6MStqMi81cmJzZWloZklHbHZk?=
 =?utf-8?B?M3IydTBhYmdNMnNEbUJpMnAvaGljeGRSVTFmUzQ5RmtBZ0ZlVk1USldrVSt0?=
 =?utf-8?B?Uk5ra0F2QmpWMXpyVWF5N3VBZ0xuRkhwMHlIVmFoTEttUUkyNURhZHoyVVFR?=
 =?utf-8?B?cUFBMm1tQ1kwV3F1eVNVRnR4WlAzNUNCUml2YksxcHNIMytuM0sxTmFCeU9G?=
 =?utf-8?B?YmdpNVJLRDlSZFdkZkY0Q1BLOEkveHVjcWFpUlVXZ1QwT2psRHVkbDl5TXpC?=
 =?utf-8?B?Y2dnU3JoQXk2bEVIcnJQZUEzYkwyOWRFcENoTG1jcWlMdmVLamlUN094eXp6?=
 =?utf-8?B?WmhLZk9MTzNmazZLOVY2UXNUSXhrRk5Hd05vbng2Ylg3REdML3lBUFRQbG0y?=
 =?utf-8?B?dmJ3bnV0VXpURm5RTVhzaFM4TWdmL2hIUHplM3hiQUVnZGRkWlNSTlhsZHkz?=
 =?utf-8?B?Q1IycStGVURNSVdyQ3Uzd1FsaG1qOGFqdVdvTTBYeDYrMGI0M01vSld5eXJY?=
 =?utf-8?B?MWUxa2ZQek53QXA5QVYybEJFYjRhWkl6UExzejNsc1JSYVl6Y0NzTnJUNU9k?=
 =?utf-8?B?VUZta1ZFNkRqU0g5VmhxNmxiYU8vVHQ1cFYxQ01FaWI3cGFVZFVMQkVSM3Jk?=
 =?utf-8?B?eFA1L2R0Z1NrU2xUQmFEL1Y2aFhyalE3UDNrdk5HNVdSbnNCRHUxNHB5RUJC?=
 =?utf-8?B?cnZpa084ZDdBUEtxVkUzbkxDMndCT1VZV1F2RGZQazNKVGtEMklUQ210SUpW?=
 =?utf-8?B?SzVIUTJlTnc0VE8xbGtWT2c5bHI4S2NqUDBUNWN1Nmk4Y0x6QjFtYzkyQkhy?=
 =?utf-8?B?OU1wWWp3UVZiMEJObzFBTFM5b1BOZ2hteXdQSkxoUGZCZ1NZYnR3RlpEUXlY?=
 =?utf-8?B?MG12MkJNdEVNMWUzcU10VW1DYkZGMWU3Y1JWWGJObWFybnZYRHRmaXF1ME1L?=
 =?utf-8?B?b0FvNUg1L2h2WHJ5elIwd1c0cEdoQ0xpdUgvWk5McmNIMlh5WEg4NTBEazhH?=
 =?utf-8?B?ZnM0UTlOV1Z3cFpmT3RIVTZ6MTFJWld3V1Zyc2N3THFDYWRmYnJud09tYm5p?=
 =?utf-8?B?ZkN1N3V5Nm1OR04ydllhWk82WSs4ZGlGTmxzSiszRkJBTzR0UTBPZFh2L3o5?=
 =?utf-8?B?dWU5TTBhNEFZV2M1N2ZQZnFTblJvODl6TWVZUHB4WDd2Mi9vWCtDdkhDaE9l?=
 =?utf-8?B?dnNqekNiR2R4elQ0M05XNWp6a3pjMFg2Uy92MnpyZE10VVFHVW9QNzdYY01N?=
 =?utf-8?B?dmYrMjBkTm5qaUZMU1NqdS8weDY2R3JqZXIxWFpsV1hEZU1tQVZaRGxDY2gz?=
 =?utf-8?B?NlVlRWxQbU13SGg0SUorRkZPZ00ra3RJWHBqU2h1ZndscmlYaU5LOXJJamlY?=
 =?utf-8?B?UHl3eGNHSkFtcXJrN3ZKMEk4NlBSWHRTZG44UkdzeXhWcUJkOHBPY3lYdXpa?=
 =?utf-8?B?SlJiS1orVVVpRHdlRkE5TitYckVCMlNvVCs2MTRPa0R5RVd3ejZkTlMwdXZ4?=
 =?utf-8?B?NVRrazhqZnQxWi93UXpIRUpLZkJKZGMwekdoWXZyeXdFdzV3am5hN2R5MEYz?=
 =?utf-8?B?NTVHNFEzY1RDc21wREJhQURWeUliVGFQRU8xWmhEdGtSY2pJY2RHeFViS2Y4?=
 =?utf-8?B?RkpSaXQvUmt4R0NrRms2N0F5Tm1YSkFYU3dLU09jcURDZ2JOMHJjMFg2ZE02?=
 =?utf-8?B?UkdXVEI2WTRoU2tFSHNXSStJczNKRzk0a0xEWVZIZkJEQXIvTXVrT2dsdHNl?=
 =?utf-8?B?OUFHd0hyQmN0dXcrUG5kbkRuNnJYUlFnejVCV055bkt6d1ZHOUtPU1ZLcWJx?=
 =?utf-8?B?VkN3NEpZSC9mQkE4OE1vaHFGT3d6UFBsemZaNzh0RVN1Q1ZBZEpaZ2xvTEZH?=
 =?utf-8?B?Y3B2Q0t3WFYzUXUyQW9NQ1h6NlMzNDY5MzZJaUI2UUhiZVIxdXQ4ZGxCSHdh?=
 =?utf-8?B?SklSMG5lcUJaM3k4d3UvZFFVdlRRaG13YlgwRENKeGhIN3pvYWVNbGEvRERC?=
 =?utf-8?B?WCtFZ2huclVFR1BXMHNoRkV6NnQwTXMwZlROTC9vV3c4NFJJL1ZpSlFUWE5B?=
 =?utf-8?B?c21yZENSZEdhdFA2Vi9ZbEFvYWxlNXJrWUR6OTZzMkdFRkxOVmN3ZGFteHBO?=
 =?utf-8?Q?3Y5Sy3AfnmFmox/MZqgn/6fKh?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3125dba8-9fc4-4d74-9017-08dc7b9400b1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2024 01:51:17.7916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kCZcEVKv0oxSUMcnpEbgwbjlx+7+OGBuoBnPGBNS98WerzuWc+SoPwUrvuA5/CEJKT+OM9SMitj0RkllwjiJPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7744
X-OriginatorOrg: intel.com

On Wed, May 22, 2024 at 05:45:39PM +0200, Paolo Bonzini wrote:
> On Wed, May 22, 2024 at 8:49 AM Yan Zhao <yan.y.zhao@intel.com> wrote:
> > > Disabling the quirk would allow KVM to choose between a slow/precise/partial zap,
> > > and full/fast zap.
> > TDX needs to disable the quirk for slow/precise/partial zap, right?
> 
> Yes - and since TDX is a separate VM type it might even start with the
> quirk disabled. For sure, the memslot flag is the worst option and I'd
> really prefer to avoid it.
Thanks. Will implement a quirk and let TDX code in QEMU to disable the
quirk.

> 
> > > I have the same feeling that the bug is probably not reproducible with latest
> > > KVM code
> 
> Or with the latest QEMU code, if it was related somehow to non-atomic
> changes to the memory map.
>
Thanks for this input. Will check if it's related.