Received-SPF: pass (google.com: domain of linux-kernel+bounces-188227-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
CC: Nicolin Chen <nicolinc@nvidia.com>, "will@kernel.org" <will@kernel.org>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"joro@8bytes.org" <joro@8bytes.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "iommu@lists.linux.dev"
	<iommu@lists.linux.dev>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "Liu, Yi L" <yi.l.liu@intel.com>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>, "vasant.hegde@amd.com"
	<vasant.hegde@amd.com>, "jon.grimm@amd.com" <jon.grimm@amd.com>,
	"santosh.shukla@amd.com" <santosh.shukla@amd.com>, "Dhaval.Giani@amd.com"
	<Dhaval.Giani@amd.com>, "shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>
Subject: RE: [PATCH RFCv1 07/14] iommufd: Add viommu set/unset_dev_id ops
Thread-Topic: [PATCH RFCv1 07/14] iommufd: Add viommu set/unset_dev_id ops
Thread-Index: AQHajVVq/X0HjqCDvU+a/LkdwhCQ/LGT28sAgADojoCAAk6vgIAAqT2AgAqBYwCAAlS+oIAAlxIAgAC8r8A=
Date: Fri, 24 May 2024 02:21:23 +0000
Message-ID: <BN9PR11MB5276A896D215E1FA61DECDC38CF52@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1712978212.git.nicolinc@nvidia.com>
 <6e57d7b5aa1705bdd547b1cd2aca93d3bf70dfa4.1712978212.git.nicolinc@nvidia.com>
 <ZkDWXnPW7CaX5TtA@nvidia.com> <ZkGZc5dvLigXcWib@nvidia.com>
 <ZkOI8ztR1mUMJ8oe@nvidia.com> <ZkQW6/OAQ8MzN6Go@nvidia.com>
 <20240521182448.GN20229@nvidia.com>
 <BN9PR11MB5276EEC2A1DDA9C92F96737C8CF42@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20240523150120.GO20229@nvidia.com>
In-Reply-To: <20240523150120.GO20229@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S/SMlzcWs/AIC4E6JvUvzEXyiNO4cpSoflqOm3ev3osAon+b4m6wrD+1s7eF?=
 =?us-ascii?Q?cuA1vkLUSIR40eWVLtI2WT2cErTCEIz7gLirugIRdDXAEtPFqvHPaXG0xTuU?=
 =?us-ascii?Q?yjD1cq6WNdl+AApHzJ4W60PN5EhG7NAjL6AOoucVupVr8K/ZuxAnnRVC9265?=
 =?us-ascii?Q?gfnXibrLDJUpStig4Dc8A1+ieAaA3lHBkZiV6lu6uJgdcNUhkUO91AOpmz0i?=
 =?us-ascii?Q?gsksIpfHkdkVH+3y0pDDC8BFnM770f6+LRD8FNoqwrulteHf0AQ55oOpE6VK?=
 =?us-ascii?Q?LTtww9SLGy3ERDvmNAtfmDaIh5BKxb22Sw1IV41yEOfI6+Zn6BfBjgTa8CdJ?=
 =?us-ascii?Q?9t579AwuTl8DR/+sW+l/WDHolz5GNGaLPCU1y+re6eRPwtEqFbacmSsBoJVy?=
 =?us-ascii?Q?QwAZL6A2BUsNBoLCJBUvCezuIdiwPgh6APN+FhRu0W8d2wyMIzfAtw87k49T?=
 =?us-ascii?Q?qscsjZPsJrDrZOio/ZxnLW+YbT89Txmpf6myYe2JMlEAYPgIhuJpZIsSFcd4?=
 =?us-ascii?Q?9FSQHMrBYRZrazslGIiy+tOo16dnUvxThcjvVU3JcvAuzNphi6v/zENyfRRf?=
 =?us-ascii?Q?TyqNR6rriIw8LtV84p2GDKrwiQkim9vK9x28eGYuuXdsGX6rI4/mSKXsa/gJ?=
 =?us-ascii?Q?E2h34CtQjtFOQe2BDg5S8w6vZvwvBWURhl9XEt3dJK2Rr9iyVdleAKz2mdj9?=
 =?us-ascii?Q?9ahGisCpIKt9+IHllzrXw0A7WY3jLaIpp3ZK4mVXHKFj0j3oqDPyru0Vi6qS?=
 =?us-ascii?Q?fMc2YGx2uGMHXpWK2DEu3BdogLTFNJo/Ted6DV0jrnpz+/fWvCuz6FE+lX/h?=
 =?us-ascii?Q?07rTfMRQvbildgAMVjwt/c2IJsuxOoO+RabFJsrGErRJsRPHkmV2l8BLRkmG?=
 =?us-ascii?Q?PmiqbyrDLXGuD1Pk89mCDiKQiGY+bepblYQsHv6LEYkWu0Ph6VMJDTRoKlo4?=
 =?us-ascii?Q?nu5vFWilt5I7gTCNzxuDmLX5qN6YGCWyc8F2omJqIrUKyciCS7pg1+0tV4rP?=
 =?us-ascii?Q?3oDGAATL0eqBm90HCYCKdwEtQ8Nf09f6OZHm5prCVLNa//Cr6xmyQTx+mjB6?=
 =?us-ascii?Q?K8+DuIpxLh3P2Q12EunwO7xhZnpJ7U4P4nQP4ebVzESqdCV+snCW8au5WdI3?=
 =?us-ascii?Q?MEXsEKO0o7kn29n9jrFxqcrXfoxgp8QZaFDzUqjr8kseVRctCE2Cx4eDUDyd?=
 =?us-ascii?Q?FFJQpKmGFrPn+rpJvUHO71FzXNL8f2IBYBFnh0vzvxZSjOrZC73SEyRm87P9?=
 =?us-ascii?Q?kJbxTAxG6jiT1RuAIsnYiuONNevrNlmTS1651700QB4spYdSwr0o1i2NFdgb?=
 =?us-ascii?Q?ZKivYFtBzNtZzZBJgc4cWCRx9OL7AabSrwvcmlNHrRoE/2pCLdNGNlogmhNn?=
 =?us-ascii?Q?tZa0V8SniqR0WFXmuPKJLynSMY1PLJzYMfcgD8VVOw0HLTTTH5UrOeG05kmC?=
 =?us-ascii?Q?4zGsjeg5qBXEwlGJLLwhtAj6y5OdbIVJBTFPb54lfjgbNkaB5/JOiBp4VmIq?=
 =?us-ascii?Q?IMtVeB0Rr3lef4xR92gitMRfG49kc+QPqmW+RAfqkGxjuhDpVfszzDYKfOhE?=
 =?us-ascii?Q?uR38FcCGqrN0s6qaxfa0jF9DUmSLgQgFI5fP9Vqq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5555c7b2-b66c-4fd2-1a44-08dc7b9834ff
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2024 02:21:23.4118
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KAwMh9sBuBv+XPZbKPdW3Lt8m56/mnFILv5A4yHOwmmlwuM6MxdO7mFjwtHocys20qwPggbW8biMVdr1accW3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8346
X-OriginatorOrg: intel.com

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Thursday, May 23, 2024 11:01 PM
>=20
> On Thu, May 23, 2024 at 06:19:59AM +0000, Tian, Kevin wrote:
> > > From: Jason Gunthorpe <jgg@nvidia.com>
> > > Sent: Wednesday, May 22, 2024 2:25 AM
> > >
> > > On Tue, May 14, 2024 at 06:59:07PM -0700, Nicolin Chen wrote:
> > > > So, you want a proxy S1 domain for a device to attach, in case
> > > > of a stage-2 only setup, because an S2 domain will no longer has
> > > > a VMID, since it's shared among viommus. In the SMMU driver case,
> > > > an arm_smmu_domain won't have an smmu pointer, so a device can't
> > > > attach to an S2 domain but always an nested S1 domain, right?
> > >
> > > That seems like a simple solution to the VMID lifetime, but it means
> > > the kernel has to decode more types of vSTE.
> > >
> >
> > why does ATC invalidation need to know about VMID?
>=20
> ATC invalidation always requires a vRID to pRID translation and the
> VIOMMU will hold that translation.
>=20
> On vCMDQ HW and on AMD HW the vRID to pRID translation is pushed into
> HW, and vCMDQ requires the VMID to do that.
>=20

At a quick glance VMID and vRID->pRID translation are both configurations
of a vintf.

My impression was that vintf->vmid is added to guest cmd when it's
about iotlb invalidation.

then vintf->sid_slots is walked when handling a guest cmd for ATC
invalidation.

I'm not sure why the latter one requires a valid VMID to do the walking
except it's a implementation choice made by vCMDQ?