Received-SPF: pass (google.com: domain of linux-kernel+bounces-188236-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 24 May 2024 10:33:15 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: Barry Song <21cnbao@gmail.com>
CC: <lkp@intel.com>, <akpm@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	<oe-kbuild-all@lists.linux.dev>, <v-songbaohua@oppo.com>
Subject: Re: include/linux/huge_mm.h:285:undefined reference to `mthp_stats'
Message-ID: <Zk/8a9zllk2NPtjN@yujie-X299>
References: <202405231728.tCAogiSI-lkp@intel.com>
 <20240523210045.40444-1-21cnbao@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240523210045.40444-1-21cnbao@gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t+e01PzlEnbjYN1xW0JNrUmwfutdZa+JQEA5W9sE6zHEj28zGdc4kgWGn97g?=
 =?us-ascii?Q?ZflEpCCgUlhv9miD/GX/ohVWroDWvM0+7nvxdyUdLHV9+72ns4tvh9uo4uor?=
 =?us-ascii?Q?EKCXde/0cXXYgGC3raO/rXfkRFjKIrYuvrRmZLeQGOL1SW3SlPHvS8c3wgF/?=
 =?us-ascii?Q?lybLOrU2nFYEqlEW53hxOwyOxagcoGSleqnchnTGW/KOkf9DNcxWCiwc9+Ld?=
 =?us-ascii?Q?4j+3e9A5gaWqBgVkxEAZipXMPueWPftq6k5nMSjpMYz24JyghcXuEzacFLiB?=
 =?us-ascii?Q?OtqERB/3QJEC7/4MRZJ4mqjGHIGdnQgObdoa2VgTy8c1C4u/xDDn8hSCJ00A?=
 =?us-ascii?Q?zeGiy3r/I0SO74O1PRSSYj04b5s/4LnshfJVv1lOGKnnFHvcwo7zmkykzeNz?=
 =?us-ascii?Q?jNHIlGcOott9+7CenMxoBGLGLLP29/Ca7wZHam0VBLlImuBfbZMI0hpJLTbZ?=
 =?us-ascii?Q?Oe6/K9A25WG7p+2iFg0Ms2UrB+3T8uBRSZrYzwQwBxbtfQVBvqQc10fnjVnQ?=
 =?us-ascii?Q?OX86p59Mvt+bT1j3haxtjx4ARizILcKQVXEsG121jSi7ZaUk+0BmQNTYF7rw?=
 =?us-ascii?Q?bakkWCqaPMcydhorceiGR5P5fi8rTz8UP/jV5eXC5XL+Fe1pYJSYiNEp39Nv?=
 =?us-ascii?Q?dAQmIhumgs0N7RG/liHaGQMZtiTRAO2kANyMlMXkzXDejHv+evPjunuifXnu?=
 =?us-ascii?Q?F/2Y4tl7CGDDcIBBrpY9trSTS9VTbzQ0ulwHKCQLsDsoy7tc5AxX7OOAFe6p?=
 =?us-ascii?Q?sdUjmFrQ+DDvCEOwco/tW4K2bUBjOUuIyVItKflVPkmNyNU1LCVd6vm3fpS9?=
 =?us-ascii?Q?/IUdon1ERrHdaOJYnUcLQPB1w2TL0pioi5D9Aa/v1TrhPjfROH1y7KX6dIr+?=
 =?us-ascii?Q?k7lqkmiTg6/3sOYEhvJUcZObNeqOVh38VTMBmXp1GoQCE0b+u4B/hyoOR7nX?=
 =?us-ascii?Q?p4qrE474Onwtvltw36S4ksbAYg1coaccgPfFO9u06P45uSJIh8uMJQnczgaW?=
 =?us-ascii?Q?wXotJQmmRFM14dvdcxyTZ2wuaJ1asu5ovtQGYn+ZF4MdIwS0+cSb7Oseb1Zh?=
 =?us-ascii?Q?2wL+eY0nbvnUHgDDkm/dewZASP7BE5w65griR9tFS1Cms/sqhtnn+N6je7ZM?=
 =?us-ascii?Q?jZsClsJ2m2aLAry/cksOMr5bYr+sLTvyNHk4QdWNH5MYlEFKlhfQk66ko6+f?=
 =?us-ascii?Q?tQIdv5bNv8WU7gbjXCAnppdyMNOw8/pWsqHxL5QamKQRsCTsppk+YM849anH?=
 =?us-ascii?Q?tYP/TjeujSAdAwvC4P/x3arzkjS0H6qDPlyaF0vscL9dgwActD1mPmBOQFnj?=
 =?us-ascii?Q?QgziNZX4tjTXMPifl80IuUpqju13ARwxfpSwaukMTOdpbM4S5IzjNbRokffc?=
 =?us-ascii?Q?RSnTwm5o+PKY8vWDOHmILbbPPTfZxXuxpW2cQZ7eltdC2j4tls/8ZvnbC+cW?=
 =?us-ascii?Q?Gz7RGllpmF7zqpl8TUXINRFvyhAIcYyYkMgTa/JyUUP343CSzjukK5ok5YEs?=
 =?us-ascii?Q?A9CMSgiBYU94Y8JvzfcYwqxqGPPmS6G4Qk98SR7R9GXxdmvs3k4VAJ1nYHzK?=
 =?us-ascii?Q?S87J1cjBj/I/eMOKk/h14b7W7sJYSNL1k3PPr84V?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bfec1c66-da7e-44ac-e612-08dc7b9b0666
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB8393.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2024 02:41:33.8313
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SP9NxUvW1Ml4/HVql/0uA3gwi7rp5QZaUrXUkdkOrar5i8iQT4wwv28qSM1S/JZ0qqGBJD2xi9fvY8j2W19R+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7489
X-OriginatorOrg: intel.com

On Fri, May 24, 2024 at 09:00:45AM +1200, Barry Song wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   c760b3725e52403dc1b28644fb09c47a83cacea6
> > commit: ec33687c674934dfefd782a8ffd58370b080b503 mm: add per-order mTHP anon_fault_alloc and anon_fault_fallback counters
> > date:   2 weeks ago
> > config: s390-randconfig-r005-20230226 (https://download.01.org/0day-ci/archive/20240523/202405231728.tCAogiSI-lkp@intel.com/config)
> > compiler: s390-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240523/202405231728.tCAogiSI-lkp@intel.com/reproduce)
> 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202405231728.tCAogiSI-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    s390-linux-ld: mm/memory.o: in function `count_mthp_stat':
> >>> include/linux/huge_mm.h:285:(.text+0x191c): undefined reference to `mthp_stats'
> >    s390-linux-ld: mm/huge_memory.o:(.rodata+0x10): undefined reference to `mthp_stats'
> > 
> > 
> > vim +285 include/linux/huge_mm.h
> > 
> >    279	
> >    280	static inline void count_mthp_stat(int order, enum mthp_stat_item item)
> >    281	{
> >    282		if (order <= 0 || order > PMD_ORDER)
> >    283			return;
> >    284	
> >>   285		this_cpu_inc(mthp_stats.stats[order][item]);
> >    286	}
> >    287	
> 
> Thanks, would you please test if the below patch fixes the problem,

The patch below fixes the problem for me. Thanks.

Tested-by: Yujie Liu <yujie.liu@intel.com>

> 
> From: Barry Song <v-songbaohua@oppo.com>
> Date: Fri, 24 May 2024 08:50:48 +1200
> Subject: [PATCH] mm: huge_mm: fix undefined reference to `mthp_stats' for
>  CONFIG_SYSFS=n
> 
> if CONFIG_SYSFS is not enabled in config, we get the below error,
> 
> All errors (new ones prefixed by >>):
> 
>    s390-linux-ld: mm/memory.o: in function `count_mthp_stat':
> >> include/linux/huge_mm.h:285:(.text+0x191c): undefined reference to `mthp_stats'
>    s390-linux-ld: mm/huge_memory.o:(.rodata+0x10): undefined reference to `mthp_stats'
> 
> vim +285 include/linux/huge_mm.h
> 
>    279
>    280  static inline void count_mthp_stat(int order, enum mthp_stat_item item)
>    281  {
>    282          if (order <= 0 || order > PMD_ORDER)
>    283                  return;
>    284
>  > 285          this_cpu_inc(mthp_stats.stats[order][item]);
>    286  }
>    287
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202405231728.tCAogiSI-lkp@intel.com/
> Signed-off-by: Barry Song <v-songbaohua@oppo.com>
> ---
>  include/linux/huge_mm.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
> index c8d3ec116e29..09c5744d9124 100644
> --- a/include/linux/huge_mm.h
> +++ b/include/linux/huge_mm.h
> @@ -278,6 +278,7 @@ struct mthp_stat {
>  	unsigned long stats[ilog2(MAX_PTRS_PER_PTE) + 1][__MTHP_STAT_COUNT];
>  };
>  
> +#ifdef CONFIG_SYSFS
>  DECLARE_PER_CPU(struct mthp_stat, mthp_stats);
>  
>  static inline void count_mthp_stat(int order, enum mthp_stat_item item)
> @@ -287,6 +288,11 @@ static inline void count_mthp_stat(int order, enum mthp_stat_item item)
>  
>  	this_cpu_inc(mthp_stats.stats[order][item]);
>  }
> +#else
> +static inline void count_mthp_stat(int order, enum mthp_stat_item item)
> +{
> +}
> +#endif
>  
>  #define transparent_hugepage_use_zero_page()				\
>  	(transparent_hugepage_flags &					\
> -- 
> 2.34.1
> 
> 
>