Received-SPF: pass (google.com: domain of linux-kernel+bounces-188242-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 23 May 2024 20:02:28 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Yuanyuan Zhong <yzhong@purestorage.com>
Cc: David Hildenbrand <david@redhat.com>, Matthew Wilcox
 <willy@infradead.org>, linux-kernel@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, Mohamed Khalfella
 <mkhalfella@purestorage.com>
Subject: Re: [PATCH] mm: /proc/pid/smaps_rollup: avoid skipping vma after
 getting mmap_lock again
Message-Id: <20240523200228.fdaa0319d3fd4bd7a62f7f8a@linux-foundation.org>
In-Reply-To: <CA+AMecHUo-sPy5wDszWgX5BWPAqMwrXqCWO1jGE5uMRq2U=BVw@mail.gmail.com>
References: <20240523183531.2535436-1-yzhong@purestorage.com>
	<20240523115624.d068dfb43afc067ed9307cfe@linux-foundation.org>
	<CA+AMecHUo-sPy5wDszWgX5BWPAqMwrXqCWO1jGE5uMRq2U=BVw@mail.gmail.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On Thu, 23 May 2024 12:16:57 -0700 Yuanyuan Zhong <yzhong@purestorage.com> wrote:

> On Thu, May 23, 2024 at 11:56 AM Andrew Morton
> <akpm@linux-foundation.org> wrote:
> >
> > Please describe the userspace-visible runtime effects of this bug.
> > This aids others in deciding which kernel version(s) need the patch.
> >
> Otherwise, with some VMAs skipped, userspace observed memory consumption
> from /proc/pid/smaps_rollup will be smaller than the sum of the
> corresponding fields from /proc/pid/smaps.
> 
> Please let me know if separate v2 is needed. Thanks

All is good, thanks.  I added the above text and the cc:stable tag.