Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp299066lqb; Thu, 23 May 2024 20:30:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX/xdxK4Cqpgtndd8YKl/lvxLlrFhKKTNBDErRCtG7hp23saeFobNZgmi9BgyZkRLS0T9IGMlZ2HSDkjt6Q5oiRJBAa1n7kdznOn5D5Ig== X-Google-Smtp-Source: AGHT+IFEiUYvt2OzTcpGemiG/UDIudX5pw+Vl5ZSy1+PTalwijA4kfLLKI5xXRwyaFp0tI4p5E1u X-Received: by 2002:a05:6214:53c8:b0:6ab:7158:b874 with SMTP id 6a1803df08f44-6abccfa63dcmr10394756d6.47.1716521431927; Thu, 23 May 2024 20:30:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716521431; cv=pass; d=google.com; s=arc-20160816; b=jrvuBfJDYq7tLO3OZbwrgtw3rgW/+ArDEeeMZrUXFRmySJE8tnNGkZooDHnGA1sv8F Tn5nnzcEtZAgq/XGHFGyw40CD+TOGCrx6sA23beA+l2vwiVTRLujtq+x7C3EEVv2pyO5 nIS+3PuIypfg/Ov/laE65l3TqewaFH9UUKMBLFiuBfYhS4rMf9Jcl8Xz3Vte0n3wrCJv YLyosb19bPRo8C/+vSaCqwPeba15/Sp2iOdH8MUmhsKUVpiKkvi0AEmgYWznCtHDziBM +MhRgWP4j7Qvvy/e2jxHjZg1ycPkEY4+dgXk5hQzbdCv6IhMN6NBRuWDdpeedZV7LKap sdqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=JHKMfm1mYmtXWBvQ7k66+MqPWlnoYo7Iqfi7HLGaxm0=; fh=o0Jgf482TjWlknm0VxzeOfDCXq+LqQpacVRAIMvwGhM=; b=iyl8f3xHcKMIIIDkjY+blqUgf8liILc0X6wghor7qU86wqIg7TaF4dKJyoUhDI2kKJ WX+cL5Jle/96wWGPrx55yX6PrSm4DpVa8V5qZmjtgnGjruDlLAte9kj4AS/GAfkyk6eR XUPoeNiB10hcgOZi+m506CIoEj5MTQO9VkgSLZyfSz2JYqPCpSxCLou9++dI7LD+XZeD mlRFQzqB8TTPCZA4GdXPI6nAAHILmPgok2dOrrSfZtR6moZgNizaJbgZLq81ZlqO03Rv LI3cvfXIrWrwcGBeQ4+1pbRUwOlxm8uaExqrZsAMbCJiE3sx50Jqzp39bNfHT9u6p4FJ WNOQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=av6yQrEk; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-188254-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188254-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6ac06f4fe38si7302576d6.73.2024.05.23.20.30.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 20:30:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-188254-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=av6yQrEk; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-188254-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-188254-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 82E081C20DDC for ; Fri, 24 May 2024 03:30:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2D454374E9; Fri, 24 May 2024 03:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="av6yQrEk" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C809622F03 for ; Fri, 24 May 2024 03:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716521424; cv=none; b=RnBvH6SYexXDTefmO2m5dbgMXWArg5QpYojGHKheO0Rlwf6bq7WuTWseq88WXLTsJB26WGIegShZAdXxVV2ZR9z+MIQ+7PhdgWmhNVEX/MJR5FRuaqUjO5dSq0g4t+DNY6Lgod0dMm2+cRavFNiZ95Ni6JAOziX+9RqksbpLsI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716521424; c=relaxed/simple; bh=xkaLxk4meNwxWBCKUk3E7glOS8Ot23OguWIkyNFPEUM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dBZ5sw4HAkeYrjDrBe6ZoKz5XIhQh40u+Rk5yfGEqikXpiy8LG/1+CNjGEejKarHdkf5D19VNBNKLHmQR6JNDlLqgRYrqxnBrPsQqpxZAWhYHuThOC37OD+qiOWnzI+XXqmueXqpsdrjyG0XXmlx7txY/o16aOA5zioojw/eSas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=av6yQrEk; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716521423; x=1748057423; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=xkaLxk4meNwxWBCKUk3E7glOS8Ot23OguWIkyNFPEUM=; b=av6yQrEk0pKXmi9oznZ5vtIbzvyd6t5Ez0oOZfcRbSaF3gsl54YrunC0 LIA8pyFFP0oBiYY4e6xmMxSpXo3S6Cxc72vE1fofCj3lUE8zlSDY7BfNv Fy9qFX9W6cfPS4R2mYkJlobkrX30I4FhHOjJlCcs9ZGxiX5HZvgkYUJAV 5VhvkbIPYruo7izZWmfPvU3ouNzMFVDWc6uav3PGmlo9qlDcQYIMeI6u0 pVhvyRTyVoyfeSasoSh/yTCqhNvs67rTF4Pn3Y/DjboCp9zrtOhSdAiJw FFOSLopDeelOXLoAdQHjLvWeBVa/f0CqX8nbA8CLy4Xh+waAxny6S3GJc A==; X-CSE-ConnectionGUID: XsOBG/ZoTQ+/cx43TV//pw== X-CSE-MsgGUID: LDgA+u8NThOE4HK/E2kJfA== X-IronPort-AV: E=McAfee;i="6600,9927,11081"; a="23452513" X-IronPort-AV: E=Sophos;i="6.08,184,1712646000"; d="scan'208";a="23452513" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 20:30:23 -0700 X-CSE-ConnectionGUID: g06c64MBQqKNBaY6L2tqyQ== X-CSE-MsgGUID: jv2LXXkZQfikazMCp6mktA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,184,1712646000"; d="scan'208";a="33802324" Received: from unknown (HELO [10.125.110.91]) ([10.125.110.91]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 20:30:21 -0700 Message-ID: <7b6b6430-0237-4512-b99b-9eb815b3dc68@intel.com> Date: Thu, 23 May 2024 20:30:19 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 2/2] mm/x86/pat: Do proper PAT bit shift for large mappings To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Jason Gunthorpe , Andrew Morton , Al Viro , Dave Hansen , Andy Lutomirski , Matthew Wilcox , Dan Williams , "Kirill A . Shutemov" , Mike Rapoport , Ingo Molnar , Michal Hocko , Alex Williamson , Peter Zijlstra , Suren Baghdasaryan , Borislav Petkov , x86@kernel.org References: <20240523223745.395337-1-peterx@redhat.com> <20240523223745.395337-3-peterx@redhat.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/23/24 16:07, Peter Xu wrote: > Probably not.. I think I can define a pgprot_to_large() globally, pointing > that to pgprot_4k_2_large() on x86 and make the fallback to be noop. And > if there's a new version I'll guarantee to run over my cross compilers. I guess that would be functional, but it would be a bit mean to everybody else. > Any comments on the idea itself? Do we have a problem, or maybe I > overlooked something? I think it's probably unnecessary to inflict this particular x86-ism on generic code. The arch-generic 'prot' should have PAT at its 4k (_PAGE_BIT_PAT) position and then p*d_mkhuge() can shift it into the _PAGE_BIT_PAT_LARGE spot.