Received-SPF: pass (google.com: domain of linux-kernel+bounces-188270-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Feedback-ID: ie8e14432:Fastmail
Date: Fri, 24 May 2024 12:40:19 +0900
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] firewire: add missing MODULE_DESCRIPTION() to test
 modules
Message-ID: <20240524034019.GA276112@workstation.local>
Mail-Followup-To: Jeff Johnson <quic_jjohnson@quicinc.com>,
	linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
References: <20240523-md-firewire-uapi-test-v1-1-6be5adcc3aed@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240523-md-firewire-uapi-test-v1-1-6be5adcc3aed@quicinc.com>

Hi,

Thank you for your sending the patch.

On Thu, May 23, 2024 at 04:22:34PM -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firewire/uapi-test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firewire/packet-serdes-test.o
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/firewire/packet-serdes-test.c | 1 +
>  drivers/firewire/uapi-test.c          | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/firewire/packet-serdes-test.c b/drivers/firewire/packet-serdes-test.c
> index f93c966e794d..e83b1fece780 100644
> --- a/drivers/firewire/packet-serdes-test.c
> +++ b/drivers/firewire/packet-serdes-test.c
> @@ -579,4 +579,5 @@ static struct kunit_suite packet_serdes_test_suite = {
>  };
>  kunit_test_suite(packet_serdes_test_suite);
>  
> +MODULE_DESCRIPTION("FireWire packet serialization/deserialization unit test suite");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/firewire/uapi-test.c b/drivers/firewire/uapi-test.c
> index 2fcbede4fab1..bc3f10a2e516 100644
> --- a/drivers/firewire/uapi-test.c
> +++ b/drivers/firewire/uapi-test.c
> @@ -86,4 +86,5 @@ static struct kunit_suite structure_layout_test_suite = {
>  };
>  kunit_test_suite(structure_layout_test_suite);
>  
> +MODULE_DESCRIPTION("FireWire UAPI unit test suite");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 5c4069234f68372e80e4edfcce260e81fd9da007
> change-id: 20240523-md-firewire-uapi-test-08fb0a9e18de
 
In my opinion, it is not so urgent. I would like to postpone sending it
to mainline until closing the current merge window.


Thanks

Takashi Sakamoto