Received-SPF: pass (google.com: domain of linux-kernel+bounces-188333-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>
CC: Jason Gunthorpe <jgg@nvidia.com>, "will@kernel.org" <will@kernel.org>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"joro@8bytes.org" <joro@8bytes.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "iommu@lists.linux.dev"
	<iommu@lists.linux.dev>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "Liu, Yi L" <yi.l.liu@intel.com>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>, "vasant.hegde@amd.com"
	<vasant.hegde@amd.com>, "jon.grimm@amd.com" <jon.grimm@amd.com>,
	"santosh.shukla@amd.com" <santosh.shukla@amd.com>, "Dhaval.Giani@amd.com"
	<Dhaval.Giani@amd.com>, "shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>
Subject: RE: [PATCH RFCv1 12/14] iommufd: Add IOMMUFD_OBJ_VQUEUE and
 IOMMUFD_CMD_VQUEUE_ALLOC
Thread-Topic: [PATCH RFCv1 12/14] iommufd: Add IOMMUFD_OBJ_VQUEUE and
 IOMMUFD_CMD_VQUEUE_ALLOC
Thread-Index: AQHajVVtTIyOrzFsYEOvw2C4tndA2rGT4ByAgBDBXkCAAW1WgIAAC77w
Date: Fri, 24 May 2024 05:26:50 +0000
Message-ID: <BN9PR11MB527672C2366F7F6DCA33FD948CF52@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1712978212.git.nicolinc@nvidia.com>
 <b0ee53af3f59602834e67ddf86c748ca304da175.1712978213.git.nicolinc@nvidia.com>
 <ZkDZ/YO0jqZOlRtA@nvidia.com>
 <BN9PR11MB527668B2398FE65771A429D08CF42@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZlAao39Zc+9moEDP@nvidia.com>
In-Reply-To: <ZlAao39Zc+9moEDP@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?s/kVAplEobrQBmySXqXo1aKIl9RUxkcyHkYanMUtgtVZH/Q4SmDZHRd8b9Qx?=
 =?us-ascii?Q?nt04bsrl5e0IpYIYUAPd3FHoy0pmYa+CLApqVz88+YS6jQwd3WCmf+67ucWc?=
 =?us-ascii?Q?7PFUCQYmlrFYmdrxmuDQ6Fuzkcz1nBqHQvb/skIi2M64tVF8Q6KHlpRLdnV1?=
 =?us-ascii?Q?Mk0yQvo9BPwAqYwLmLXshX1a9EdH4th6E1/4wPQUdBvlmy0rSExNDVuDY4J+?=
 =?us-ascii?Q?l3aDKbugBJxdodnanG8REFfLwAycikM8x1CrXMRz/Dq1m5jYVC0y1MzrKTGP?=
 =?us-ascii?Q?U1yZNb+pKr20PwHugeVfb1P1mRxY9lpOrR8X+e3e0RFeBY0t3bL4QslRiqyK?=
 =?us-ascii?Q?61KNzK8//rdR6Oh8wG8SZLN/CXtkSNYVYb7hygvs1I8YaM+BVm2R0F6RqoBw?=
 =?us-ascii?Q?qUmU/FGR00eyaB2Gt50KHPbh6quNLh6vgzHOHyPCskd4MIgQDcC9N0jHPRKM?=
 =?us-ascii?Q?avpPkxetA1pppMQnT8BNj4iwcZEy2QHxbMv2oEEROZRYZ3qO/qE/9xsYNex9?=
 =?us-ascii?Q?h3b0J7oVUPbNZYciJMH4dl637nmFT+0L7QzJgYjL2XKMWReXAU7CcR5SXPtL?=
 =?us-ascii?Q?nFeBXkPBIZVY96M+1Uh8NhMgi2ov/ixVbvKoPdNzGmFU4G/q4RlFwzm+3VuE?=
 =?us-ascii?Q?ESjdoWyjdQCEwB70barUJiODlBup1PneuV85OoDiffXsRz9S32fCYwsnGyfX?=
 =?us-ascii?Q?ogjHCrhUzCLtaUFqVDSD5ByPxJm+XIUKO4Lg8wW5sjk6DajutNQte6mg3NsA?=
 =?us-ascii?Q?mVFRBPYDiltS9hEhTpI7n9x0Z6cmw209UlBSc2ulxavXxJXr8OY7pLrMkU20?=
 =?us-ascii?Q?LKMScsI9HSMzLK3NVwBiMNOX1boW2qrlSIMIbkcQG4QpVCwmEG2VXEVxOXbA?=
 =?us-ascii?Q?0Ahhw1J7Z1KeqtM9FCoC42e4ozQenyEezS52l5YlvojGMM95iDW/qSnNMuKv?=
 =?us-ascii?Q?CHYwwkpkb4uNpj2I9g9o9GJxBqqz1cvceghmhZf/RfaDnazCu/VG8jmhbDhf?=
 =?us-ascii?Q?WPm5cpC67AsjNFi8EvMOodgWQJPGFH9QxJhQrJw7AERD307YhDC2Aobe2ENp?=
 =?us-ascii?Q?PhHDjPqGAvjcongzJhFyWp5byCMBCO1cW+TqE1ncm9/x19dwPX3ylrnuJYXz?=
 =?us-ascii?Q?8WHVa90RGtiZUY1itUMb6jhU5OzrM7o5JO+Tk6GSJr05TCUpzKgKUsi3AJOj?=
 =?us-ascii?Q?pwXzDjneSFvojrGVFLhHtxx+9yubz8c2+JGSYzOjf6H2J5mvJXzZUd4YSJk6?=
 =?us-ascii?Q?2zGplgQWTLXG6p+A6GhrCOOMJetKO+8qLZ1piOzMDQEqHYQSL977W2MaEUC0?=
 =?us-ascii?Q?jfd5eGhRghEeSBZ39W5ydzQOa3I+62fw0zCriEoqhVQsdwUmR6iWsMDVm4ws?=
 =?us-ascii?Q?MfBAWVBMSRChTIzlb2eWd3gP+CmpWtY9LekR4AxYeLSKGd5nehIwF6lOeGtF?=
 =?us-ascii?Q?Dj+zmivFIicVGrh9mGAMqn45QHnleqlOGKQxqD2BjU6H9O4ynlT5NMuw2Bvi?=
 =?us-ascii?Q?YNX/IEalmXIRbB+ytVGzJe6MAVMDHxnDAL4TSj4Dtc2712FczR9gnYsh/R5R?=
 =?us-ascii?Q?QDjC+7fKZVztoAZqgtmBMykrY/aUFiwTWSMp8EyZ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 702ad153-ec38-4685-7f9a-08dc7bb21d58
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2024 05:26:50.6452
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oOHzCux32tWobWx4ujz4yQ5GYP3nBXBTqjAvpg58+pwpfpaotmJ9FgRzgodrKIGjtCGkVkbwpZrDxM4xl3LXvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8275
X-OriginatorOrg: intel.com

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Friday, May 24, 2024 12:42 PM
>=20
> On Thu, May 23, 2024 at 06:57:15AM +0000, Tian, Kevin wrote:
> > > From: Jason Gunthorpe <jgg@nvidia.com>
> > > Sent: Sunday, May 12, 2024 11:02 PM
> > >
> > > On Fri, Apr 12, 2024 at 08:47:09PM -0700, Nicolin Chen wrote:
> > >
> > > > +/**
> > > > + * struct iommu_vqueue_alloc - ioctl(IOMMU_VQUEUE_ALLOC)
> > > > + * @size: sizeof(struct iommu_vqueue_alloc)
> > > > + * @flags: Must be 0
> > > > + * @viommu_id: viommu ID to associate the virtual queue with
> > > > + * @out_vqueue_id: The ID of the new virtual queue
> > > > + * @data_type: One of enum iommu_vqueue_data_type
> > > > + * @data_len: Length of the type specific data
> > > > + * @data_uptr: User pointer to the type specific data
> > > > + *
> > > > + * Allocate an virtual queue object for driver-specific HW-acceler=
ated
> > > queue
> > > > + */
> > > > +
> > > > +struct iommu_vqueue_alloc {
> > > > +   __u32 size;
> > > > +   __u32 flags;
> > > > +   __u32 viommu_id;
> > > > +   __u32 out_vqueue_id;
> > > > +   __u32 data_type;
> > > > +   __u32 data_len;
> > > > +   __aligned_u64 data_uptr;
> > >
> > > Some of the iommus will want an IPA here not a user pointer. I think
> > > it is fine API wise, we'd just add a flag to indicate data_uptr is an
> > > IPA.
> > >
> >
> > Presumably each driver will create its own type data which can
> > include any IPA field as vcmdq_base in this patch?
>=20
> You mean putting a base address field in this common vqueue
> structure? Hmm, I think we could, assuming every queue must
> have a set of base and size info in the guest level.
>=20

We could, but my original point was just that it's confusing to
change the meaning of data_uptr. Let's stick it to be driver defined
data and any driver-specific IPA field is defined in that data.

Of course if we think the base address is common enough it can
be moved to the common vqueue structure too.