Received-SPF: pass (google.com: domain of linux-kernel+bounces-188365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 24 May 2024 08:45:40 +0200
From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Suman Ghosh <sumang@marvell.com>
CC: "andrew@lunn.ch" <andrew@lunn.ch>, "hkallweit1@gmail.com"
	<hkallweit1@gmail.com>, "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"davem@davemloft.net" <davem@davemloft.net>, "edumazet@google.com"
	<edumazet@google.com>, "kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: micrel: Fix lan8841_config_intr after getting
 out of sleep mode
Message-ID: <20240524064540.azzmscw5k333zerr@DEN-DL-M31836.microchip.com>
References: <20240523074226.3540332-1-horatiu.vultur@microchip.com>
 <SJ0PR18MB52169D42D6D26244E003BCC8DBF42@SJ0PR18MB5216.namprd18.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <SJ0PR18MB52169D42D6D26244E003BCC8DBF42@SJ0PR18MB5216.namprd18.prod.outlook.com>

The 05/23/2024 16:35, Suman Ghosh wrote:

Hi Suman,

> 
> >       if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
> >               err = phy_read(phydev, LAN8814_INTS);
> >-              if (err)
> >+              if (err < 0)
> [Suman] Hi Horatiu,
> Should we modify this check for phy_write() as well?

I don't think we should modify this check for phy_write.
Because phy_write always return the error code. Which is negative or 0.

> >                       return err;
> >
> >               /* Enable / disable interrupts. It is OK to enable PTP
> >interrupt
> >--
> >2.34.1
> >
> 

-- 
/Horatiu