Received-SPF: pass (google.com: domain of linux-kernel+bounces-188366-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <b695a2a3-2b4f-400d-a0b7-5d436926f49a@collabora.com>
Date: Fri, 24 May 2024 12:16:11 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/6] drm/ci: uprev mesa version
Content-Language: en-US
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: dri-devel@lists.freedesktop.org, daniels@collabora.com,
 helen.koike@collabora.com, airlied@gmail.com, daniel@ffwll.ch,
 robdclark@gmail.com, david.heidelberg@collabora.com,
 guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com,
 mcanal@igalia.com, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org,
 amd-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
 intel-gfx@lists.freedesktop.org, virtualization@lists.linux-foundation.org,
 linux-kernel@vger.kernel.org
References: <20240517092502.647420-1-vignesh.raman@collabora.com>
 <20240517092502.647420-2-vignesh.raman@collabora.com>
 <2qzmfv3oc6feihwxu3tl37rg6w3qsj2vddu5olvqk6vhqr26cc@bxu5y6ijvtfa>
 <9cd0667a-12ee-4d45-80e8-dc34259bf01d@collabora.com>
 <CAA8EJprVVkQO7aPkehwL2zhYkGRkm4Foc13ErfuY6ikBA_4nLQ@mail.gmail.com>
From: Vignesh Raman <vignesh.raman@collabora.com>
In-Reply-To: <CAA8EJprVVkQO7aPkehwL2zhYkGRkm4Foc13ErfuY6ikBA_4nLQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Dmitry,

On 23/05/24 15:29, Dmitry Baryshkov wrote:
> On Thu, 23 May 2024 at 09:07, Vignesh Raman <vignesh.raman@collabora.com> wrote:
>>
>> Hi Dmitry,
>>
>> On 20/05/24 16:13, Dmitry Baryshkov wrote:
>>> On Fri, May 17, 2024 at 02:54:57PM +0530, Vignesh Raman wrote:
>>>> zlib.net is not allowing tarball download anymore and results
>>>> in below error in kernel+rootfs_arm32 container build,
>>>> urllib.error.HTTPError: HTTP Error 403: Forbidden
>>>> urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type
>>>>
>>>> Uprev mesa to latest version which includes a fix for this issue.
>>>> https://gitlab.freedesktop.org/mesa/mesa/-/commit/908f444e
>>>>
>>>> Use id_tokens for JWT authentication. Since s3 bucket is migrated to
>>>> mesa-rootfs, update the variables accordingly. Also copy helper scripts
>>>> to install, so that the ci jobs can use these scripts for logging.
>>>>
>>>> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
>>>> ---
>>>>
>>>> v2:
>>>>     - Uprev to recent version and use id_tokens for JWT authentication
>>>>
>>>> ---
>>>>    drivers/gpu/drm/ci/build-igt.sh   |  2 +-
>>>>    drivers/gpu/drm/ci/build.sh       |  6 +++--
>>>>    drivers/gpu/drm/ci/container.yml  | 12 +++------
>>>>    drivers/gpu/drm/ci/gitlab-ci.yml  | 44 +++++++++++++++++++++----------
>>>>    drivers/gpu/drm/ci/image-tags.yml |  2 +-
>>>>    drivers/gpu/drm/ci/lava-submit.sh |  4 +--
>>>>    drivers/gpu/drm/ci/test.yml       |  2 ++
>>>>    7 files changed, 44 insertions(+), 28 deletions(-)
>>>>
>>>
>>> [skipped]
>>>
>>>> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
>>>> index 8bc63912fddb..612c9ede3507 100644
>>>> --- a/drivers/gpu/drm/ci/test.yml
>>>> +++ b/drivers/gpu/drm/ci/test.yml
>>>> @@ -150,6 +150,8 @@ msm:sdm845:
>>>>        BM_KERNEL: https://${PIPELINE_ARTIFACTS_BASE}/arm64/cheza-kernel
>>>>        GPU_VERSION: sdm845
>>>>        RUNNER_TAG: google-freedreno-cheza
>>>> +    DEVICE_TYPE: sdm845-cheza-r3
>>>> +    FARM: google
>>>
>>> I see that this is the only user of the FARM: tag. Is it correct?
>>
>> No, we need to add FARM variable for other jobs as well.
> 
> Why? Even if we have to, we don't have them now and the change doesn't
> seem to be related to the uprev'ing of mesa. So this probably should
> go to a separate commit.

I will move them to separate commit.

Regards,
Vignesh

> 
>>
>>> Also we miss DEVICE_TYPE for several other boards. Should we be adding
>>> them?
>>
>> Yes, device type needs to be added for msm:apq8016, msm:apq8096, virtio_gpu.
>>
>> I will add this. Thanks.
> 
> I'd guess, separate commit too.
> 
>>
>> Regards,
>> Vignesh
>>
>>>
>>>>      script:
>>>>        - ./install/bare-metal/cros-servo.sh
>>>>
>>>> --
>>>> 2.40.1
>>>>
>>>
> 
> 
>