Received-SPF: pass (google.com: domain of linux-kernel+bounces-188373-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 24 May 2024 08:56:50 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: quic_zijuhu <quic_zijuhu@quicinc.com>
Cc: rafael@kernel.org, akpm@linux-foundation.org, dmitry.torokhov@gmail.com,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] kobject_uevent: Fix OOB access within zap_modalias_env()
Message-ID: <2024052458-unleash-atom-489b@gregkh>
References: <1716524403-5415-1-git-send-email-quic_zijuhu@quicinc.com>
 <2024052418-casket-partition-c143@gregkh>
 <74465bf5-ca18-45f8-a881-e95561c59a02@quicinc.com>
 <2024052438-hesitate-chevron-dbd7@gregkh>
 <5acce173-0224-4a05-ae88-3eb1833fcb39@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5acce173-0224-4a05-ae88-3eb1833fcb39@quicinc.com>

On Fri, May 24, 2024 at 01:34:49PM +0800, quic_zijuhu wrote:
> On 5/24/2024 1:21 PM, Greg KH wrote:
> > On Fri, May 24, 2024 at 01:15:01PM +0800, quic_zijuhu wrote:
> >> On 5/24/2024 12:33 PM, Greg KH wrote:
> >>> On Fri, May 24, 2024 at 12:20:03PM +0800, Zijun Hu wrote:
> >>>> zap_modalias_env() wrongly calculates size of memory block
> >>>> to move, so maybe cause OOB memory access issue, fixed by
> >>>> correcting size to memmove.
> >>>
> >>> "maybe" or "does"?  That's a big difference :)
> >>>
> >> i found this issue by reading code instead of really meeting this issue.
> >> this issue should be prone to happen if there are more than 1 other
> >> environment vars.
> > 
> > But does it?  Given that we have loads of memory checkers, and I haven't
> > ever seen any report of any overrun, it would be nice to be sure.
> > 
> yes. if @env includes env vairable MODALIAS and  more than one other env
> vairables. then (env->buflen - len) must be greater that actual size of
> "target block" shown previously, so the OOB issue must happen.

Then why are none of the tools that we have for catching out-of-bound
issues triggered here?  Are the tools broken or is this really just not
ever happening?  It would be good to figure that out...

thanks,

greg k-h